Title: [92637] trunk/Tools
- Revision
- 92637
- Author
- [email protected]
- Date
- 2011-08-08 14:37:55 -0700 (Mon, 08 Aug 2011)
Log Message
Deprecate rebaseline-chromium-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=65873
Reviewed by Dimitri Glazkov.
This script never worked correctly and now is redundant with more
modern infrastructure for rebaselining tests. This patch deprecates
the script in order to flush out any issues with the new tools. Once
folks are happy with the new tools, we'll delete this script.
* Scripts/rebaseline-chromium-webkit-tests:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (92636 => 92637)
--- trunk/Tools/ChangeLog 2011-08-08 21:35:08 UTC (rev 92636)
+++ trunk/Tools/ChangeLog 2011-08-08 21:37:55 UTC (rev 92637)
@@ -1,3 +1,17 @@
+2011-08-08 Adam Barth <[email protected]>
+
+ Deprecate rebaseline-chromium-webkit-tests
+ https://bugs.webkit.org/show_bug.cgi?id=65873
+
+ Reviewed by Dimitri Glazkov.
+
+ This script never worked correctly and now is redundant with more
+ modern infrastructure for rebaselining tests. This patch deprecates
+ the script in order to flush out any issues with the new tools. Once
+ folks are happy with the new tools, we'll delete this script.
+
+ * Scripts/rebaseline-chromium-webkit-tests:
+
2011-08-08 Dimitri Glazkov <[email protected]>
garden-o-matic should only touch expectations that need updating.
Modified: trunk/Tools/Scripts/rebaseline-chromium-webkit-tests (92636 => 92637)
--- trunk/Tools/Scripts/rebaseline-chromium-webkit-tests 2011-08-08 21:35:08 UTC (rev 92636)
+++ trunk/Tools/Scripts/rebaseline-chromium-webkit-tests 2011-08-08 21:37:55 UTC (rev 92637)
@@ -31,6 +31,13 @@
import webkitpy.to_be_moved.rebaseline_chromium_webkit_tests
+
if __name__ == '__main__':
- # FIXME: We shouldn't pass sys.argv to rebaseline_chromium_webkit_tests.
- sys.exit(webkitpy.to_be_moved.rebaseline_chromium_webkit_tests.main(sys.argv[1:]))
+ print """This script is depreciated. Please use use "webkit-patch rebaseline-expectations" instead.
+
+If that command does not work properly, please file a bug and CC abarth. If you
+really need to use the old script, run this command again with
+--use-deprecated-script as the first argument."""
+
+ if len(sys.argv) > 1 and sys.argv[1] == '--use-deprecated-script':
+ sys.exit(webkitpy.to_be_moved.rebaseline_chromium_webkit_tests.main(sys.argv[2:]))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
