Title: [92744] trunk
- Revision
- 92744
- Author
- [email protected]
- Date
- 2011-08-09 19:04:06 -0700 (Tue, 09 Aug 2011)
Log Message
Source/WebCore: Style change not propagating for before, after content
for table parts.
https://bugs.webkit.org/show_bug.cgi?id=51862
Fix by Chris Evans ([email protected]).
In the table case, make sure to return the before /
after parent rather then the before / after node
itself.
Patch by Abhishek Arya <[email protected]> on 2011-08-09
Reviewed by Simon Fraser.
* rendering/RenderObjectChildList.cpp:
(WebCore::findBeforeAfterParent):
LayoutTests: Fix functional bug where style change was not getting propogated to before, after
content.
https://bugs.webkit.org/show_bug.cgi?id=51862
Patch by Abhishek Arya <[email protected]> on 2011-08-09
Reviewed by Simon Fraser.
* platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png:
* platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (92743 => 92744)
--- trunk/LayoutTests/ChangeLog 2011-08-10 01:49:02 UTC (rev 92743)
+++ trunk/LayoutTests/ChangeLog 2011-08-10 02:04:06 UTC (rev 92744)
@@ -1,3 +1,14 @@
+2011-08-09 Abhishek Arya <[email protected]>
+
+ Fix functional bug where style change was not getting propogated to before, after
+ content.
+ https://bugs.webkit.org/show_bug.cgi?id=51862
+
+ Reviewed by Simon Fraser.
+
+ * platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png:
+ * platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png:
+
2011-08-09 Kent Tamura <[email protected]>
Another follow-up for r92728.
Modified: trunk/LayoutTests/platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png
(Binary files differ)
Modified: trunk/Source/WebCore/ChangeLog (92743 => 92744)
--- trunk/Source/WebCore/ChangeLog 2011-08-10 01:49:02 UTC (rev 92743)
+++ trunk/Source/WebCore/ChangeLog 2011-08-10 02:04:06 UTC (rev 92744)
@@ -1,3 +1,19 @@
+2011-08-09 Abhishek Arya <[email protected]>
+
+ Style change not propagating for before, after content
+ for table parts.
+ https://bugs.webkit.org/show_bug.cgi?id=51862
+
+ Fix by Chris Evans ([email protected]).
+ In the table case, make sure to return the before /
+ after parent rather then the before / after node
+ itself.
+
+ Reviewed by Simon Fraser.
+
+ * rendering/RenderObjectChildList.cpp:
+ (WebCore::findBeforeAfterParent):
+
2011-08-09 Luke Macpherson <[email protected]>
Implement string based properties in CSSStyleApplyProperty.
Modified: trunk/Source/WebCore/rendering/RenderObjectChildList.cpp (92743 => 92744)
--- trunk/Source/WebCore/rendering/RenderObjectChildList.cpp 2011-08-10 01:49:02 UTC (rev 92743)
+++ trunk/Source/WebCore/rendering/RenderObjectChildList.cpp 2011-08-10 02:04:06 UTC (rev 92744)
@@ -258,7 +258,7 @@
RenderObject* beforeAfterParent = object;
while (beforeAfterParent && !(beforeAfterParent->isText() || beforeAfterParent->isImage()))
beforeAfterParent = beforeAfterParent->firstChild();
- return beforeAfterParent;
+ return beforeAfterParent ? beforeAfterParent->parent() : 0;
}
RenderObject* RenderObjectChildList::beforePseudoElementRenderer(const RenderObject* owner) const
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
