Diff
Modified: trunk/LayoutTests/ChangeLog (92746 => 92747)
--- trunk/LayoutTests/ChangeLog 2011-08-10 04:43:59 UTC (rev 92746)
+++ trunk/LayoutTests/ChangeLog 2011-08-10 04:51:50 UTC (rev 92747)
@@ -1,3 +1,12 @@
+2011-08-09 Dominic Cooney <[email protected]>
+
+ [V8] The prototype property of DOM constructors should be read-only.
+ https://bugs.webkit.org/show_bug.cgi?id=39655
+
+ Reviewed by Dimitri Glazkov.
+
+ * platform/chromium/test_expectations.txt: Unskip test for prototypes.
+
2011-08-09 Kent Tamura <[email protected]>
Move <input type=time> tests to fast/forms/time/
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92746 => 92747)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-10 04:43:59 UTC (rev 92746)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-10 04:51:50 UTC (rev 92747)
@@ -1955,8 +1955,6 @@
BUGCR62301 MAC : canvas/philip/tests/2d.shadow.enable.y.html = TEXT
BUGCR62301 MAC : canvas/philip/tests/2d.strokeRect.zero.4.html = TEXT
-BUGWK39655 : fast/dom/prototype-property.html = FAIL
-
// These SVG tests have been flaky on Win from quite some time.
// Hard to pin down which roll introduced the flakiness.
BUGCR45106 WIN : svg/clip-path/clip-path-evenodd-nonzero.svg = PASS CRASH
Modified: trunk/Source/WebCore/ChangeLog (92746 => 92747)
--- trunk/Source/WebCore/ChangeLog 2011-08-10 04:43:59 UTC (rev 92746)
+++ trunk/Source/WebCore/ChangeLog 2011-08-10 04:51:50 UTC (rev 92747)
@@ -1,3 +1,22 @@
+2011-08-09 Dominic Cooney <[email protected]>
+
+ [V8] The prototype property of DOM constructors should be read-only.
+ https://bugs.webkit.org/show_bug.cgi?id=39655
+
+ Reviewed by Dimitri Glazkov.
+
+ Test: fast/dom/prototype-property.html
+
+ * bindings/scripts/CodeGeneratorV8.pm: Make prototypes read-only.
+ * bindings/scripts/test/V8/V8TestInterface.cpp: Update expectations.
+ (WebCore::ConfigureV8TestInterfaceTemplate):
+ * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
+ (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::ConfigureV8TestObjTemplate):
+ * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
+ (WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
+
2011-08-09 Abhishek Arya <[email protected]>
Style change not propagating for before, after content
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (92746 => 92747)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-08-10 04:43:59 UTC (rev 92746)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-08-10 04:51:50 UTC (rev 92747)
@@ -2015,6 +2015,8 @@
push(@implContent, <<END);
static v8::Persistent<v8::FunctionTemplate> Configure${className}Template(v8::Persistent<v8::FunctionTemplate> desc)
{
+ desc->ReadOnlyPrototype();
+
v8::Local<v8::Signature> defaultSignature = configureTemplate(desc, \"${visibleInterfaceName}\", $parentClassTemplate, V8${interfaceName}::internalFieldCount,
END
# Set up our attributes if we have them
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp (92746 => 92747)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp 2011-08-10 04:43:59 UTC (rev 92746)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp 2011-08-10 04:51:50 UTC (rev 92747)
@@ -48,6 +48,8 @@
}
static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestInterfaceTemplate(v8::Persistent<v8::FunctionTemplate> desc)
{
+ desc->ReadOnlyPrototype();
+
v8::Local<v8::Signature> defaultSignature = configureTemplate(desc, "TestInterface", v8::Persistent<v8::FunctionTemplate>(), V8TestInterface::internalFieldCount,
0, 0,
0, 0);
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp (92746 => 92747)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp 2011-08-10 04:43:59 UTC (rev 92746)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp 2011-08-10 04:51:50 UTC (rev 92747)
@@ -55,6 +55,8 @@
};
static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestMediaQueryListListenerTemplate(v8::Persistent<v8::FunctionTemplate> desc)
{
+ desc->ReadOnlyPrototype();
+
v8::Local<v8::Signature> defaultSignature = configureTemplate(desc, "TestMediaQueryListListener", v8::Persistent<v8::FunctionTemplate>(), V8TestMediaQueryListListener::internalFieldCount,
0, 0,
TestMediaQueryListListenerCallbacks, WTF_ARRAY_LENGTH(TestMediaQueryListListenerCallbacks));
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (92746 => 92747)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2011-08-10 04:43:59 UTC (rev 92746)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2011-08-10 04:51:50 UTC (rev 92747)
@@ -1287,6 +1287,8 @@
static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestObjTemplate(v8::Persistent<v8::FunctionTemplate> desc)
{
+ desc->ReadOnlyPrototype();
+
v8::Local<v8::Signature> defaultSignature = configureTemplate(desc, "TestObj", v8::Persistent<v8::FunctionTemplate>(), V8TestObj::internalFieldCount,
TestObjAttrs, WTF_ARRAY_LENGTH(TestObjAttrs),
TestObjCallbacks, WTF_ARRAY_LENGTH(TestObjCallbacks));
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp (92746 => 92747)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp 2011-08-10 04:43:59 UTC (rev 92746)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp 2011-08-10 04:51:50 UTC (rev 92747)
@@ -44,6 +44,8 @@
static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestSerializedScriptValueInterfaceTemplate(v8::Persistent<v8::FunctionTemplate> desc)
{
+ desc->ReadOnlyPrototype();
+
v8::Local<v8::Signature> defaultSignature = configureTemplate(desc, "TestSerializedScriptValueInterface", v8::Persistent<v8::FunctionTemplate>(), V8TestSerializedScriptValueInterface::internalFieldCount,
0, 0,
0, 0);
