Title: [92791] trunk
- Revision
- 92791
- Author
- [email protected]
- Date
- 2011-08-10 13:12:26 -0700 (Wed, 10 Aug 2011)
Log Message
Source/WebCore: Don't create html renderer for SVG <glyphRef>
https://bugs.webkit.org/show_bug.cgi?id=66000
Reviewed by David Hyatt.
Test: svg/text/glyphref-renderer-create-crash.html
* svg/SVGGlyphRefElement.h:
LayoutTests: ASSERTION FAILED: curr->isRenderInline()
https://bugs.webkit.org/show_bug.cgi?id=66000
Reviewed by David Hyatt.
* svg/text/glyphref-renderer-create-crash-expected.txt: Added.
* svg/text/glyphref-renderer-create-crash.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (92790 => 92791)
--- trunk/LayoutTests/ChangeLog 2011-08-10 19:57:00 UTC (rev 92790)
+++ trunk/LayoutTests/ChangeLog 2011-08-10 20:12:26 UTC (rev 92791)
@@ -1,3 +1,13 @@
+2011-08-10 Abhishek Arya <[email protected]>
+
+ ASSERTION FAILED: curr->isRenderInline()
+ https://bugs.webkit.org/show_bug.cgi?id=66000
+
+ Reviewed by David Hyatt.
+
+ * svg/text/glyphref-renderer-create-crash-expected.txt: Added.
+ * svg/text/glyphref-renderer-create-crash.html: Added.
+
2011-08-10 Noel Gordon <[email protected]>
[Chromium] plugins/mouse-events-fixedpos.html should pass on win/mac/linux
Added: trunk/LayoutTests/svg/text/glyphref-renderer-create-crash-expected.txt (0 => 92791)
--- trunk/LayoutTests/svg/text/glyphref-renderer-create-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/text/glyphref-renderer-create-crash-expected.txt 2011-08-10 20:12:26 UTC (rev 92791)
@@ -0,0 +1 @@
+Test passes if it does not crash.
Added: trunk/LayoutTests/svg/text/glyphref-renderer-create-crash.html (0 => 92791)
--- trunk/LayoutTests/svg/text/glyphref-renderer-create-crash.html (rev 0)
+++ trunk/LayoutTests/svg/text/glyphref-renderer-create-crash.html 2011-08-10 20:12:26 UTC (rev 92791)
@@ -0,0 +1,14 @@
+<html>
+Test passes if it does not crash.
+<svg>
+<glyphref>
+<foreignObject>
+</foreignObject>
+</glyphref>
+</svg>
+<script>
+ if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+</script>
+</html>
+
Modified: trunk/Source/WebCore/ChangeLog (92790 => 92791)
--- trunk/Source/WebCore/ChangeLog 2011-08-10 19:57:00 UTC (rev 92790)
+++ trunk/Source/WebCore/ChangeLog 2011-08-10 20:12:26 UTC (rev 92791)
@@ -1,3 +1,14 @@
+2011-08-10 Abhishek Arya <[email protected]>
+
+ Don't create html renderer for SVG <glyphRef>
+ https://bugs.webkit.org/show_bug.cgi?id=66000
+
+ Reviewed by David Hyatt.
+
+ Test: svg/text/glyphref-renderer-create-crash.html
+
+ * svg/SVGGlyphRefElement.h:
+
2011-08-10 Scott Graham <[email protected]>
OpenTypeSanitizer in chromium gyp files is linked twice
Modified: trunk/Source/WebCore/svg/SVGGlyphRefElement.h (92790 => 92791)
--- trunk/Source/WebCore/svg/SVGGlyphRefElement.h 2011-08-10 19:57:00 UTC (rev 92790)
+++ trunk/Source/WebCore/svg/SVGGlyphRefElement.h 2011-08-10 20:12:26 UTC (rev 92791)
@@ -49,6 +49,8 @@
private:
SVGGlyphRefElement(const QualifiedName&, Document*);
+ virtual bool rendererIsNeeded(const NodeRenderingContext&) { return false; }
+
BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGGlyphRefElement)
DECLARE_ANIMATED_STRING(Href, href)
END_DECLARE_ANIMATED_PROPERTIES
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
