Title: [92806] trunk
Revision
92806
Author
[email protected]
Date
2011-08-10 17:43:42 -0700 (Wed, 10 Aug 2011)

Log Message

WebViewImpl::selectionRange should return false if there is no selection
https://bugs.webkit.org/show_bug.cgi?id=66012

Patch by Varun Jain <[email protected]> on 2011-08-10
Reviewed by Darin Fisher.

*  Source/WebKit/chromium/src/WebViewImpl.cpp:

Modified Paths

Diff

Modified: trunk/ChangeLog (92805 => 92806)


--- trunk/ChangeLog	2011-08-11 00:27:47 UTC (rev 92805)
+++ trunk/ChangeLog	2011-08-11 00:43:42 UTC (rev 92806)
@@ -1,3 +1,12 @@
+2011-08-10  Varun Jain  <[email protected]>
+
+        WebViewImpl::selectionRange should return false if there is no selection
+        https://bugs.webkit.org/show_bug.cgi?id=66012
+
+        Reviewed by Darin Fisher.
+
+        *  Source/WebKit/chromium/src/WebViewImpl.cpp:
+
 2011-08-10  Kevin Ollivier  <[email protected]>
 
         [wx] Unreviewed build fix. Do not build LocaleToScriptMappingICU.cpp for now

Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (92805 => 92806)


--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-08-11 00:27:47 UTC (rev 92805)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-08-11 00:43:42 UTC (rev 92806)
@@ -1561,7 +1561,7 @@
 bool WebViewImpl::selectionRange(WebPoint& start, WebPoint& end) const
 {
     const Frame* frame = focusedWebCoreFrame();
-    if (!frame)
+    if (!frame || !frame->selection()->isRange())
         return false;
     RefPtr<Range> selectedRange = frame->selection()->toNormalizedRange();
     if (!selectedRange)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to