Title: [92812] trunk/Source/WebCore
- Revision
- 92812
- Author
- [email protected]
- Date
- 2011-08-10 18:29:50 -0700 (Wed, 10 Aug 2011)
Log Message
SVGAElement check for internal non-view anchors is inside ENABLE(SVG_ANIMATION)
https://bugs.webkit.org/show_bug.cgi?id=66026
Reviewed by Rob Buis.
Move only the SMIL-related code inside the ENABLE(SVG_ANIMATION) block.
No new tests, as it depends on the enabled features.
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (92811 => 92812)
--- trunk/Source/WebCore/ChangeLog 2011-08-11 01:17:16 UTC (rev 92811)
+++ trunk/Source/WebCore/ChangeLog 2011-08-11 01:29:50 UTC (rev 92812)
@@ -1,5 +1,19 @@
2011-08-10 Tim Horton <[email protected]>
+ SVGAElement check for internal non-view anchors is inside ENABLE(SVG_ANIMATION)
+ https://bugs.webkit.org/show_bug.cgi?id=66026
+
+ Reviewed by Rob Buis.
+
+ Move only the SMIL-related code inside the ENABLE(SVG_ANIMATION) block.
+
+ No new tests, as it depends on the enabled features.
+
+ * svg/SVGAElement.cpp:
+ (WebCore::SVGAElement::defaultEventHandler):
+
+2011-08-10 Tim Horton <[email protected]>
+
Crash when clicking an SVG <a> link to the local document
https://bugs.webkit.org/show_bug.cgi?id=66019
<rdar://problem/9933311>
Modified: trunk/Source/WebCore/svg/SVGAElement.cpp (92811 => 92812)
--- trunk/Source/WebCore/svg/SVGAElement.cpp 2011-08-11 01:17:16 UTC (rev 92811)
+++ trunk/Source/WebCore/svg/SVGAElement.cpp 2011-08-11 01:29:50 UTC (rev 92812)
@@ -161,19 +161,19 @@
if (isLinkClick(event)) {
String url = ""
-#if ENABLE(SVG_ANIMATION)
if (url[0] == '#') {
Element* targetElement = treeScope()->getElementById(url.substring(1));
+#if ENABLE(SVG_ANIMATION)
if (SVGSMILElement::isSMILElement(targetElement)) {
static_cast<SVGSMILElement*>(targetElement)->beginByLinkActivation();
event->setDefaultHandled();
return;
}
+#endif
// Only allow navigation to internal <view> anchors.
if (targetElement && !targetElement->hasTagName(SVGNames::viewTag))
return;
}
-#endif
// FIXME: Why does the SVG anchor element have this special logic
// for middle click that the HTML anchor element does not have?
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
