Title: [92847] trunk/Tools
- Revision
- 92847
- Author
- [email protected]
- Date
- 2011-08-11 07:40:29 -0700 (Thu, 11 Aug 2011)
Log Message
[Qt] autotests shouldn't require config.h in the style check
https://bugs.webkit.org/show_bug.cgi?id=65986
Remove the include rules from the style-check for Qt tests.
Since for the most part it's just a matter of using the
API provided by QtWebKit, enforcing the WebCore set of rules
only seems to make sense in the case of MIMESniffing.
Patch by Pierre Rossi <[email protected]> on 2011-08-11
Reviewed by Benjamin Poulain.
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (92846 => 92847)
--- trunk/Tools/ChangeLog 2011-08-11 14:34:34 UTC (rev 92846)
+++ trunk/Tools/ChangeLog 2011-08-11 14:40:29 UTC (rev 92847)
@@ -1,3 +1,18 @@
+2011-08-11 Pierre Rossi <[email protected]>
+
+ [Qt] autotests shouldn't require config.h in the style check
+ https://bugs.webkit.org/show_bug.cgi?id=65986
+
+ Remove the include rules from the style-check for Qt tests.
+ Since for the most part it's just a matter of using the
+ API provided by QtWebKit, enforcing the WebCore set of rules
+ only seems to make sense in the case of MIMESniffing.
+
+ Reviewed by Benjamin Poulain.
+
+ * Scripts/webkitpy/style/checker.py:
+ * Scripts/webkitpy/style/checker_unittest.py:
+
2011-08-11 Zsolt Fehér <[email protected]>
[WK2] Implement waitForPolicyDelegate
Modified: trunk/Tools/Scripts/webkitpy/style/checker.py (92846 => 92847)
--- trunk/Tools/Scripts/webkitpy/style/checker.py 2011-08-11 14:34:34 UTC (rev 92846)
+++ trunk/Tools/Scripts/webkitpy/style/checker.py 2011-08-11 14:40:29 UTC (rev 92847)
@@ -124,11 +124,15 @@
([# TestNetscapePlugIn has no config.h and uses funny names like
# NPP_SetWindow.
"Tools/DumpRenderTree/TestNetscapePlugIn/",
+ ([# The MIMESniffing test tests the code directly rather than the API,
+ # let's enable the include check for this one.
+ "Source/WebKit/qt/tests/MIMESniffing"],
+ ["+build/include"]),
# The API test harnesses have no config.h and use funny macros like
# TEST_CLASS_NAME.
"Tools/WebKitAPITest/",
"Tools/TestWebKitAPI/",
- "Source/WebKit/qt/tests/qdeclarativewebview"],
+ "Source/WebKit/qt/tests/"],
["-build/include",
"-readability/naming"]),
([# There is no clean way to avoid "yy_*" names used by flex.
@@ -137,7 +141,6 @@
# and on test xxx_data methos on tests)
"Source/_javascript_Core/qt/",
"Source/WebKit/qt/Api/",
- "Source/WebKit/qt/tests/",
"Source/WebKit/qt/declarative/",
"Source/WebKit/qt/examples/"],
["-readability/naming"]),
Modified: trunk/Tools/Scripts/webkitpy/style/checker_unittest.py (92846 => 92847)
--- trunk/Tools/Scripts/webkitpy/style/checker_unittest.py 2011-08-11 14:34:34 UTC (rev 92846)
+++ trunk/Tools/Scripts/webkitpy/style/checker_unittest.py 2011-08-11 14:40:29 UTC (rev 92847)
@@ -256,6 +256,10 @@
assertNoCheck("Tools/MiniBrowser/qt/UrlLoader.cpp",
"build/include")
+ assertNoCheck("Source/WebKit/qt/tests/util.cpp",
+ "build/include")
+ assertCheck("Source/WebKit/qt/tests/MIMESniffing/tst_MIMESniffing.cpp",
+ "build/include")
assertNoCheck("Source/WebCore/ForwardingHeaders/debugger/Debugger.h",
"build/header_guard")
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
