Title: [92957] trunk
Revision
92957
Author
[email protected]
Date
2011-08-12 06:03:09 -0700 (Fri, 12 Aug 2011)

Log Message

Web Inspector: add space between error info and error message in source frame message bubble.
https://bugs.webkit.org/show_bug.cgi?id=65069

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype._formatMessage):

LayoutTests:

* http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
* inspector/debugger/source-frame-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (92956 => 92957)


--- trunk/LayoutTests/ChangeLog	2011-08-12 12:56:28 UTC (rev 92956)
+++ trunk/LayoutTests/ChangeLog	2011-08-12 13:03:09 UTC (rev 92957)
@@ -1,3 +1,13 @@
+2011-08-12  Pavel Podivilov  <[email protected]>
+
+        Web Inspector: add space between error info and error message in source frame message bubble.
+        https://bugs.webkit.org/show_bug.cgi?id=65069
+
+        Reviewed by Pavel Feldman.
+
+        * http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
+        * inspector/debugger/source-frame-expected.txt:
+
 2011-08-12  Pavel Feldman  <[email protected]>
 
         Web Inspector: console loses focus upon reloading the page from the inspector.

Modified: trunk/LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt (92956 => 92957)


--- trunk/LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt	2011-08-12 12:56:28 UTC (rev 92956)
+++ trunk/LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt	2011-08-12 13:03:09 UTC (rev 92957)
@@ -4,6 +4,6 @@
 
 Received console messages:
 Message[0]:
-Message: resources/console-log-frame-before-navigation.html:5Console message (C) %d with element
+Message: resources/console-log-frame-before-navigation.html:5 Console message (C) %d with element
 TEST COMPLETE.
 

Modified: trunk/LayoutTests/inspector/debugger/source-frame-expected.txt (92956 => 92957)


--- trunk/LayoutTests/inspector/debugger/source-frame-expected.txt	2011-08-12 12:56:28 UTC (rev 92956)
+++ trunk/LayoutTests/inspector/debugger/source-frame-expected.txt	2011-08-12 13:03:09 UTC (rev 92957)
@@ -8,7 +8,7 @@
 Breakpoint added to source frame at line 17
 
 Running: testConsoleMessage
-Message text: source-frame.html:10test error message
+Message text: source-frame.html:10 test error message
 
 Running: testShowResource
 Debugger was disabled.

Modified: trunk/Source/WebCore/ChangeLog (92956 => 92957)


--- trunk/Source/WebCore/ChangeLog	2011-08-12 12:56:28 UTC (rev 92956)
+++ trunk/Source/WebCore/ChangeLog	2011-08-12 13:03:09 UTC (rev 92957)
@@ -1,3 +1,13 @@
+2011-08-12  Pavel Podivilov  <[email protected]>
+
+        Web Inspector: add space between error info and error message in source frame message bubble.
+        https://bugs.webkit.org/show_bug.cgi?id=65069
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/ConsoleView.js:
+        (WebInspector.ConsoleMessage.prototype._formatMessage):
+
 2011-08-12  Pavel Feldman  <[email protected]>
 
         Web Inspector: console loses focus upon reloading the page from the inspector.

Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (92956 => 92957)


--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js	2011-08-12 12:56:28 UTC (rev 92956)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js	2011-08-12 13:03:09 UTC (rev 92957)
@@ -922,7 +922,7 @@
         }
 
         // This is used for inline message bubbles in SourceFrames, or other plain-text representations.
-        this.message = this._formattedMessage.textContent;
+        this.message = (urlElement ? urlElement.textContent + " " : "") + messageText.textContent;
     },
 
     _linkifyLocation: function(url, lineNumber, columnNumber)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to