Title: [93018] trunk/Source/_javascript_Core
- Revision
- 93018
- Author
- [email protected]
- Date
- 2011-08-13 10:54:43 -0700 (Sat, 13 Aug 2011)
Log Message
Add back 0xbbadbeef to CRASH to allow for old habits
https://bugs.webkit.org/show_bug.cgi?id=66190
Reviewed by David Kilzer.
* wtf/Assertions.h:
Add back the assignment to the memory address 0xbbadbeef in the CRASH
macro, as it does not cause issue in the clang static analyzer and many
people use its presence in crash reports to easily identify ASSERTs.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (93017 => 93018)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-13 17:48:53 UTC (rev 93017)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-13 17:54:43 UTC (rev 93018)
@@ -1,5 +1,17 @@
2011-08-13 Sam Weinig <[email protected]>
+ Add back 0xbbadbeef to CRASH to allow for old habits
+ https://bugs.webkit.org/show_bug.cgi?id=66190
+
+ Reviewed by David Kilzer.
+
+ * wtf/Assertions.h:
+ Add back the assignment to the memory address 0xbbadbeef in the CRASH
+ macro, as it does not cause issue in the clang static analyzer and many
+ people use its presence in crash reports to easily identify ASSERTs.
+
+2011-08-13 Sam Weinig <[email protected]>
+
Fix a bunch of minor bugs caught by the clang static analyzer in _javascript_Core
https://bugs.webkit.org/show_bug.cgi?id=66182
Modified: trunk/Source/_javascript_Core/wtf/Assertions.h (93017 => 93018)
--- trunk/Source/_javascript_Core/wtf/Assertions.h 2011-08-13 17:48:53 UTC (rev 93017)
+++ trunk/Source/_javascript_Core/wtf/Assertions.h 2011-08-13 17:54:43 UTC (rev 93018)
@@ -182,6 +182,7 @@
#elif COMPILER(CLANG)
#define CRASH() do { \
WTFReportBacktrace(); \
+ *(int *)(uintptr_t)0xbbadbeef = 0; \
__builtin_trap(); \
} while (false)
#else
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
