Title: [93047] trunk/Source/WebCore
- Revision
- 93047
- Author
- [email protected]
- Date
- 2011-08-15 10:41:34 -0700 (Mon, 15 Aug 2011)
Log Message
MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
https://bugs.webkit.org/show_bug.cgi?id=66171
MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC. I also added better logging to notificationCallback().
Reviewed by Jon Honeycutt.
No new tests, uses existing media tests.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.
(WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (93046 => 93047)
--- trunk/Source/WebCore/ChangeLog 2011-08-15 17:21:30 UTC (rev 93046)
+++ trunk/Source/WebCore/ChangeLog 2011-08-15 17:41:34 UTC (rev 93047)
@@ -1,3 +1,19 @@
+2011-08-12 Jeff Miller <[email protected]>
+
+ MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
+ https://bugs.webkit.org/show_bug.cgi?id=66171
+
+ MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
+ to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC. I also added better logging to notificationCallback().
+
+ Reviewed by Jon Honeycutt.
+
+ No new tests, uses existing media tests.
+
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
+ (WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.
+ (WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.
+
2011-08-15 Adam Roben <[email protected]>
Rename an instance of pageScaleFactorChanged I missed in r93040
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp (93046 => 93047)
--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp 2011-08-15 17:21:30 UTC (rev 93046)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp 2011-08-15 17:41:34 UTC (rev 93047)
@@ -388,7 +388,7 @@
MediaPlayerPrivateAVFoundation::ItemStatus MediaPlayerPrivateAVFoundationCF::playerItemStatus() const
{
if (!avPlayerItem(m_avfWrapper))
- return MediaPlayerPrivateAVFoundation::MediaPlayerAVPlayerItemStatusUnknown;
+ return MediaPlayerPrivateAVFoundation::MediaPlayerAVPlayerItemStatusDoesNotExist;
AVCFPlayerItemStatus status = AVCFPlayerItemGetStatus(avPlayerItem(m_avfWrapper), 0);
if (status == AVCFPlayerItemStatusUnknown)
@@ -1041,7 +1041,11 @@
return;
}
- LOG(Media, "AVFWrapper::notificationCallback(%p)", self);
+#if !LOG_DISABLED
+ char notificationName[256];
+ CFStringGetCString(propertyName, notificationName, sizeof(notificationName), kCFStringEncodingASCII);
+ LOG(Media, "AVFWrapper::notificationCallback(%p) %s", self, notificationName);
+#endif
if (CFEqual(propertyName, AVCFPlayerItemDidPlayToEndTimeNotification))
self->m_owner->scheduleMainThreadNotification(MediaPlayerPrivateAVFoundation::Notification::ItemDidPlayToEndTime);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
