Title: [93057] trunk/Source/WebCore
- Revision
- 93057
- Author
- [email protected]
- Date
- 2011-08-15 12:59:54 -0700 (Mon, 15 Aug 2011)
Log Message
Revise Skia on Chrome Mac to return fallback fonts.
https://bugs.webkit.org/show_bug.cgi?id=62986
Reviewed by Darin Fisher.
Since Skia on Chrome Mac uses CoreText to determine
text metrics, CG font architecture is used to return
fallback fonts.
This improves many existing layout tests, including
justify-ideograph-simple and t0905-c414-flt-04-c
* platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::canReturnFallbackFontsForComplexText):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (93056 => 93057)
--- trunk/Source/WebCore/ChangeLog 2011-08-15 19:59:08 UTC (rev 93056)
+++ trunk/Source/WebCore/ChangeLog 2011-08-15 19:59:54 UTC (rev 93057)
@@ -1,3 +1,20 @@
+2011-08-15 Cary Clark <[email protected]>
+
+ Revise Skia on Chrome Mac to return fallback fonts.
+ https://bugs.webkit.org/show_bug.cgi?id=62986
+
+ Reviewed by Darin Fisher.
+
+ Since Skia on Chrome Mac uses CoreText to determine
+ text metrics, CG font architecture is used to return
+ fallback fonts.
+
+ This improves many existing layout tests, including
+ justify-ideograph-simple and t0905-c414-flt-04-c
+
+ * platform/graphics/skia/FontSkia.cpp:
+ (WebCore::Font::canReturnFallbackFontsForComplexText):
+
2011-08-15 Aaron Boodman <[email protected]>
Pass additional details to client in didCreateIsolatedContext
Modified: trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp (93056 => 93057)
--- trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-08-15 19:59:08 UTC (rev 93056)
+++ trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-08-15 19:59:54 UTC (rev 93057)
@@ -43,12 +43,9 @@
namespace WebCore {
-// FIXME: Determine if the Mac port of Chromium using Skia can return fallback
-// fonts for complex text. (The Windows and Linux ports for Chromium do not.)
-// This issue is tracked in https://bugs.webkit.org/show_bug.cgi?id=62986
bool Font::canReturnFallbackFontsForComplexText()
{
- return false;
+ return true;
}
// FIXME: Determine if the Mac port of Chromium using Skia can expand around
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
