Title: [93146] trunk/Source/WebCore
- Revision
- 93146
- Author
- [email protected]
- Date
- 2011-08-16 12:50:09 -0700 (Tue, 16 Aug 2011)
Log Message
Make placeholder text remain visible until a character is typed on Windows
Fixes <http://webkit.org/b/66319> Placeholder text in text fields disappears when the field
is focused on Windows, which doesn't match Lion or Windows native text fields
Covered by existing tests (which are currently failing on the bots until this patch lands).
Reviewed by Dave Hyatt.
* rendering/RenderThemeSafari.h:
(WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused):
* rendering/RenderThemeWin.h:
(WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):
Added overrides to return true.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (93145 => 93146)
--- trunk/Source/WebCore/ChangeLog 2011-08-16 19:48:41 UTC (rev 93145)
+++ trunk/Source/WebCore/ChangeLog 2011-08-16 19:50:09 UTC (rev 93146)
@@ -1,3 +1,20 @@
+2011-08-16 Adam Roben <[email protected]>
+
+ Make placeholder text remain visible until a character is typed on Windows
+
+ Fixes <http://webkit.org/b/66319> Placeholder text in text fields disappears when the field
+ is focused on Windows, which doesn't match Lion or Windows native text fields
+
+ Covered by existing tests (which are currently failing on the bots until this patch lands).
+
+ Reviewed by Dave Hyatt.
+
+ * rendering/RenderThemeSafari.h:
+ (WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused):
+ * rendering/RenderThemeWin.h:
+ (WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):
+ Added overrides to return true.
+
2011-08-16 David Hyatt <[email protected]>
https://bugs.webkit.org/show_bug.cgi?id=66254
Modified: trunk/Source/WebCore/rendering/RenderThemeSafari.h (93145 => 93146)
--- trunk/Source/WebCore/rendering/RenderThemeSafari.h 2011-08-16 19:48:41 UTC (rev 93145)
+++ trunk/Source/WebCore/rendering/RenderThemeSafari.h 2011-08-16 19:50:09 UTC (rev 93146)
@@ -138,6 +138,8 @@
virtual bool paintMediaSliderThumb(RenderObject*, const PaintInfo&, const IntRect&);
#endif
+ virtual bool shouldShowPlaceholderWhenFocused() const { return true; }
+
private:
RenderThemeSafari();
virtual ~RenderThemeSafari();
Modified: trunk/Source/WebCore/rendering/RenderThemeWin.h (93145 => 93146)
--- trunk/Source/WebCore/rendering/RenderThemeWin.h 2011-08-16 19:48:41 UTC (rev 93145)
+++ trunk/Source/WebCore/rendering/RenderThemeWin.h 2011-08-16 19:50:09 UTC (rev 93146)
@@ -144,6 +144,8 @@
virtual IntPoint volumeSliderOffsetFromMuteButton(RenderBox*, const IntSize&) const;
#endif
+ virtual bool shouldShowPlaceholderWhenFocused() const { return true; }
+
private:
enum ControlSubPart {
None,
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
