Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js (93223 => 93224)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js 2011-08-17 18:13:27 UTC (rev 93223)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js 2011-08-17 18:17:49 UTC (rev 93224)
@@ -77,7 +77,7 @@
failingTests: [
'css1/basic/class_as_selector.html',
],
- expectedDescription: 'css1/basic/class_as_selector.html started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive).\n\nhttp://trac.webkit.org/log/trunk?rev=10&stop_rev=9\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',
+ expectedDescription: 'css1/basic/class_as_selector.html started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive).\n\nhttp://trac.webkit.org/log/trunk?rev=10&stop_rev=9&limit=3\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',
expectedTitle: 'REGRESSION (r8-r10): css1/basic/class_as_selector.html failing on Windows 7 Release (Tests)',
},
{
@@ -87,7 +87,7 @@
'css1/basic/class_as_selector.html',
'fast/css/ex-after-font-variant.html',
],
- expectedDescription: 'css1/basic/class_as_selector.html and fast/css/ex-after-font-variant.html started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive).\n\nhttp://trac.webkit.org/log/trunk?rev=10&stop_rev=9\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',
+ expectedDescription: 'css1/basic/class_as_selector.html and fast/css/ex-after-font-variant.html started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive).\n\nhttp://trac.webkit.org/log/trunk?rev=10&stop_rev=9&limit=3\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',
expectedTitle: 'REGRESSION (r8-r10): css1/basic/class_as_selector.html, fast/css/ex-after-font-variant.html failing on Windows 7 Release (Tests)',
},
{
@@ -103,7 +103,7 @@
'css1/basic/class_as_selector7.html',
'css1/basic/class_as_selector8.html',
],
- expectedDescription: 'The following tests started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive):\n\n css1/basic/class_as_selector1.html\n css1/basic/class_as_selector2.html\n css1/basic/class_as_selector3.html\n css1/basic/class_as_selector4.html\n css1/basic/class_as_selector5.html\n css1/basic/class_as_selector6.html\n css1/basic/class_as_selector7.html\n css1/basic/class_as_selector8.html\n\nhttp://trac.webkit.org/log/trunk?rev=10&stop_rev=9\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',
+ expectedDescription: 'The following tests started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive):\n\n css1/basic/class_as_selector1.html\n css1/basic/class_as_selector2.html\n css1/basic/class_as_selector3.html\n css1/basic/class_as_selector4.html\n css1/basic/class_as_selector5.html\n css1/basic/class_as_selector6.html\n css1/basic/class_as_selector7.html\n css1/basic/class_as_selector8.html\n\nhttp://trac.webkit.org/log/trunk?rev=10&stop_rev=9&limit=3\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',
expectedTitle: 'REGRESSION (r8-r10): 8 css1/basic tests failing on Windows 7 Release (Tests)',
},
{
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js (93223 => 93224)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js 2011-08-17 18:13:27 UTC (rev 93223)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js 2011-08-17 18:17:49 UTC (rev 93224)
@@ -137,6 +137,9 @@
var queryParameters = {
rev: endRevision,
stop_rev: startRevision,
+ // Trac requires limit to be 1 more than the number of revisions we actually want to show.
+ // See <http://trac.edgewall.org/ticket/10317>.
+ limit: endRevision - startRevision + 2,
};
if (showFullCommitLogs)
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js (93223 => 93224)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js 2011-08-17 18:13:27 UTC (rev 93223)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js 2011-08-17 18:17:49 UTC (rev 93224)
@@ -285,10 +285,10 @@
});
test("logURL", 4, function() {
- equals(trac.logURL('trunk', 1234, 1236, false, false), "http://trac.webkit.org/log/trunk?rev=1236&stop_rev=1234");
- equals(trac.logURL('trunk', 1234, 1234, true, false), "http://trac.webkit.org/log/trunk?rev=1234&stop_rev=1234&verbose=on");
- equals(trac.logURL('trunk', 1236, 1236, false, true), "http://trac.webkit.org/log/trunk?rev=1236&stop_rev=1236&format=rss");
- equals(trac.logURL('trunk', 1234, 1236, true, true), "http://trac.webkit.org/log/trunk?rev=1236&stop_rev=1234&verbose=on&format=rss");
+ equals(trac.logURL('trunk', 1234, 1236, false, false), "http://trac.webkit.org/log/trunk?rev=1236&stop_rev=1234&limit=4");
+ equals(trac.logURL('trunk', 1234, 1234, true, false), "http://trac.webkit.org/log/trunk?rev=1234&stop_rev=1234&limit=2&verbose=on");
+ equals(trac.logURL('trunk', 1236, 1236, false, true), "http://trac.webkit.org/log/trunk?rev=1236&stop_rev=1236&limit=2&format=rss");
+ equals(trac.logURL('trunk', 1234, 1236, true, true), "http://trac.webkit.org/log/trunk?rev=1236&stop_rev=1234&limit=4&verbose=on&format=rss");
});
test("recentCommitData", 3, function() {
@@ -318,7 +318,7 @@
var simulator = new NetworkSimulator();
simulator.get = function(url, callback)
{
- equals(url, 'http://trac.webkit.org/log/trunk?rev=12365&stop_rev=12345&verbose=on&format=rss');
+ equals(url, 'http://trac.webkit.org/log/trunk?rev=12365&stop_rev=12345&limit=22&verbose=on&format=rss');
simulator.scheduleCallback(function() {
var parser = new DOMParser();
var responseDOM = parser.parseFromString(kExampleCommitDataXML, "application/xml");
Modified: trunk/Tools/ChangeLog (93223 => 93224)
--- trunk/Tools/ChangeLog 2011-08-17 18:13:27 UTC (rev 93223)
+++ trunk/Tools/ChangeLog 2011-08-17 18:17:49 UTC (rev 93224)
@@ -1,5 +1,25 @@
2011-08-17 Adam Roben <[email protected]>
+ Tell Trac logs always to display all specified revisions in a single page
+
+ Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
+ revisions than that.
+
+ Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
+ relevant revisions
+
+ Reviewed by Daniel Bates.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
+ (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
+ a single page.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
+ Updated tests for the above.
+
+2011-08-17 Adam Roben <[email protected]>
+
Fix TestFailures's link to file a bug about TestFailures itself
Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
