Title: [93311] trunk/Source/WebKit/gtk
- Revision
- 93311
- Author
- [email protected]
- Date
- 2011-08-18 08:51:27 -0700 (Thu, 18 Aug 2011)
Log Message
[GTK] Change webview API tests to use "load-status" signal instead of "load-progress"
https://bugs.webkit.org/show_bug.cgi?id=66243
Reviewed by Martin Robinson.
The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
call it only when the "load-status" change.
This change is important in the context of bug 28851, which aims to change the
order in which "progress finished" and "load finished" callbacks are called. In
this new scenario, at the progress callback the load will never be finished.
* tests/testwebview.c:
(test_webkit_web_view_grab_focus):
Modified Paths
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (93310 => 93311)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-08-18 15:39:59 UTC (rev 93310)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-08-18 15:51:27 UTC (rev 93311)
@@ -1,3 +1,20 @@
+2011-08-18 Caio Marcelo de Oliveira Filho <[email protected]>
+
+ [GTK] Change webview API tests to use "load-status" signal instead of "load-progress"
+ https://bugs.webkit.org/show_bug.cgi?id=66243
+
+ Reviewed by Martin Robinson.
+
+ The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
+ call it only when the "load-status" change.
+
+ This change is important in the context of bug 28851, which aims to change the
+ order in which "progress finished" and "load finished" callbacks are called. In
+ this new scenario, at the progress callback the load will never be finished.
+
+ * tests/testwebview.c:
+ (test_webkit_web_view_grab_focus):
+
2011-08-17 Adam Roben <[email protected]>
Make WebCore keep track of the current device scale factor
Modified: trunk/Source/WebKit/gtk/tests/testwebview.c (93310 => 93311)
--- trunk/Source/WebKit/gtk/tests/testwebview.c 2011-08-18 15:39:59 UTC (rev 93310)
+++ trunk/Source/WebKit/gtk/tests/testwebview.c 2011-08-18 15:51:27 UTC (rev 93311)
@@ -167,7 +167,7 @@
loop = g_main_loop_new(NULL, TRUE);
- g_signal_connect(view, "notify::progress", G_CALLBACK (idle_quit_loop_cb), NULL);
+ g_signal_connect(view, "notify::load-status", G_CALLBACK(idle_quit_loop_cb), NULL);
/* Wait for window to show up */
gtk_widget_show_all(window);
@@ -235,7 +235,7 @@
loop = g_main_loop_new(NULL, TRUE);
g_object_connect(G_OBJECT(view),
- "signal::notify::progress", idle_quit_loop_cb, NULL,
+ "signal::notify::load-status", idle_quit_loop_cb, NULL,
NULL);
/* Wait for window to show up */
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
