Title: [93410] trunk/Source/WebKit/efl
- Revision
- 93410
- Author
- [email protected]
- Date
- 2011-08-19 08:25:03 -0700 (Fri, 19 Aug 2011)
Log Message
[EFL] Add "return" statement corresponding to abnormal condition on _ewk_frame_smart_add.
https://bugs.webkit.org/show_bug.cgi?id=65408
Bail out when we fail to allocate an Ewk_Frame_Smart_Data object rather than continuing on as if the allocation had succeeded.
Patch by KwangHyuk Kim <[email protected]> on 2011-08-19
Reviewed by Adam Roben.
* ewk/ewk_frame.cpp:
(_ewk_frame_smart_add):
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (93409 => 93410)
--- trunk/Source/WebKit/efl/ChangeLog 2011-08-19 15:19:33 UTC (rev 93409)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-08-19 15:25:03 UTC (rev 93410)
@@ -1,5 +1,17 @@
2011-08-19 KwangHyuk Kim <[email protected]>
+ [EFL] Add "return" statement corresponding to abnormal condition on _ewk_frame_smart_add.
+ https://bugs.webkit.org/show_bug.cgi?id=65408
+
+ Bail out when we fail to allocate an Ewk_Frame_Smart_Data object rather than continuing on as if the allocation had succeeded.
+
+ Reviewed by Adam Roben.
+
+ * ewk/ewk_frame.cpp:
+ (_ewk_frame_smart_add):
+
+2011-08-19 KwangHyuk Kim <[email protected]>
+
[EFL] Change condition checking logic related with both change of position and offset for backing store.
https://bugs.webkit.org/show_bug.cgi?id=66028
Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (93409 => 93410)
--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-08-19 15:19:33 UTC (rev 93409)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-08-19 15:25:03 UTC (rev 93410)
@@ -182,10 +182,11 @@
if (!sd) {
sd = (Ewk_Frame_Smart_Data*)calloc(1, sizeof(Ewk_Frame_Smart_Data));
- if (!sd)
+ if (!sd) {
CRITICAL("could not allocate Ewk_Frame_Smart_Data");
- else
- evas_object_smart_data_set(o, sd);
+ return;
+ }
+ evas_object_smart_data_set(o, sd);
}
sd->self = o;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
