Title: [93444] trunk/Tools
Revision
93444
Author
[email protected]
Date
2011-08-19 15:26:37 -0700 (Fri, 19 Aug 2011)

Log Message

[chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
https://bugs.webkit.org/show_bug.cgi?id=66603

Reviewed by Dirk Pranke.

The various ChromiumGpu ports should use the same child worker
selection logic as other ports so they can run with full
parallelization on multicore systems.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (93443 => 93444)


--- trunk/Tools/ChangeLog	2011-08-19 22:20:19 UTC (rev 93443)
+++ trunk/Tools/ChangeLog	2011-08-19 22:26:37 UTC (rev 93444)
@@ -1,3 +1,17 @@
+2011-08-19  James Robinson  <[email protected]>
+
+        [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
+        https://bugs.webkit.org/show_bug.cgi?id=66603
+
+        Reviewed by Dirk Pranke.
+
+        The various ChromiumGpu ports should use the same child worker
+        selection logic as other ports so they can run with full
+        parallelization on multicore systems.
+
+        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
+        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
+
 2011-08-19  Alok Priyadarshi  <[email protected]>
 
         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py (93443 => 93444)


--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py	2011-08-19 22:20:19 UTC (rev 93443)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py	2011-08-19 22:26:37 UTC (rev 93444)
@@ -95,9 +95,6 @@
         return (map(self._webkit_baseline_path, ['chromium-gpu-linux', 'chromium-gpu-win', 'chromium-gpu']) +
                 chromium_linux.ChromiumLinuxPort.baseline_search_path(self))
 
-    def default_child_processes(self):
-        return 1
-
     def tests(self, paths):
         return _tests(self, paths)
 
@@ -111,9 +108,6 @@
         return (map(self._webkit_baseline_path, ['chromium-gpu-mac', 'chromium-gpu']) +
                 chromium_mac.ChromiumMacPort.baseline_search_path(self))
 
-    def default_child_processes(self):
-        return 1
-
     def tests(self, paths):
         return _tests(self, paths)
 
@@ -127,8 +121,5 @@
         return (map(self._webkit_baseline_path, ['chromium-gpu-win', 'chromium-gpu']) +
                 chromium_win.ChromiumWinPort.baseline_search_path(self))
 
-    def default_child_processes(self):
-        return 1
-
     def tests(self, paths):
         return _tests(self, paths)

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py (93443 => 93444)


--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py	2011-08-19 22:20:19 UTC (rev 93443)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py	2011-08-19 22:26:37 UTC (rev 93444)
@@ -67,7 +67,6 @@
             port = chromium_gpu.get(port_name=port_name, options=mock_options)
         self.assertTrue(port._options.accelerated_compositing)
         self.assertTrue(port._options.accelerated_2d_canvas)
-        self.assertEqual(port.default_child_processes(), 1)
         self.assertEqual(port._options.builder_name, 'foo - GPU')
 
         self.assertTrue(port.name().startswith(port_name))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to