Title: [93463] trunk/Tools
- Revision
- 93463
- Author
- [email protected]
- Date
- 2011-08-19 18:31:11 -0700 (Fri, 19 Aug 2011)
Log Message
[chromium] Default to experimental-fully-parallel mode for chromium gpu port
https://bugs.webkit.org/show_bug.cgi?id=66606
Patch by James Robinson <[email protected]> on 2011-08-19
Reviewed by Dirk Pranke.
The chromium GPU configuration does not (currently) contain any tests
incompatible with --experimental-fully-parallel, and this flag is a
significan speedup because of the directory canvas/philip/tests which
contains 802 tests in the same directory. Setting this option by
default on this configuration is a 2x speed in release, 44s to 22s,
and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (93462 => 93463)
--- trunk/Tools/ChangeLog 2011-08-20 01:17:18 UTC (rev 93462)
+++ trunk/Tools/ChangeLog 2011-08-20 01:31:11 UTC (rev 93463)
@@ -1,3 +1,21 @@
+2011-08-19 James Robinson <[email protected]>
+
+ [chromium] Default to experimental-fully-parallel mode for chromium gpu port
+ https://bugs.webkit.org/show_bug.cgi?id=66606
+
+ Reviewed by Dirk Pranke.
+
+ The chromium GPU configuration does not (currently) contain any tests
+ incompatible with --experimental-fully-parallel, and this flag is a
+ significan speedup because of the directory canvas/philip/tests which
+ contains 802 tests in the same directory. Setting this option by
+ default on this configuration is a 2x speed in release, 44s to 22s,
+ and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
+
+ * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
+ * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+
2011-08-19 Sheriff Bot <[email protected]>
Unreviewed, rolling out r93426.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py (93462 => 93463)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-08-20 01:17:18 UTC (rev 93462)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-08-20 01:31:11 UTC (rev 93463)
@@ -65,6 +65,8 @@
port._options.accelerated_compositing = True
if port.get_option('accelerated_2d_canvas') is None:
port._options.accelerated_2d_canvas = True
+ if port.get_option('experimental_fully_parallel') is None:
+ port._options.experimental_fully_parallel = True
# FIXME: Remove this after http://codereview.chromium.org/5133001/ is enabled
# on the bots.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py (93462 => 93463)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py 2011-08-20 01:17:18 UTC (rev 93462)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py 2011-08-20 01:31:11 UTC (rev 93463)
@@ -67,6 +67,7 @@
port = chromium_gpu.get(port_name=port_name, options=mock_options)
self.assertTrue(port._options.accelerated_compositing)
self.assertTrue(port._options.accelerated_2d_canvas)
+ self.assertTrue(port._options.experimental_fully_parallel)
self.assertEqual(port._options.builder_name, 'foo - GPU')
self.assertTrue(port.name().startswith(port_name))
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (93462 => 93463)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2011-08-20 01:17:18 UTC (rev 93462)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2011-08-20 01:31:11 UTC (rev 93463)
@@ -377,8 +377,12 @@
default=None, help=("controls worker model. Valid values are "
"'inline' and 'processes'.")),
optparse.make_option("-f", "--experimental-fully-parallel",
- action="" default=False,
+ action=""
help="run all tests in parallel"),
+ optparse.make_option("--no-experimental-fully-parallel",
+ action=""
+ dest="experimental_fully_parallel",
+ help="do not run all tests in parallel"),
optparse.make_option("--exit-after-n-failures", type="int", default=500,
help="Exit after the first N failures instead of running all "
"tests"),
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
