Title: [93467] trunk/Source/_javascript_Core
- Revision
- 93467
- Author
- [email protected]
- Date
- 2011-08-19 19:59:07 -0700 (Fri, 19 Aug 2011)
Log Message
Only #include <signal.h> and require SA_RESTART when building with JSC_MULTIPLE_THREADS
https://bugs.webkit.org/show_bug.cgi?id=66617
Both <signal.h> and SA_RESTART usage are guarded behind ENABLE(JSC_MULTIPLE_THREADS).
But we cause a compile error if the platform doesn't support SA_RESTART regardless of
whether JSC_MULTIPLE_THREADS is enabled for the port. Instead, we shouldn't require
SA_RESTART support unless we are building with JSC_MULTIPLE_THREADS enabled.
Reviewed by Antonio Gomes.
* heap/MachineStackMarker.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (93466 => 93467)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-20 02:17:49 UTC (rev 93466)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-20 02:59:07 UTC (rev 93467)
@@ -1,3 +1,17 @@
+2011-08-19 Daniel Bates <[email protected]>
+
+ Only #include <signal.h> and require SA_RESTART when building with JSC_MULTIPLE_THREADS
+ https://bugs.webkit.org/show_bug.cgi?id=66617
+
+ Both <signal.h> and SA_RESTART usage are guarded behind ENABLE(JSC_MULTIPLE_THREADS).
+ But we cause a compile error if the platform doesn't support SA_RESTART regardless of
+ whether JSC_MULTIPLE_THREADS is enabled for the port. Instead, we shouldn't require
+ SA_RESTART support unless we are building with JSC_MULTIPLE_THREADS enabled.
+
+ Reviewed by Antonio Gomes.
+
+ * heap/MachineStackMarker.cpp:
+
2011-08-19 Filip Pizlo <[email protected]>
The JSC JIT currently has no facility to profile and report
Modified: trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp (93466 => 93467)
--- trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp 2011-08-20 02:17:49 UTC (rev 93466)
+++ trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp 2011-08-20 02:59:07 UTC (rev 93467)
@@ -76,7 +76,7 @@
#include <errno.h>
#endif
-#if USE(PTHREADS) && !OS(WINDOWS) && !OS(DARWIN)
+#if ENABLE(JSC_MULTIPLE_THREADS) && USE(PTHREADS) && !OS(WINDOWS) && !OS(DARWIN)
#include <signal.h>
#ifndef SA_RESTART
#error MachineThreads requires SA_RESTART
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
