Title: [93579] trunk/Source/WebCore
- Revision
- 93579
- Author
- [email protected]
- Date
- 2011-08-22 21:09:07 -0700 (Mon, 22 Aug 2011)
Log Message
[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=66673
Reviewed by James Robinson.
This was fixed for other ports in http://trac.webkit.org/changeset/88260.
However, it was missed in FontCacheLinux likely due to similar param in the nested call to getCachedFontPlatformData().
No new tests because no directly observable change in behavior.
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (93578 => 93579)
--- trunk/Source/WebCore/ChangeLog 2011-08-23 03:55:42 UTC (rev 93578)
+++ trunk/Source/WebCore/ChangeLog 2011-08-23 04:09:07 UTC (rev 93579)
@@ -1,3 +1,18 @@
+2011-08-22 Tony Gentilcore <[email protected]>
+
+ [chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
+ https://bugs.webkit.org/show_bug.cgi?id=66673
+
+ Reviewed by James Robinson.
+
+ This was fixed for other ports in http://trac.webkit.org/changeset/88260.
+ However, it was missed in FontCacheLinux likely due to similar param in the nested call to getCachedFontPlatformData().
+
+ No new tests because no directly observable change in behavior.
+
+ * platform/graphics/chromium/FontCacheLinux.cpp:
+ (WebCore::FontCache::getFontDataForCharacters):
+
2011-08-22 Sheriff Bot <[email protected]>
Unreviewed, rolling out r93565.
Modified: trunk/Source/WebCore/platform/graphics/chromium/FontCacheLinux.cpp (93578 => 93579)
--- trunk/Source/WebCore/platform/graphics/chromium/FontCacheLinux.cpp 2011-08-23 03:55:42 UTC (rev 93578)
+++ trunk/Source/WebCore/platform/graphics/chromium/FontCacheLinux.cpp 2011-08-23 04:09:07 UTC (rev 93579)
@@ -64,7 +64,7 @@
return 0;
AtomicString atomicFamily(family);
- return getCachedFontData(getCachedFontPlatformData(font.fontDescription(), atomicFamily, DoNotRetain));
+ return getCachedFontData(getCachedFontPlatformData(font.fontDescription(), atomicFamily, DoNotRetain), DoNotRetain);
}
SimpleFontData* FontCache::getSimilarFontPlatformData(const Font& font)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
