Title: [93641] trunk/Tools
- Revision
- 93641
- Author
- [email protected]
- Date
- 2011-08-23 15:10:26 -0700 (Tue, 23 Aug 2011)
Log Message
garden-o-matic relative time is wrong and updates too frequently.
https://bugs.webkit.org/show_bug.cgi?id=66802
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js (93640 => 93641)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js 2011-08-23 22:09:23 UTC (rev 93640)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js 2011-08-23 22:10:26 UTC (rev 93641)
@@ -307,7 +307,7 @@
{
return function(delta) {
var deltaInUnits = delta / divisorInMilliseconds;
- return (deltaInUnits).toFixed(0) + ' ' + unit + (deltaInUnits >= 2 ? 's' : '') + ' ago';
+ return (deltaInUnits).toFixed(0) + ' ' + unit + (deltaInUnits >= 1.5 ? 's' : '') + ' ago';
}
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js (93640 => 93641)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js 2011-08-23 22:09:23 UTC (rev 93640)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js 2011-08-23 22:10:26 UTC (rev 93641)
@@ -380,7 +380,7 @@
document.body.removeChild(document.body.lastChild);
});
-test("relativizeTime", 11, function() {
+test("relativizeTime", 14, function() {
var time = new Date();
equals(base.relativizeTime(time), "Just now");
time.setMinutes(time.getMinutes() - 1);
@@ -393,9 +393,15 @@
equals(base.relativizeTime(time), "59 minutes ago");
time.setMinutes(time.getMinutes() - 1);
equals(base.relativizeTime(time), "1 hour ago");
+ time.setMinutes(time.getMinutes() - 29);
+ equals(base.relativizeTime(time), "1 hour ago");
+ time.setMinutes(time.getMinutes() - 2);
+ equals(base.relativizeTime(time), "2 hours ago");
+ time.setMinutes(time.getMinutes() - 29);
+ equals(base.relativizeTime(time), "2 hours ago");
time.setHours(time.getHours() - 1);
- equals(base.relativizeTime(time), "2 hours ago");
- time.setHours(time.getHours() - 21);
+ equals(base.relativizeTime(time), "3 hours ago");
+ time.setHours(time.getHours() - 20);
equals(base.relativizeTime(time), "23 hours ago");
time.setHours(time.getHours() - 1);
equals(base.relativizeTime(time), "1 day ago");
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js (93640 => 93641)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2011-08-23 22:09:23 UTC (rev 93640)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2011-08-23 22:10:26 UTC (rev 93641)
@@ -67,7 +67,7 @@
var kTenMinutesInMilliseconds = 10 * 60 * 1000;
config.kUpdateFrequency = kTenMinutesInMilliseconds;
-config.kRelativeTimeUpdateFrequency = 1000;
+config.kRelativeTimeUpdateFrequency = 1000 * 60;
Modified: trunk/Tools/ChangeLog (93640 => 93641)
--- trunk/Tools/ChangeLog 2011-08-23 22:09:23 UTC (rev 93640)
+++ trunk/Tools/ChangeLog 2011-08-23 22:10:26 UTC (rev 93641)
@@ -1,3 +1,14 @@
+2011-08-23 Dimitri Glazkov <[email protected]>
+
+ garden-o-matic relative time is wrong and updates too frequently.
+ https://bugs.webkit.org/show_bug.cgi?id=66802
+
+ Reviewed by Adam Barth.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
+
2011-08-23 Patrick Gansterer <[email protected]>
Add missing quotes around filenames in mergeChangeLogs
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
