Title: [93699] trunk/Source/WebCore
- Revision
- 93699
- Author
- [email protected]
- Date
- 2011-08-24 02:52:27 -0700 (Wed, 24 Aug 2011)
Log Message
SelectElementData: Reorder members to reduce memory usage.
https://bugs.webkit.org/show_bug.cgi?id=66787
Reviewed by Darin Adler.
Reduced the size of SelectElementData by 24 bytes on 64-bit by rearranging
its data members.
Also added missing initialization of m_userDrivenChange.
* dom/SelectElement.cpp:
(WebCore::SelectElementData::SelectElementData):
* dom/SelectElement.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (93698 => 93699)
--- trunk/Source/WebCore/ChangeLog 2011-08-24 09:50:40 UTC (rev 93698)
+++ trunk/Source/WebCore/ChangeLog 2011-08-24 09:52:27 UTC (rev 93699)
@@ -1,3 +1,19 @@
+2011-08-24 Andreas Kling <[email protected]>
+
+ SelectElementData: Reorder members to reduce memory usage.
+ https://bugs.webkit.org/show_bug.cgi?id=66787
+
+ Reviewed by Darin Adler.
+
+ Reduced the size of SelectElementData by 24 bytes on 64-bit by rearranging
+ its data members.
+
+ Also added missing initialization of m_userDrivenChange.
+
+ * dom/SelectElement.cpp:
+ (WebCore::SelectElementData::SelectElementData):
+ * dom/SelectElement.h:
+
2011-08-24 Pavel Feldman <[email protected]>
Web Inspector: clearPseudoState should retain Element while clearing
Modified: trunk/Source/WebCore/dom/SelectElement.cpp (93698 => 93699)
--- trunk/Source/WebCore/dom/SelectElement.cpp 2011-08-24 09:50:40 UTC (rev 93698)
+++ trunk/Source/WebCore/dom/SelectElement.cpp 2011-08-24 09:52:27 UTC (rev 93699)
@@ -1050,15 +1050,16 @@
// SelectElementData
SelectElementData::SelectElementData()
- : m_multiple(false)
+ : m_lastCharTime(0)
+ , m_repeatingChar(0)
, m_size(0)
, m_lastOnChangeIndex(-1)
- , m_activeSelectionState(false)
, m_activeSelectionAnchorIndex(-1)
, m_activeSelectionEndIndex(-1)
+ , m_userDrivenChange(false)
+ , m_multiple(false)
+ , m_activeSelectionState(false)
, m_recalcListItems(false)
- , m_repeatingChar(0)
- , m_lastCharTime(0)
{
}
Modified: trunk/Source/WebCore/dom/SelectElement.h (93698 => 93699)
--- trunk/Source/WebCore/dom/SelectElement.h 2011-08-24 09:50:40 UTC (rev 93698)
+++ trunk/Source/WebCore/dom/SelectElement.h 2011-08-24 09:52:27 UTC (rev 93699)
@@ -171,25 +171,24 @@
private:
void checkListItems(const Element*) const;
- bool m_multiple;
- int m_size;
-
- int m_lastOnChangeIndex;
+ Vector<Element*> m_listItems;
Vector<bool> m_lastOnChangeSelection;
- bool m_userDrivenChange;
-
- bool m_activeSelectionState;
- int m_activeSelectionAnchorIndex;
- int m_activeSelectionEndIndex;
Vector<bool> m_cachedStateForActiveSelection;
- bool m_recalcListItems;
- Vector<Element*> m_listItems;
-
// Instance variables for type-ahead find
- UChar m_repeatingChar;
DOMTimeStamp m_lastCharTime;
String m_typedString;
+ UChar m_repeatingChar;
+
+ int m_size;
+ int m_lastOnChangeIndex;
+ int m_activeSelectionAnchorIndex;
+ int m_activeSelectionEndIndex;
+
+ bool m_userDrivenChange;
+ bool m_multiple;
+ bool m_activeSelectionState;
+ bool m_recalcListItems;
};
SelectElement* toSelectElement(Element*);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
