Title: [93829] trunk/Tools
- Revision
- 93829
- Author
- [email protected]
- Date
- 2011-08-25 15:58:28 -0700 (Thu, 25 Aug 2011)
Log Message
webkit-patch rebaseline-expectations don't work when run outside the root
https://bugs.webkit.org/show_bug.cgi?id=66966
Reviewed by Eric Seidel.
Turns out tool.path() used to be relative, which caused problems when
running webkit-patch outside the root directory. This patch makes it
absolute. I checked all callers, and they all appear to want this
behavior.
It was unclear to me how to test this change because we only really
have a testing strategy for webkitpy, not for the main script.
* Scripts/webkit-patch:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (93828 => 93829)
--- trunk/Tools/ChangeLog 2011-08-25 22:56:59 UTC (rev 93828)
+++ trunk/Tools/ChangeLog 2011-08-25 22:58:28 UTC (rev 93829)
@@ -1,3 +1,20 @@
+2011-08-25 Adam Barth <[email protected]>
+
+ webkit-patch rebaseline-expectations don't work when run outside the root
+ https://bugs.webkit.org/show_bug.cgi?id=66966
+
+ Reviewed by Eric Seidel.
+
+ Turns out tool.path() used to be relative, which caused problems when
+ running webkit-patch outside the root directory. This patch makes it
+ absolute. I checked all callers, and they all appear to want this
+ behavior.
+
+ It was unclear to me how to test this change because we only really
+ have a testing strategy for webkitpy, not for the main script.
+
+ * Scripts/webkit-patch:
+
2011-08-25 Dimitri Glazkov <[email protected]>
garden-o-matic summary needs a mock view that could be used for working on styling
Modified: trunk/Tools/Scripts/webkit-patch (93828 => 93829)
--- trunk/Tools/Scripts/webkit-patch 2011-08-25 22:56:59 UTC (rev 93828)
+++ trunk/Tools/Scripts/webkit-patch 2011-08-25 22:58:28 UTC (rev 93829)
@@ -58,7 +58,7 @@
# version warning.
from webkitpy.tool.main import WebKitPatch
- WebKitPatch(__file__).main()
+ WebKitPatch(os.path.abspath(__file__)).main()
if __name__ == "__main__":
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
