Title: [93831] trunk/Tools
Revision
93831
Author
[email protected]
Date
2011-08-25 16:06:47 -0700 (Thu, 25 Aug 2011)

Log Message

[Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
https://bugs.webkit.org/show_bug.cgi?id=66951

Patch by Viatcheslav Ostapenko <[email protected]> on 2011-08-25
Reviewed by Andreas Kling.

Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
width and height one by one and setWidth cause geometryChange event in QTouchWebView.

* MiniBrowser/qt/BrowserView.cpp:
(BrowserView::resizeEvent):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (93830 => 93831)


--- trunk/Tools/ChangeLog	2011-08-25 23:02:55 UTC (rev 93830)
+++ trunk/Tools/ChangeLog	2011-08-25 23:06:47 UTC (rev 93831)
@@ -1,3 +1,16 @@
+2011-08-25  Viatcheslav Ostapenko  <[email protected]>
+
+        [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
+        https://bugs.webkit.org/show_bug.cgi?id=66951
+
+        Reviewed by Andreas Kling.
+
+        Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
+        width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
+
+        * MiniBrowser/qt/BrowserView.cpp:
+        (BrowserView::resizeEvent):
+
 2011-08-25  Dimitri Glazkov  <[email protected]>
 
         garden-o-matic summary view should provide information on builders still in flight.

Modified: trunk/Tools/MiniBrowser/qt/BrowserView.cpp (93830 => 93831)


--- trunk/Tools/MiniBrowser/qt/BrowserView.cpp	2011-08-25 23:02:55 UTC (rev 93830)
+++ trunk/Tools/MiniBrowser/qt/BrowserView.cpp	2011-08-25 23:06:47 UTC (rev 93831)
@@ -57,8 +57,7 @@
     QSGCanvas::resizeEvent(event);
     m_item->setX(0);
     m_item->setY(0);
-    m_item->setWidth(event->size().width());
-    m_item->setHeight(event->size().height());
+    m_item->setSize(event->size());
 }
 
 void BrowserView::load(const QString& urlString)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to