Title: [93841] trunk/Source/_javascript_Core
Revision
93841
Author
[email protected]
Date
2011-08-25 17:41:03 -0700 (Thu, 25 Aug 2011)

Log Message

Fixing broken build due to unused variables in release mode
https://bugs.webkit.org/show_bug.cgi?id=67004

Unreviewed, release build fix.

Fixing broken build due to unused variables in ASSERTs in release build.

Patch by Mark Hahnenberg <[email protected]> on 2011-08-25

* runtime/JSObject.h:
(JSC::JSObject::finishCreation):
* runtime/JSString.h:
(JSC::RopeBuilder::finishCreation):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::finishCreation):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (93840 => 93841)


--- trunk/Source/_javascript_Core/ChangeLog	2011-08-26 00:36:13 UTC (rev 93840)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-08-26 00:41:03 UTC (rev 93841)
@@ -1,5 +1,21 @@
 2011-08-25  Mark Hahnenberg  <[email protected]>
 
+        Fixing broken build due to unused variables in release mode
+        https://bugs.webkit.org/show_bug.cgi?id=67004
+
+        Unreviewed, release build fix.
+
+        Fixing broken build due to unused variables in ASSERTs in release build.
+
+        * runtime/JSObject.h:
+        (JSC::JSObject::finishCreation):
+        * runtime/JSString.h:
+        (JSC::RopeBuilder::finishCreation):
+        * runtime/ScopeChain.h:
+        (JSC::ScopeChainNode::finishCreation):
+
+2011-08-25  Mark Hahnenberg  <[email protected]>
+
         Unzip initialization lists and constructors in JSCell hierarchy (1/7)
         https://bugs.webkit.org/show_bug.cgi?id=66827
 

Modified: trunk/Source/_javascript_Core/runtime/JSObject.h (93840 => 93841)


--- trunk/Source/_javascript_Core/runtime/JSObject.h	2011-08-26 00:36:13 UTC (rev 93840)
+++ trunk/Source/_javascript_Core/runtime/JSObject.h	2011-08-26 00:41:03 UTC (rev 93841)
@@ -266,7 +266,7 @@
             ASSERT(m_structure->propertyStorageCapacity() < baseExternalStorageCapacity);
             ASSERT(m_structure->isEmpty());
             ASSERT(prototype().isNull() || Heap::heap(this) == Heap::heap(prototype()));
-            ASSERT(static_cast<void*>(inlineStorage) == static_cast<void*>(this + 1));
+            ASSERT_UNUSED(inlineStorage, static_cast<void*>(inlineStorage) == static_cast<void*>(this + 1));
             ASSERT(m_structure->typeInfo().type() == ObjectType);
         }
 

Modified: trunk/Source/_javascript_Core/runtime/JSString.h (93840 => 93841)


--- trunk/Source/_javascript_Core/runtime/JSString.h	2011-08-26 00:36:13 UTC (rev 93840)
+++ trunk/Source/_javascript_Core/runtime/JSString.h	2011-08-26 00:41:03 UTC (rev 93841)
@@ -282,7 +282,7 @@
         void finishCreation(JSGlobalData& globalData, unsigned fiberCount, JSString* s1, JSString* s2)
         {
             Base::finishCreation(globalData);
-            ASSERT(fiberCount <= s_maxInternalRopeLength);
+            ASSERT_UNUSED(fiberCount, fiberCount <= s_maxInternalRopeLength);
             unsigned index = 0;
             appendStringInCreate(index, s1);
             appendStringInCreate(index, s2);
@@ -292,7 +292,7 @@
         void finishCreation(JSGlobalData& globalData, unsigned fiberCount, JSString* s1, const UString& u2)
         {
             Base::finishCreation(globalData);
-            ASSERT(fiberCount <= s_maxInternalRopeLength);
+            ASSERT_UNUSED(fiberCount, fiberCount <= s_maxInternalRopeLength);
             unsigned index = 0;
             appendStringInCreate(index, s1);
             appendStringInCreate(index, u2);
@@ -302,7 +302,7 @@
         void finishCreation(JSGlobalData& globalData, unsigned fiberCount, const UString& u1, JSString* s2)
         {
             Base::finishCreation(globalData);
-            ASSERT(fiberCount <= s_maxInternalRopeLength);
+            ASSERT_UNUSED(fiberCount, fiberCount <= s_maxInternalRopeLength);
             unsigned index = 0;
             appendStringInCreate(index, u1);
             appendStringInCreate(index, s2);

Modified: trunk/Source/_javascript_Core/runtime/ScopeChain.h (93840 => 93841)


--- trunk/Source/_javascript_Core/runtime/ScopeChain.h	2011-08-26 00:36:13 UTC (rev 93840)
+++ trunk/Source/_javascript_Core/runtime/ScopeChain.h	2011-08-26 00:41:03 UTC (rev 93841)
@@ -50,8 +50,7 @@
         void finishCreation(JSGlobalData* globalData, JSGlobalObject* globalObject)
         {
             Base::finishCreation(*globalData);
-            ASSERT(globalData);
-            ASSERT(globalObject);
+            ASSERT_UNUSED(globalObject, globalObject);
         }
 
     public:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to