[webkit-changes] [93882] trunk/Source/WebCore

[pfeldman]

Title: [93882] trunk/Source/WebCore

Revision

93882

Author

pfeld...@chromium.org

Date

2011-08-26 09:57:31 -0700 (Fri, 26 Aug 2011)

Log Message

Web Inspector: [REGRESSION] No way to expand hovered objects while debugging.
https://bugs.webkit.org/show_bug.cgi?id=67039

Reviewed by Yury Semikhatsky.

* inspector/front-end/Popover.js:
(WebInspector.Popover):
(WebInspector.Popover.prototype.show):
(WebInspector.PopoverHelper.prototype._mouseDown):
(WebInspector.PopoverHelper.prototype._hidePopover):
(WebInspector.PopoverHelper.prototype._mouseHover):
(WebInspector.PopoverHelper.prototype._killHidePopoverTimer):

Modified Paths

• trunk/Source/WebCore/ChangeLog
• trunk/Source/WebCore/inspector/front-end/Popover.js

Diff

Modified: trunk/Source/WebCore/ChangeLog (93881 => 93882)

--- trunk/Source/WebCore/ChangeLog	2011-08-26 16:26:04 UTC (rev 93881)
+++ trunk/Source/WebCore/ChangeLog	2011-08-26 16:57:31 UTC (rev 93882)
@@ -1,3 +1,18 @@
+2011-08-26  Pavel Feldman  <pfeld...@google.com>
+
+        Web Inspector: [REGRESSION] No way to expand hovered objects while debugging.
+        https://bugs.webkit.org/show_bug.cgi?id=67039
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/Popover.js:
+        (WebInspector.Popover):
+        (WebInspector.Popover.prototype.show):
+        (WebInspector.PopoverHelper.prototype._mouseDown):
+        (WebInspector.PopoverHelper.prototype._hidePopover):
+        (WebInspector.PopoverHelper.prototype._mouseHover):
+        (WebInspector.PopoverHelper.prototype._killHidePopoverTimer):
+
 2011-08-26  Pavel Podivilov  <podivi...@chromium.org>
 
         Unreviewed, rolling out r93870.

Modified: trunk/Source/WebCore/inspector/front-end/Popover.js (93881 => 93882)

--- trunk/Source/WebCore/inspector/front-end/Popover.js	2011-08-26 16:26:04 UTC (rev 93881)
+++ trunk/Source/WebCore/inspector/front-end/Popover.js	2011-08-26 16:57:31 UTC (rev 93882)
@@ -30,9 +30,9 @@
 
 /**
  * @constructor
- * @param {Element} contentElement
+ * @param {WebInspector.PopoverHelper=} popoverHelper
  */
-WebInspector.Popover = function()
+WebInspector.Popover = function(popoverHelper)
 {
     this.element = document.createElement("div");
     this.element.className = "popover";
@@ -44,6 +44,7 @@
     this._contentDiv = document.createElement("div");
     this._contentDiv.className = "content";
     this._visible = false;
+    this._popoverHelper = popoverHelper;
 }
 
 WebInspector.Popover.prototype = {
@@ -69,6 +70,8 @@
         document.body.appendChild(this.element);
         this._positionElement(anchor, preferredWidth, preferredHeight);
         this._visible = true;
+        if (this._popoverHelper)
+            contentElement.addEventListener("mousemove", this._popoverHelper._killHidePopoverTimer.bind(this._popoverHelper), true);
     },
 
     hide: function()
@@ -197,7 +200,7 @@
 
     _mouseDown: function(event)
     {
-        this._killHidePopupTimer();
+        this._killHidePopoverTimer();
         this._handleMouseAction(event, true);
     },
 
@@ -249,7 +252,6 @@
 
     _hidePopover: function()
     {
-        delete this._popupInstanceMarker;
         if (!this._popover)
             return;
 
@@ -265,15 +267,15 @@
         delete this._hoverTimer;
 
         this._hidePopover();
-        this._popover = new WebInspector.Popover();
+        this._popover = new WebInspector.Popover(this);
         this._showPopover(element, this._popover);
     },
 
-    _killHidePopupTimer: function()
+    _killHidePopoverTimer: function()
     {
         if (this._hidePopoverTimer) {
             clearTimeout(this._hidePopoverTimer);
-            delete this._hidePopupTimer;
+            delete this._hidePopoverTimer;
 
             // We know that we reached the popup, but we might have moved over other elements.
             // Discard pending command.

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes