Title: [94049] trunk/Source/WebKit/win
- Revision
- 94049
- Author
- [email protected]
- Date
- 2011-08-29 23:07:29 -0700 (Mon, 29 Aug 2011)
Log Message
Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=67152
Reviewed by Darin Adler.
Updated call sites of lastChangeWasUserEdit since it's moved from RenderTextControl
to HTMLTextFormControlElement.
* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::isUserEdited):
Modified Paths
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (94048 => 94049)
--- trunk/Source/WebKit/win/ChangeLog 2011-08-30 05:55:54 UTC (rev 94048)
+++ trunk/Source/WebKit/win/ChangeLog 2011-08-30 06:07:29 UTC (rev 94049)
@@ -1,3 +1,17 @@
+2011-08-29 Ryosuke Niwa <[email protected]>
+
+ Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
+ https://bugs.webkit.org/show_bug.cgi?id=67152
+
+ Reviewed by Darin Adler.
+
+ Updated call sites of lastChangeWasUserEdit since it's moved from RenderTextControl
+ to HTMLTextFormControlElement.
+
+ * DOMHTMLClasses.cpp:
+ (DOMHTMLInputElement::isUserEdited):
+ (DOMHTMLTextAreaElement::isUserEdited):
+
2011-08-29 Sheriff Bot <[email protected]>
Unreviewed, rolling out r93987, r93992, r93995, r93998, and
Modified: trunk/Source/WebKit/win/DOMHTMLClasses.cpp (94048 => 94049)
--- trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2011-08-30 05:55:54 UTC (rev 94048)
+++ trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2011-08-30 06:07:29 UTC (rev 94049)
@@ -1381,12 +1381,11 @@
return E_POINTER;
*result = FALSE;
- ASSERT(m_element);
+ ASSERT(m_element && m_element->hasTagName(inputTag));
BOOL textField = FALSE;
if (FAILED(isTextField(&textField)) || !textField)
return S_OK;
- RenderObject* renderer = m_element->renderer();
- if (renderer && toRenderTextControl(renderer)->lastChangeWasUserEdit())
+ if (static_cast<HTMLInputElement*>(m_element)->lastChangeWasUserEdit())
*result = TRUE;
return S_OK;
}
@@ -1581,9 +1580,8 @@
return E_POINTER;
*result = FALSE;
- ASSERT(m_element);
- RenderObject* renderer = m_element->renderer();
- if (renderer && toRenderTextControl(renderer)->lastChangeWasUserEdit())
+ ASSERT(m_element && m_element->hasTagName(textareaTag));
+ if (static_cast<HTMLTextAreaElement*>(m_element)->lastChangeWasUserEdit())
*result = TRUE;
return S_OK;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
