Title: [94066] trunk/LayoutTests
Revision
94066
Author
[email protected]
Date
2011-08-30 03:54:47 -0700 (Tue, 30 Aug 2011)

Log Message

2011-08-30  Yury Semikhatsky  <[email protected]>

        Unreviewed. Update window.onerror tests after r94061 to match new semantics
        of window.onerror return value.

        * fast/workers/resources/shared-worker-script-error.js:
        * http/tests/security/cross-origin-script-window-onerror-redirected.html:
        * http/tests/security/cross-origin-script-window-onerror.html:
        * userscripts/window-onerror-for-isolated-world-1.html:
        * userscripts/window-onerror-for-isolated-world-2.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (94065 => 94066)


--- trunk/LayoutTests/ChangeLog	2011-08-30 10:25:16 UTC (rev 94065)
+++ trunk/LayoutTests/ChangeLog	2011-08-30 10:54:47 UTC (rev 94066)
@@ -1,5 +1,16 @@
 2011-08-30  Yury Semikhatsky  <[email protected]>
 
+        Unreviewed. Update window.onerror tests after r94061 to match new semantics
+        of window.onerror return value.
+
+        * fast/workers/resources/shared-worker-script-error.js:
+        * http/tests/security/cross-origin-script-window-onerror-redirected.html:
+        * http/tests/security/cross-origin-script-window-onerror.html:
+        * userscripts/window-onerror-for-isolated-world-1.html:
+        * userscripts/window-onerror-for-isolated-world-2.html:
+
+2011-08-30  Yury Semikhatsky  <[email protected]>
+
         Unreviewed. Update Chromium test expectations for new test.
 
         * platform/chromium/fast/events/window-onerror13-expected.txt: Added.

Modified: trunk/LayoutTests/fast/workers/resources/shared-worker-script-error.js (94065 => 94066)


--- trunk/LayoutTests/fast/workers/resources/shared-worker-script-error.js	2011-08-30 10:25:16 UTC (rev 94065)
+++ trunk/LayoutTests/fast/workers/resources/shared-worker-script-error.js	2011-08-30 10:54:47 UTC (rev 94066)
@@ -13,7 +13,7 @@
     } else if (event.data == "handledError") {
         _onerror_ = function(message, url, lineno) {
             port.postMessage("SUCCESS: error handled via onerror: " + message);
-            return false;
+            return true;
         };
         generateError();  // Undefined function call
     } else {

Modified: trunk/LayoutTests/http/tests/security/cross-origin-script-window-onerror-redirected.html (94065 => 94066)


--- trunk/LayoutTests/http/tests/security/cross-origin-script-window-onerror-redirected.html	2011-08-30 10:25:16 UTC (rev 94065)
+++ trunk/LayoutTests/http/tests/security/cross-origin-script-window-onerror-redirected.html	2011-08-30 10:54:47 UTC (rev 94066)
@@ -14,7 +14,7 @@
   document.getElementById("result").textContent = "window.onerror message: " + message + " at " + url + ": " + line;
   if (window.layoutTestController)
     layoutTestController.notifyDone();
-  return false;
+  return true;
 }
 </script>
 <script src=""

Modified: trunk/LayoutTests/http/tests/security/cross-origin-script-window-onerror.html (94065 => 94066)


--- trunk/LayoutTests/http/tests/security/cross-origin-script-window-onerror.html	2011-08-30 10:25:16 UTC (rev 94065)
+++ trunk/LayoutTests/http/tests/security/cross-origin-script-window-onerror.html	2011-08-30 10:54:47 UTC (rev 94066)
@@ -16,7 +16,7 @@
   document.getElementById("result").textContent = "window.onerror message: " + message + " at " + url + ": " + line;
   if (window.layoutTestController)
     layoutTestController.notifyDone();
-  return false;
+  return true;
 }
 </script>
 <script src=""

Modified: trunk/LayoutTests/userscripts/window-onerror-for-isolated-world-1.html (94065 => 94066)


--- trunk/LayoutTests/userscripts/window-onerror-for-isolated-world-1.html	2011-08-30 10:25:16 UTC (rev 94065)
+++ trunk/LayoutTests/userscripts/window-onerror-for-isolated-world-1.html	2011-08-30 10:54:47 UTC (rev 94066)
@@ -31,13 +31,14 @@
 window._onerror_ = function(msg, url, line)
 {
     log("Main world window.onerror: " + msg + " at " + lastUrlComponent(url) + ":" + line);
-    return false;
+    return true;
 }
 
 window.addEventListener("error", function(e)
 {
     var url = ""
     log("Main world error event listener: " + e.message + " at " + url + ":" + e.lineno);
+    e.preventDefault();
 }, false);
 
 var exceptions = function(isolatedWorld)

Modified: trunk/LayoutTests/userscripts/window-onerror-for-isolated-world-2.html (94065 => 94066)


--- trunk/LayoutTests/userscripts/window-onerror-for-isolated-world-2.html	2011-08-30 10:25:16 UTC (rev 94065)
+++ trunk/LayoutTests/userscripts/window-onerror-for-isolated-world-2.html	2011-08-30 10:54:47 UTC (rev 94066)
@@ -44,7 +44,7 @@
 
     window._onerror_ = function(msg, url, line) {
         log(isolatedWorld + " window.onerror: " + msg + " at " + lastUrlComponent(url) + ":" + line, "*");
-        return false;
+        return true;
     }
 
     window.addEventListener("error", function(e) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to