Diff
Modified: trunk/Source/WebCore/ChangeLog (94079 => 94080)
--- trunk/Source/WebCore/ChangeLog 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebCore/ChangeLog 2011-08-30 16:10:11 UTC (rev 94080)
@@ -1,3 +1,18 @@
+2011-08-30 Kaustubh Atrawalkar <[email protected]>
+
+ The unused ScrollView* argument can and should be removed from
+ scrollRectIntoView.
+ https://bugs.webkit.org/show_bug.cgi?id=67117
+
+ Reviewed by Darin Adler.
+
+ * loader/EmptyClients.h:
+ (WebCore::EmptyChromeClient::scrollRectIntoView):
+ * page/Chrome.cpp:
+ (WebCore::Chrome::scrollRectIntoView):
+ * page/ChromeClient.h:
+ (WebCore::ChromeClient::scrollRectIntoView):
+
2011-08-30 Ben Wells <[email protected]>
Update registerProtocolHandler scheme whitelist to match spec
Modified: trunk/Source/WebCore/loader/EmptyClients.h (94079 => 94080)
--- trunk/Source/WebCore/loader/EmptyClients.h 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2011-08-30 16:10:11 UTC (rev 94080)
@@ -214,7 +214,7 @@
virtual void setCursor(const Cursor&) { }
virtual void setCursorHiddenUntilMouseMoves(bool) { }
- virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const {}
+ virtual void scrollRectIntoView(const IntRect&) const { }
virtual void requestGeolocationPermissionForFrame(Frame*, Geolocation*) {}
virtual void cancelGeolocationPermissionRequestForFrame(Frame*, Geolocation*) {}
Modified: trunk/Source/WebCore/page/Chrome.cpp (94079 => 94080)
--- trunk/Source/WebCore/page/Chrome.cpp 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebCore/page/Chrome.cpp 2011-08-30 16:10:11 UTC (rev 94080)
@@ -127,8 +127,7 @@
void Chrome::scrollRectIntoView(const IntRect& rect) const
{
- // FIXME: The unused ScrollView* argument can and should be removed from ChromeClient::scrollRectIntoView.
- m_client->scrollRectIntoView(rect, 0);
+ m_client->scrollRectIntoView(rect);
}
void Chrome::scrollbarsModeDidChange() const
Modified: trunk/Source/WebCore/page/ChromeClient.h (94079 => 94080)
--- trunk/Source/WebCore/page/ChromeClient.h 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebCore/page/ChromeClient.h 2011-08-30 16:10:11 UTC (rev 94080)
@@ -168,7 +168,7 @@
virtual void contentsSizeChanged(Frame*, const IntSize&) const = 0;
virtual void layoutUpdated(Frame*) const { }
- virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const = 0; // Currently only Mac has a non empty implementation.
+ virtual void scrollRectIntoView(const IntRect&) { }; // Currently only Mac has a non empty implementation.
virtual bool shouldMissingPluginMessageBeButton() const { return false; }
virtual void missingPluginButtonClicked(Element*) const { }
Modified: trunk/Source/WebKit/chromium/ChangeLog (94079 => 94080)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-30 16:10:11 UTC (rev 94080)
@@ -1,3 +1,15 @@
+2011-08-30 Kaustubh Atrawalkar <[email protected]>
+
+ The unused ScrollView* argument can and should be removed from
+ scrollRectIntoView.
+ https://bugs.webkit.org/show_bug.cgi?id=67117
+
+ Reviewed by Darin Adler.
+
+ * src/WebPopupMenuImpl.cpp:
+ (WebKit::WebPopupMenuImpl::scrollRectIntoView):
+ * src/WebPopupMenuImpl.h:
+
2011-08-29 Greg Billock <[email protected]>
[Chromium] Add ability to do static SerializedScriptValue deserialization
Modified: trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp (94079 => 94080)
--- trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp 2011-08-30 16:10:11 UTC (rev 94080)
@@ -397,7 +397,7 @@
return IntRect();
}
-void WebPopupMenuImpl::scrollRectIntoView(const IntRect&, const ScrollView*) const
+void WebPopupMenuImpl::scrollRectIntoView(const IntRect&) const
{
// Nothing to be done here since we do not have the concept of a container
// that implements its own scrolling.
Modified: trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h (94079 => 94080)
--- trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h 2011-08-30 16:10:11 UTC (rev 94080)
@@ -128,7 +128,7 @@
virtual WebCore::IntPoint screenToWindow(const WebCore::IntPoint&) const;
virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&) const;
virtual PlatformPageClient platformPageClient() const { return 0; }
- virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const;
+ virtual void scrollRectIntoView(const WebCore::IntRect&) const;
virtual void scrollbarsModeDidChange() const;
virtual void setCursor(const WebCore::Cursor&);
virtual void setCursorHiddenUntilMouseMoves(bool);
Modified: trunk/Source/WebKit/efl/ChangeLog (94079 => 94080)
--- trunk/Source/WebKit/efl/ChangeLog 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-08-30 16:10:11 UTC (rev 94080)
@@ -1,3 +1,14 @@
+2011-08-30 Kaustubh Atrawalkar <[email protected]>
+
+ The unused ScrollView* argument can and should be removed from
+ scrollRectIntoView.
+ https://bugs.webkit.org/show_bug.cgi?id=67117
+
+ Reviewed by Darin Adler.
+
+ * WebCoreSupport/ChromeClientEfl.h:
+ (WebCore::ChromeClientEfl::scrollRectIntoView):
+
2011-08-30 Grzegorz Czajkowski <[email protected]>
[EFL] Add const modifier to passed objects where it's recommended
Modified: trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h (94079 => 94080)
--- trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h 2011-08-30 16:10:11 UTC (rev 94080)
@@ -147,7 +147,7 @@
virtual void setCursor(const Cursor&);
virtual void setCursorHiddenUntilMouseMoves(bool);
- virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const { }
+ virtual void scrollRectIntoView(const IntRect&) const { }
virtual void requestGeolocationPermissionForFrame(Frame*, Geolocation*);
virtual void cancelGeolocationPermissionRequestForFrame(Frame*, Geolocation*);
Modified: trunk/Source/WebKit/gtk/ChangeLog (94079 => 94080)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-08-30 16:10:11 UTC (rev 94080)
@@ -1,3 +1,14 @@
+2011-08-30 Kaustubh Atrawalkar <[email protected]>
+
+ The unused ScrollView* argument can and should be removed from
+ scrollRectIntoView.
+ https://bugs.webkit.org/show_bug.cgi?id=67117
+
+ Reviewed by Darin Adler.
+
+ * WebCoreSupport/ChromeClientGtk.h:
+ (WebKit::ChromeClient::scrollRectIntoView):
+
2011-08-26 Gustavo Noronha Silva <[email protected]>
Minor style fix in the sample code for WebKitWebFrame.
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h (94079 => 94080)
--- trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h 2011-08-30 16:10:11 UTC (rev 94080)
@@ -133,7 +133,7 @@
virtual void setCursor(const WebCore::Cursor&);
virtual void setCursorHiddenUntilMouseMoves(bool);
- virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const {}
+ virtual void scrollRectIntoView(const WebCore::IntRect&) const { }
virtual void requestGeolocationPermissionForFrame(WebCore::Frame*, WebCore::Geolocation*);
virtual void cancelGeolocationPermissionRequestForFrame(WebCore::Frame*, WebCore::Geolocation*);
Modified: trunk/Source/WebKit/haiku/ChangeLog (94079 => 94080)
--- trunk/Source/WebKit/haiku/ChangeLog 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/haiku/ChangeLog 2011-08-30 16:10:11 UTC (rev 94080)
@@ -1,3 +1,14 @@
+2011-08-30 Kaustubh Atrawalkar <[email protected]>
+
+ The unused ScrollView* argument can and should be removed from
+ scrollRectIntoView.
+ https://bugs.webkit.org/show_bug.cgi?id=67117
+
+ Reviewed by Darin Adler.
+
+ * WebCoreSupport/ChromeClientHaiku.cpp:
+ (WebCore::ChromeClientHaiku::scrollRectIntoView):
+
2011-08-17 Adam Roben <[email protected]>
Make WebCore keep track of the current device scale factor
Modified: trunk/Source/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp (94079 => 94080)
--- trunk/Source/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp 2011-08-30 16:10:11 UTC (rev 94080)
@@ -301,7 +301,7 @@
notImplemented();
}
-void ChromeClientHaiku::scrollRectIntoView(const IntRect&, const ScrollView*) const
+void ChromeClientHaiku::scrollRectIntoView(const IntRect&) const
{
notImplemented();
}
Modified: trunk/Source/WebKit/mac/ChangeLog (94079 => 94080)
--- trunk/Source/WebKit/mac/ChangeLog 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/mac/ChangeLog 2011-08-30 16:10:11 UTC (rev 94080)
@@ -1,3 +1,15 @@
+2011-08-30 Kaustubh Atrawalkar <[email protected]>
+
+ The unused ScrollView* argument can and should be removed from
+ scrollRectIntoView.
+ https://bugs.webkit.org/show_bug.cgi?id=67117
+
+ Reviewed by Darin Adler.
+
+ * WebCoreSupport/WebChromeClient.h:
+ * WebCoreSupport/WebChromeClient.mm:
+ (WebChromeClient::scrollRectIntoView):
+
2011-08-29 Sheriff Bot <[email protected]>
Unreviewed, rolling out r93987, r93992, r93995, r93998, and
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h (94079 => 94080)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2011-08-30 16:10:11 UTC (rev 94080)
@@ -97,7 +97,7 @@
virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&) const;
virtual PlatformPageClient platformPageClient() const;
virtual void contentsSizeChanged(WebCore::Frame*, const WebCore::IntSize&) const;
- virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const;
+ virtual void scrollRectIntoView(const WebCore::IntRect&) const;
virtual void setStatusbarText(const WTF::String&);
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm (94079 => 94080)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm 2011-08-30 16:10:11 UTC (rev 94080)
@@ -608,7 +608,7 @@
{
}
-void WebChromeClient::scrollRectIntoView(const IntRect& r, const ScrollView*) const
+void WebChromeClient::scrollRectIntoView(const IntRect& r) const
{
// FIXME: This scrolling behavior should be under the control of the embedding client,
// perhaps in a delegate method, rather than something WebKit does unconditionally.
Modified: trunk/Source/WebKit/qt/ChangeLog (94079 => 94080)
--- trunk/Source/WebKit/qt/ChangeLog 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-08-30 16:10:11 UTC (rev 94080)
@@ -1,3 +1,14 @@
+2011-08-30 Kaustubh Atrawalkar <[email protected]>
+
+ The unused ScrollView* argument can and should be removed from
+ scrollRectIntoView.
+ https://bugs.webkit.org/show_bug.cgi?id=67117
+
+ Reviewed by Darin Adler.
+
+ * WebCoreSupport/ChromeClientQt.h:
+ (WebCore::ChromeClientQt::scrollRectIntoView):
+
2011-08-25 Ademar de Souza Reis Jr. <[email protected]>
Unreviewed QtWebKit.pro fix for when building inside Qt
Modified: trunk/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.h (94079 => 94080)
--- trunk/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.h 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.h 2011-08-30 16:10:11 UTC (rev 94080)
@@ -180,7 +180,7 @@
virtual void setCursor(const Cursor&);
virtual void setCursorHiddenUntilMouseMoves(bool) { }
- virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const { }
+ virtual void scrollRectIntoView(const IntRect&) const { }
virtual void requestGeolocationPermissionForFrame(Frame*, Geolocation*) { }
virtual void cancelGeolocationPermissionRequestForFrame(Frame*, Geolocation*) { }
Modified: trunk/Source/WebKit/win/ChangeLog (94079 => 94080)
--- trunk/Source/WebKit/win/ChangeLog 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/win/ChangeLog 2011-08-30 16:10:11 UTC (rev 94080)
@@ -1,3 +1,14 @@
+2011-08-30 Kaustubh Atrawalkar <[email protected]>
+
+ The unused ScrollView* argument can and should be removed from
+ scrollRectIntoView.
+ https://bugs.webkit.org/show_bug.cgi?id=67117
+
+ Reviewed by Darin Adler.
+
+ * WebCoreSupport/WebChromeClient.h:
+ (WebChromeClient::scrollRectIntoView):
+
2011-08-29 Ryosuke Niwa <[email protected]>
Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h (94079 => 94080)
--- trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h 2011-08-30 16:10:11 UTC (rev 94080)
@@ -153,7 +153,7 @@
virtual void scheduleCompositingLayerSync();
#endif
- virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const {}
+ virtual void scrollRectIntoView(const WebCore::IntRect&) const { }
// FIXME: Remove once all ports are using client-based geolocation. https://bugs.webkit.org/show_bug.cgi?id=40373
// For client-based geolocation, these two methods have been moved to WebGeolocationClient. https://bugs.webkit.org/show_bug.cgi?id=50061
Modified: trunk/Source/WebKit/wince/ChangeLog (94079 => 94080)
--- trunk/Source/WebKit/wince/ChangeLog 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/wince/ChangeLog 2011-08-30 16:10:11 UTC (rev 94080)
@@ -1,3 +1,13 @@
+2011-08-30 Kaustubh Atrawalkar <[email protected]>
+
+ The unused ScrollView* argument can and should be removed from
+ scrollRectIntoView.
+ https://bugs.webkit.org/show_bug.cgi?id=67117
+
+ Reviewed by Darin Adler.
+
+ * WebCoreSupport/ChromeClientWinCE.h:
+
2011-08-17 Adam Roben <[email protected]>
Make WebCore keep track of the current device scale factor
Modified: trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h (94079 => 94080)
--- trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h 2011-08-30 16:10:11 UTC (rev 94080)
@@ -101,7 +101,7 @@
virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&) const;
virtual PlatformPageClient platformPageClient() const;
virtual void contentsSizeChanged(WebCore::Frame*, const WebCore::IntSize&) const;
- virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const; // Currently only Mac has a non empty implementation.
+ virtual void scrollRectIntoView(const WebCore::IntRect&) const; // Currently only Mac has a non empty implementation.
virtual void scrollbarsModeDidChange() const;
virtual void setCursor(const WebCore::Cursor&);
virtual void setCursorHiddenUntilMouseMoves(bool);
Modified: trunk/Source/WebKit/wx/ChangeLog (94079 => 94080)
--- trunk/Source/WebKit/wx/ChangeLog 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/wx/ChangeLog 2011-08-30 16:10:11 UTC (rev 94080)
@@ -1,3 +1,14 @@
+2011-08-30 Kaustubh Atrawalkar <[email protected]>
+
+ The unused ScrollView* argument can and should be removed from
+ scrollRectIntoView.
+ https://bugs.webkit.org/show_bug.cgi?id=67117
+
+ Reviewed by Darin Adler.
+
+ * WebKitSupport/ChromeClientWx.h:
+ (WebCore::ChromeClientWx::scrollRectIntoView):
+
2011-08-17 Adam Roben <[email protected]>
Make WebCore keep track of the current device scale factor
Modified: trunk/Source/WebKit/wx/WebKitSupport/ChromeClientWx.h (94079 => 94080)
--- trunk/Source/WebKit/wx/WebKitSupport/ChromeClientWx.h 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit/wx/WebKitSupport/ChromeClientWx.h 2011-08-30 16:10:11 UTC (rev 94080)
@@ -141,7 +141,7 @@
virtual void setCursor(const Cursor&);
virtual void setCursorHiddenUntilMouseMoves(bool) { }
- virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const {}
+ virtual void scrollRectIntoView(const IntRect&) const { }
virtual void requestGeolocationPermissionForFrame(Frame*, Geolocation*);
virtual void cancelGeolocationPermissionRequestForFrame(Frame*, Geolocation*) { }
Modified: trunk/Source/WebKit2/ChangeLog (94079 => 94080)
--- trunk/Source/WebKit2/ChangeLog 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-30 16:10:11 UTC (rev 94080)
@@ -1,3 +1,15 @@
+2011-08-30 Kaustubh Atrawalkar <[email protected]>
+
+ The unused ScrollView* argument can and should be removed from
+ scrollRectIntoView.
+ https://bugs.webkit.org/show_bug.cgi?id=67117
+
+ Reviewed by Darin Adler.
+
+ * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+ (WebKit::WebChromeClient::scrollRectIntoView):
+ * WebProcess/WebCoreSupport/WebChromeClient.h:
+
2011-08-29 Ryosuke Niwa <[email protected]>
Another Windows build fix after r94047.
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (94079 => 94080)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2011-08-30 16:10:11 UTC (rev 94080)
@@ -463,7 +463,7 @@
}
}
-void WebChromeClient::scrollRectIntoView(const IntRect&, const ScrollView*) const
+void WebChromeClient::scrollRectIntoView(const IntRect&) const
{
notImplemented();
}
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h (94079 => 94080)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2011-08-30 16:00:46 UTC (rev 94079)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h 2011-08-30 16:10:11 UTC (rev 94080)
@@ -119,7 +119,7 @@
virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&) const;
virtual PlatformPageClient platformPageClient() const;
virtual void contentsSizeChanged(WebCore::Frame*, const WebCore::IntSize&) const;
- virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const; // Currently only Mac has a non empty implementation.
+ virtual void scrollRectIntoView(const WebCore::IntRect&) const; // Currently only Mac has a non empty implementation.
// End methods used by HostWindow.
virtual bool shouldMissingPluginMessageBeButton() const;
