Title: [94082] trunk/Source/WebCore
- Revision
- 94082
- Author
- [email protected]
- Date
- 2011-08-30 09:35:32 -0700 (Tue, 30 Aug 2011)
Log Message
Remove webcore_bindings (including DerivedSources##.cpp) from the critical path
https://bugs.webkit.org/show_bug.cgi?id=67168
Reviewed by Adam Barth.
webcore_bindings_sources generates various files (e.g., CSSPropertyNames,
DerivedSources, HTMLNames, etc). webcore_bindings depends on webcore_bindings_sources
and compiles these files. Previously, the other webcore libs (webcore_svg,
webcore_html, webcore_remaining, etc) depended on webcore_bindings. This changes the
dependency on webocre_bindings_sources so the build can parallelize the compile of
webcore_bindings and the other webcore_* libs.
No new tests, just changing the build dependencies. Manually copy over the
include dirs that we used to get from webcore_bindings' direct_dependent_settings.
* WebCore.gyp/WebCore.gyp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (94081 => 94082)
--- trunk/Source/WebCore/ChangeLog 2011-08-30 16:35:06 UTC (rev 94081)
+++ trunk/Source/WebCore/ChangeLog 2011-08-30 16:35:32 UTC (rev 94082)
@@ -1,3 +1,22 @@
+2011-08-30 Tony Chang <[email protected]>
+
+ Remove webcore_bindings (including DerivedSources##.cpp) from the critical path
+ https://bugs.webkit.org/show_bug.cgi?id=67168
+
+ Reviewed by Adam Barth.
+
+ webcore_bindings_sources generates various files (e.g., CSSPropertyNames,
+ DerivedSources, HTMLNames, etc). webcore_bindings depends on webcore_bindings_sources
+ and compiles these files. Previously, the other webcore libs (webcore_svg,
+ webcore_html, webcore_remaining, etc) depended on webcore_bindings. This changes the
+ dependency on webocre_bindings_sources so the build can parallelize the compile of
+ webcore_bindings and the other webcore_* libs.
+
+ No new tests, just changing the build dependencies. Manually copy over the
+ include dirs that we used to get from webcore_bindings' direct_dependent_settings.
+
+ * WebCore.gyp/WebCore.gyp:
+
2011-08-30 Kaustubh Atrawalkar <[email protected]>
The unused ScrollView* argument can and should be removed from
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (94081 => 94082)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-08-30 16:35:06 UTC (rev 94081)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-08-30 16:35:32 UTC (rev 94082)
@@ -1045,7 +1045,7 @@
'target_name': 'webcore_prerequisites',
'type': 'none',
'dependencies': [
- 'webcore_bindings',
+ 'webcore_bindings_sources',
'../../ThirdParty/glu/glu.gyp:libtess',
'../../_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp:yarr',
'../../_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp:wtf',
@@ -1063,7 +1063,6 @@
'<(libjpeg_gyp_path):libjpeg',
],
'export_dependent_settings': [
- 'webcore_bindings',
'../../_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp:yarr',
'../../_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp:wtf',
'<(chromium_src_dir)/build/temp_gyp/googleurl.gyp:googleurl',
@@ -1091,6 +1090,8 @@
'<@(webcore_include_dirs)',
'<(chromium_src_dir)/gpu',
'<(chromium_src_dir)/third_party/angle/include/GLSLANG',
+ '<(SHARED_INTERMEDIATE_DIR)/webkit',
+ '<(SHARED_INTERMEDIATE_DIR)/webkit/bindings',
],
'mac_framework_dirs': [
'$(SDKROOT)/System/Library/Frameworks/ApplicationServices.framework/Frameworks',
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
