Title: [94085] trunk/Source/WebCore
- Revision
- 94085
- Author
- [email protected]
- Date
- 2011-08-30 10:06:39 -0700 (Tue, 30 Aug 2011)
Log Message
Fix compile warning on clang:
error: 'WebKit::ChromeClientImpl::scrollRectIntoView' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
virtual void scrollRectIntoView(
^
../../WebCore/page/ChromeClient.h:171:22: note: hidden overloaded virtual function 'WebCore::ChromeClient::scrollRectIntoView' declared here
virtual void scrollRectIntoView(const IntRect&) { }; // Currently only Mac has a non empty implementation.
* page/ChromeClient.h:
(WebCore::ChromeClient::scrollRectIntoView):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (94084 => 94085)
--- trunk/Source/WebCore/ChangeLog 2011-08-30 16:57:37 UTC (rev 94084)
+++ trunk/Source/WebCore/ChangeLog 2011-08-30 17:06:39 UTC (rev 94085)
@@ -1,3 +1,15 @@
+2011-08-30 Tony Chang <[email protected]>
+
+ Fix compile warning on clang:
+ error: 'WebKit::ChromeClientImpl::scrollRectIntoView' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
+ virtual void scrollRectIntoView(
+ ^
+ ../../WebCore/page/ChromeClient.h:171:22: note: hidden overloaded virtual function 'WebCore::ChromeClient::scrollRectIntoView' declared here
+ virtual void scrollRectIntoView(const IntRect&) { }; // Currently only Mac has a non empty implementation.
+
+ * page/ChromeClient.h:
+ (WebCore::ChromeClient::scrollRectIntoView):
+
2011-08-30 David Hyatt <[email protected]>
<rdar://problem/8832814> With large line-height, column break can happen anywhere in the
Modified: trunk/Source/WebCore/page/ChromeClient.h (94084 => 94085)
--- trunk/Source/WebCore/page/ChromeClient.h 2011-08-30 16:57:37 UTC (rev 94084)
+++ trunk/Source/WebCore/page/ChromeClient.h 2011-08-30 17:06:39 UTC (rev 94085)
@@ -168,7 +168,7 @@
virtual void contentsSizeChanged(Frame*, const IntSize&) const = 0;
virtual void layoutUpdated(Frame*) const { }
- virtual void scrollRectIntoView(const IntRect&) { }; // Currently only Mac has a non empty implementation.
+ virtual void scrollRectIntoView(const IntRect&) const { }; // Currently only Mac has a non empty implementation.
virtual bool shouldMissingPluginMessageBeButton() const { return false; }
virtual void missingPluginButtonClicked(Element*) const { }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
