Title: [94150] trunk/Tools
Revision
94150
Author
[email protected]
Date
2011-08-30 21:56:35 -0700 (Tue, 30 Aug 2011)

Log Message

Remove old-style UI from garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=67257

Reviewed by Dimitri Glazkov.

This code is nowhere near as awesome as the new hotness.  Let's remove
it so it doesn't weigh us down.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.

Modified Paths

Removed Paths

Diff

Deleted: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html (94149 => 94150)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html	2011-08-31 04:45:12 UTC (rev 94149)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html	2011-08-31 04:56:35 UTC (rev 94150)
@@ -1,68 +0,0 @@
-<!DOCTYPE html>
-<!--
-Copyright (C) 2011 Google Inc. All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions
-are met:
-1. Redistributions of source code must retain the above copyright
-   notice, this list of conditions and the following disclaimer.
-2. Redistributions in binary form must reproduce the above copyright
-   notice, this list of conditions and the following disclaimer in the
-   documentation and/or other materials provided with the distribution.
-
-THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
-AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
-THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
-BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
-CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
-THE POSSIBILITY OF SUCH DAMAGE.
-
-The favicons are from the awesome famfamfam.com, which is the website of Mark
-James, a web developer from Birmingham, UK.
--->
-<html>
-<head>
-<title>Garden-O-Matic</title>
-<link rel="stylesheet" href=""
-<link rel="icon" id="favicon" type="image/png" href=""
-</head>
-<body>
-<div class="butterbar"><span class="status">Loading...</span></div>
-<div class="infobar"><span class="status"></span></div>
-<div class="actions">
-    <button class="show-selected-failures">Show Selected Failures</button><button class="rebaseline-selected">Rebaseline Selected</button><button class="update-expectations-selected">Mark Selected as Expected</button><button class="refresh">Refresh</button>
-</div>
-<div class="recent-history"></div>
-<div class="results-detail results-view old-results-view">
-    <div class="toolbar">
-        <div class="actions">
-            <button class="rebaseline default">Add to Rebaseline Queue</button><button class="update-expectation">Mark Failure as Expected</button><button class="previous">&#9664;</button><button class="next">&#9654;</button><button class="dismiss">Close</button>
-        </div>
-        <div class="status"></div>
-        <div class="clear"></div>
-    </div>
-    <div class="content"></div>
-</div>
-<script src="" 
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-</body>
-</html>

Deleted: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js (94149 => 94150)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js	2011-08-31 04:45:12 UTC (rev 94149)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js	2011-08-31 04:56:35 UTC (rev 94150)
@@ -1,313 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-(function() {
-
-var kFastLoadingDEBUG = false;
-
-var g_updateTimerId = 0;
-var g_resultsDetailsIterator = null;
-var g_treeState = {};
-
-var kBuildFailedInfobarType = 'build-failed';
-
-function dismissButterbar()
-{
-    $('.butterbar').fadeOut('fast');
-    checkForLocalServer();
-}
-
-function displayOnButterbar(message)
-{
-    $('.butterbar .status').text(message);
-    $('.butterbar').fadeIn('fast');
-}
-
-function hideInfobar()
-{
-    $('.infobar').animate({
-        opacity: 'toggle',
-        height: 'toggle',
-    });
-}
-
-function hideInfobarIfOfType(type)
-{
-    if (!$('.infobar .status').is(':visible'))
-        return;
-    if ($('.infobar .status').attr(config.kInfobarTypeAttr) != type)
-        return;
-    hideInfobar();
-}
-
-function displayInfobar(message, type)
-{
-    $('.infobar .status').empty().attr(config.kInfobarTypeAttr, type).append(message);
-    $('.infobar').animate({
-        opacity: 'toggle',
-        height: 'toggle',
-    });
-}
-
-function setIconState(hasFailures)
-{
-    var faviconURL = 'images/favicon-' + (hasFailures ? 'red' : 'green') + '.png';
-    $('#favicon').attr('href', faviconURL);
-}
-
-function toggleButton(button, isEnabled)
-{
-    if (isEnabled)
-        button.removeAttr('disabled');
-    else
-        button.attr('disabled', true)
-}
-
-function rebaseline(failureInfoList)
-{
-    if (!failureInfoList.length)
-        return;
-    displayOnButterbar('Rebaselining...');
-    checkout.rebaseline(failureInfoList, function() {
-        dismissButterbar();
-        // FIXME: We should use something like a lightbox rather than alert!
-        alert('New results downloaded to your working copy. Please use "webkit-patch land-cowboy" to land the updated baselines.');
-    });
-}
-
-function showResultsDetail(failureInfo)
-{
-    var failureTypes = failureInfo.failureTypeList.join(' ');
-
-    var content = $('.results-detail .content');
-
-    if ($('.failure-details', content).attr(config.kBuilderNameAttr) == failureInfo.builderName &&
-        $('.failure-details', content).attr(config.kTestNameAttr) == failureInfo.testName &&
-        $('.failure-details', content).attr(config.kFailureTypesAttr) == failureTypes)
-        return;
-
-    displayOnButterbar('Loading...');
-
-    results.fetchResultsURLs(failureInfo, function(resultsURLs) {
-        var status = $('.results-detail .toolbar .status');
-
-        status.empty();
-        content.empty();
-
-        // FIXME: We should be passing the full list of failing builder names as the fourth argument.
-        status.append(ui.failureDetailsStatus(failureInfo, [failureInfo.builderName]));
-        var resultsGrid = new ui.results.ResultsGrid();
-        resultsGrid.addResults(resultsURLs);
-        content.append(resultsGrid);
-
-        toggleButton($('.results-detail .actions .next'), g_resultsDetailsIterator.hasNext());
-        toggleButton($('.results-detail .actions .previous'), g_resultsDetailsIterator.hasPrevious());
-        toggleButton($('.results-detail .actions .rebaseline'), results.canRebaseline(failureInfo.failureTypeList));
-
-        $('.failure-details', content).attr(config.kTestNameAttr, failureInfo.testName);
-        $('.failure-details', content).attr(config.kBuilderNameAttr, failureInfo.builderName);
-        $('.failure-details', content).attr(config.kFailureTypesAttr, failureTypes);
-
-        if (!$('.results-detail').is(":visible"))
-            $('.results-detail').fadeIn('fast', dismissButterbar);
-        else
-            dismissButterbar();
-    });
-}
-
-function hideResultsDetail()
-{
-    $('.results-detail').fadeOut('fast', function() {
-        $('.results-detail .status').empty();
-        $('.results-detail .content').empty();
-        // Strictly speaking, we don't need to clear g_resultsDetailsIterator,
-        // but doing so helps the garbage collector free memory.
-        g_resultsDetailsIterator = null;
-    });
-    checkout.updateExpectations(model.takeExpectationUpdateQueue(), function() {
-        // FIXME: Should we confirm with the use before executing the queue?
-        rebaseline(model.takeRebaselineQueue());
-    });
-}
-
-function nextResultsDetail()
-{
-    if (g_resultsDetailsIterator.hasNext())
-        g_resultsDetailsIterator.callNext();
-    else
-        hideResultsDetail();
-}
-
-function previousResultsDetail()
-{
-    g_resultsDetailsIterator.callPrevious();
-}
-
-function failureInfoFromResultsDetail()
-{
-    var failureDetails = $('.results-detail .failure-details');
-    return {
-        'builderName': failureDetails.attr(config.kBuilderNameAttr),
-        'testName': failureDetails.attr(config.kTestNameAttr),
-        'failureTypeList': results.failureTypeList(failureDetails.attr(config.kFailureTypesAttr)),
-    }
-}
-
-function addToRebaselineQueue()
-{
-    model.queueForRebaseline(failureInfoFromResultsDetail());
-    nextResultsDetail();
-}
-
-function addToExpectationUpdateQueue()
-{
-    model.queueForExpectationUpdate(failureInfoFromResultsDetail());
-    nextResultsDetail();
-}
-
-function selectedFailures()
-{
-    var failureInfoList = [];
-
-    $('.test input:checkbox').each(function() {
-        if (!this.checked)
-            return;
-        failureInfoList = failureInfoList.concat(ui.failureInfoListForSummary($(this).parents('.result')));
-    });
-
-    return failureInfoList;
-}
-
-function rebaselineSelected()
-{
-    rebaseline(selectedFailures());
-}
-
-function updateExpectationsForSelected()
-{
-    checkout.updateExpectations(selectedFailures(), $.noop);
-}
-
-function showSelectedFailures()
-{
-    var listOfArgumentArrays = selectedFailures().map(function(failureInfo) { return [failureInfo]; });
-    g_resultsDetailsIterator = new base.CallbackIterator(showResultsDetail, listOfArgumentArrays);
-    g_resultsDetailsIterator.callNext();
-}
-
-function rowsInRevisionRange(earliestRevision, latestRevision)
-{
-    var earliestRevision = base.asInteger(earliestRevision);
-    var latestRevision = base.asInteger(latestRevision);
-
-    var rows = [];
-    $('.recent-history tr').each(function() {
-        var revision = parseInt($(this).attr(config.kRevisionAttr));
-        if (earliestRevision <= revision && revision <= latestRevision)
-            rows.push(this);
-    });
-
-    return $(rows);
-}
-
-function rowsBeforeRevision(latestRevision)
-{
-    return rowsInRevisionRange(0, latestRevision)
-}
-
-function showRecentCommits()
-{
-    $('.recent-history').empty().append(ui.changelog(model.state.recentCommits));
-}
-
-function showBuilderProgress()
-{
-    $.each(model.state.resultsByBuilder, function(builderName, resultsTree) {
-        var builderIndex = Object.keys(config.kBuilders).indexOf(builderName);
-        rowsBeforeRevision(resultsTree.revision).each(function() {
-            $($(this).children()[builderIndex]).addClass('built');
-        });
-    });
-}
-
-function showUnexpectedFailure(failureAnalysis)
-{
-    var impliedFirstFailingRevision = failureAnalysis.newestPassingRevision + 1;
-    var regressionRows = rowsInRevisionRange(impliedFirstFailingRevision, failureAnalysis.oldestFailingRevision);
-
-    $('.entry', regressionRows).addClass('possible-regression');
-
-    var failureSummary = ui.summarizeFailure(failureAnalysis).attr(config.kRevisionAttr, impliedFirstFailingRevision);
-    (regressionRows.length ? regressionRows : $('.recent-history tr')).last().after(failureSummary);
-
-    // FIXME: We should just compute this for failureSummary instead of recomputing the whole page.
-    showBuilderProgress();
-}
-
-function showFailingBuildersInfobar(builderNameList)
-{
-    if (builderNameList.length)
-        displayInfobar(ui.infobarMessageForCompileErrors(builderNameList), kBuildFailedInfobarType);
-    else
-        hideInfobarIfOfType(kBuildFailedInfobarType);
-}
-
-function checkForLocalServer()
-{
-    checkout.isAvailable(function(available) {
-        if (!available)
-            displayOnButterbar('Run "webkit-patch garden-o-matic" to enable rebaseline features.')
-    });
-}
-
-function update()
-{
-    displayOnButterbar('Loading...');
-    builders.buildersFailingStepRequredForTestCoverage(showFailingBuildersInfobar);
-    base.callInParallel([model.updateRecentCommits, model.updateResultsByBuilder], function() {
-        showRecentCommits();
-        showBuilderProgress();
-        model.analyzeUnexpectedFailures(showUnexpectedFailure, dismissButterbar);
-        checkForLocalServer();
-    });
-}
-
-$('.show-selected-failures').live('click', showSelectedFailures);
-$('.rebaseline-selected').live('click', rebaselineSelected);
-$('.update-expectations-selected').live('click', updateExpectationsForSelected);
-$('.refresh').live('click', update);
-
-$('.results-detail .actions .next').live('click', nextResultsDetail);
-$('.results-detail .actions .previous').live('click', previousResultsDetail);
-$('.results-detail .actions .rebaseline').live('click', addToRebaselineQueue);
-$('.results-detail .actions .update-expectation').live('click', addToExpectationUpdateQueue);
-$('.results-detail .actions .dismiss').live('click', hideResultsDetail);
-
-$(document).ready(function() {
-    g_updateTimerId = window.setInterval(update, config.kUpdateFrequency);
-    update();
-});
-
-})();

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js (94149 => 94150)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js	2011-08-31 04:45:12 UTC (rev 94149)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js	2011-08-31 04:56:35 UTC (rev 94150)
@@ -39,49 +39,11 @@
     return builderName.replace(/Webkit /, '');
 }
 
-function displayNameForRevision(revisionNumber)
-{
-    return 'r' + revisionNumber;
-}
-
 ui.urlForTest = function(testName)
 {
     return 'http://trac.webkit.org/browser/trunk/LayoutTests/' + testName;
 }
 
-ui.infobarMessageForCompileErrors = function(builderNameList)
-{
-    var block = $('<div class="compile-errors">Build Failed:<ul></ul></div>');
-
-    var list = $('ul', block);
-    $.each(builderNameList, function(index, builderName) {
-        var listElement = $('<li><a target="_blank"></a></li>');
-        list.append(listElement);
-        $('a', listElement).attr('href', ui.displayURLForBuilder(builderName)).text(ui.displayNameForBuilder(builderName));
-    });
-
-    return block;
-};
-
-ui.failureDetailsStatus = function(failureInfo, builderNameList)
-{
-    var failureTypes = failureInfo.failureTypeList.join(' ');
-
-    var block = $('<span><span class="test-name"></span><span class="builder-list"></span></span>');
-    $('.test-name', block).addClass(failureTypes).text(failureInfo.testName);
-
-    var builderList = $('.builder-list', block);
-    $.each(builderNameList, function(index, builderName) {
-        var builder = $('<span class="builder-name"></span>')
-        builder.text(builderName);
-        if (builderName == failureInfo.builderName)
-            builder.addClass('selected');
-        builderList.append(builder);
-    });
-
-    return block;
-};
-
 ui.rolloutReasonForTestNameList = function(testNameList)
 {
     return 'Broke:\n' + testNameList.map(function(testName) {
@@ -89,101 +51,6 @@
     }).join('\n');
 }
 
-function builderTableDataCells(resultNodesByBuilder)
-{
-    if (!resultNodesByBuilder)
-        resultNodesByBuilder = {};
-
-    var list = [];
-
-    $.each(Object.keys(config.kBuilders), function(index, builderName) {
-        var block = $('<td class="builder"></td>');
-        block.attr('title', ui.displayNameForBuilder(builderName));
-        block.attr(config.kBuilderNameAttr, builderName);
-
-        if (builderName in resultNodesByBuilder) {
-            var unexpectedFailures = results.unexpectedResults(resultNodesByBuilder[builderName]);
-            var failureTypes = unexpectedFailures.join(' ');
-            block.attr(config.kFailureTypesAttr, failureTypes);
-        }
-
-        list.push(block[0])
-    });
-
-    return $(list);
-}
-
-ui.summarizeFailure = function(failureAnalysis)
-{
-    var block = $('<tr class="result"></tr>');
-    block.append(builderTableDataCells(failureAnalysis.resultNodesByBuilder));
-    block.append(
-        '<td class="test">' +
-          '<div class="what"><input type="checkbox"> <a class="test-name"></a></div>' +
-        '</td></tr>');
-    block.attr(config.kTestNameAttr, failureAnalysis.testName);
-
-    var unexpectedResults = results.collectUnexpectedResults(failureAnalysis.resultNodesByBuilder);
-    var failureTypes = unexpectedResults.join(' ');
-    $('.test-name', block).text(failureAnalysis.testName).attr('href', ui.urlForTest(failureAnalysis.testName)).addClass(failureTypes);
-
-    return block;
-};
-
-ui.failureInfoListForSummary = function(testSummary)
-{
-    var failureInfoList = [];
-
-    var testName = testSummary.attr(config.kTestNameAttr);
-    $('.builder', testSummary).each(function() {
-        var failureTypes = $(this).attr(config.kFailureTypesAttr);
-        if (!failureTypes)
-            return
-        var failureTypeList = results.failureTypeList(failureTypes);
-        var builderName = $(this).attr(config.kBuilderNameAttr);
-        failureInfoList.push({
-            'testName': testName,
-            'builderName': builderName,
-            'failureTypeList': failureTypeList,
-        });
-    });
-
-    return failureInfoList;
-};
-
-ui.commitEntry = function(commitData)
-{
-    var entry = $('<td class="entry"></td>');
-
-    entry.append('<div class="details"><a target="_blank" class="revision"></a> <span class="summary"></span> <span class="author"></span> <span class="reviewer-container">(Reviewer: <span class="reviewer"></span>)</span></div><div class="regressions"></div>');
-    $('.summary', entry).text(commitData.summary);
-    $('.revision', entry).attr('href', trac.changesetURL(commitData.revision)).text(displayNameForRevision(commitData.revision));
-    $('.author', entry).text(commitData.author);
-    if (commitData.reviewer)
-        $('.reviewer', entry).text(commitData.reviewer);
-    else
-        $('.reviewer-container', entry).detach();
-    if (commitData.wasReverted)
-        entry.addClass('reverted');
-
-    return entry;
-}
-
-ui.changelog = function(commitDataList)
-{
-    var block = $('<table class="changelog"><tbody></tbody></table>');
-
-    $.each(commitDataList, function(index, commitData) {
-        var row = $('<tr class="revision"></tr>');
-        row.append(builderTableDataCells());
-        row.attr(config.kRevisionAttr, commitData.revision);
-        row.append(ui.commitEntry(commitData));
-        $('tbody', block).append(row);
-    });
-
-    return block;
-};
-
 setInterval(function() {
     Array.prototype.forEach.call(document.querySelectorAll("time.relative"), function(time) {
         time.update && time.update();

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js (94149 => 94150)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js	2011-08-31 04:45:12 UTC (rev 94149)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js	2011-08-31 04:56:35 UTC (rev 94150)
@@ -46,38 +46,6 @@
     }
 }
 
-test("infobarMessageForCompileErrors", 1, function() {
-    var message = ui.infobarMessageForCompileErrors(['Mock Builder', 'Another Builder']);
-    message.wrap('<wrapper></wrapper>');
-    equal(message.parent().html(),
-        '<div class="compile-errors">Build Failed:<ul>' +
-            '<li><a target="_blank" href="" Builder</a></li>' +
-            '<li><a target="_blank" href="" Builder</a></li>' +
-        '</ul></div>');
-});
-
-test("rolloutReasonForTestNameList", 2, function() {
-    equal(ui.rolloutReasonForTestNameList(["path/to/test.html"]), "Broke:\n* path/to/test.html");
-    equal(ui.rolloutReasonForTestNameList(["path/to/test.html", "another/test.html"]), "Broke:\n* path/to/test.html\n* another/test.html");
-});
-
-test("failureDetailsStatus", 1, function() {
-    var status = ui.failureDetailsStatus({
-        'builderName': 'Mock Builder',
-        'testName': 'userscripts/another-test.html',
-        'failureTypeList': ['TEXT'],
-    }, ['Mock Builder', 'Another Builder']);
-    status.wrap('<wrapper></wrapper>');
-    equal(status.parent().html(),
-        '<span>' +
-            '<span class="test-name TEXT">userscripts/another-test.html</span>' +
-            '<span class="builder-list">' +
-                '<span class="builder-name selected">Mock Builder</span>' +
-                '<span class="builder-name">Another Builder</span>' +
-            '</span>' +
-        '</span>');
-});
-
 test("results.ResultsGrid", 1, function() {
     var grid = new ui.results.ResultsGrid()
     grid.addResults([
@@ -133,40 +101,6 @@
     equal(grid.innerHTML, '');
 });
 
-test("summarizeFailure", 1, function() {
-    var failureAnalysis = {
-        "testName": "svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html",
-        "resultNodesByBuilder": {
-            "Webkit Mac10.5 (CG)": {
-                "expected": "IMAGE",
-                "actual": "PASS"
-            },
-            "Webkit Mac10.5 (CG)(dbg)(2)": {
-                "expected": "IMAGE",
-                "actual":"PASS"
-            }
-        }
-    }
-
-    var failureSummary = ui.summarizeFailure(failureAnalysis);
-    var failureInfoList = ui.failureInfoListForSummary(failureSummary);
-
-    deepEqual(failureInfoList, [{
-        "testName": "svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html",
-        "builderName": "Webkit Mac10.5 (CG)",
-        "failureTypeList": [
-            "PASS"
-        ]
-      }, {
-        "testName": "svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html",
-        "builderName": "Webkit Mac10.5 (CG)(dbg)(2)",
-        "failureTypeList": [
-            "PASS"
-        ]
-      }
-    ]);
-});
-
 test("time", 6, function() {
     var time = new ui.RelativeTime();
     equal(time.tagName, 'TIME');

Deleted: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js (94149 => 94150)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js	2011-08-31 04:45:12 UTC (rev 94149)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js	2011-08-31 04:56:35 UTC (rev 94150)
@@ -1,63 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-(function() {
-
-function selectedSuccesses()
-{
-    var failureInfoList = [];
-
-    $('.test input:checkbox').each(function() {
-        if (!this.checked)
-            return;
-        failureInfoList = failureInfoList.concat(ui.failureInfoListForSummary($(this).parents('.result')));
-    });
-
-    return failureInfoList;
-}
-
-function updateExpectationsForSelected()
-{
-    checkout.updateExpectations(selectedSuccesses(), $.noop);
-}
-
-function showUnexpectedSuccess(successAnalysis)
-{
-    // FIXME: Rename summarizeFailure to make it appropriate to use here.
-    $('.recent-history table').append(ui.summarizeFailure(successAnalysis));
-}
-
-function update()
-{
-    model.updateResultsByBuilder(function() {
-        model.analyzeUnexpectedSuccesses(showUnexpectedSuccess);
-    });
-}
-
-$('.update-expectations-selected').live('click', updateExpectationsForSelected);
-
-$(document).ready(update);
-
-})();

Deleted: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html (94149 => 94150)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html	2011-08-31 04:45:12 UTC (rev 94149)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html	2011-08-31 04:56:35 UTC (rev 94150)
@@ -1,49 +0,0 @@
-<!DOCTYPE html>
-<!--
-Copyright (C) 2011 Google Inc. All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions
-are met:
-1. Redistributions of source code must retain the above copyright
-   notice, this list of conditions and the following disclaimer.
-2. Redistributions in binary form must reproduce the above copyright
-   notice, this list of conditions and the following disclaimer in the
-   documentation and/or other materials provided with the distribution.
-
-THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
-AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
-THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
-BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
-CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
-THE POSSIBILITY OF SUCH DAMAGE.
--->
-<html>
-<head>
-<title>Unexpected Passes</title>
-<link rel="stylesheet" href=""
-</head>
-<body>
-<div class="actions">
-    <button class="update-expectations-selected">Mark Selected as Expected</button>
-</div>
-<div class="recent-history"><table class="changelog"></table></div>
-<script src="" 
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-<script src=""
-</body>
-</html>

Modified: trunk/Tools/ChangeLog (94149 => 94150)


--- trunk/Tools/ChangeLog	2011-08-31 04:45:12 UTC (rev 94149)
+++ trunk/Tools/ChangeLog	2011-08-31 04:56:35 UTC (rev 94150)
@@ -1,3 +1,20 @@
+2011-08-30  Adam Barth  <[email protected]>
+
+        Remove old-style UI from garden-o-matic
+        https://bugs.webkit.org/show_bug.cgi?id=67257
+
+        Reviewed by Dimitri Glazkov.
+
+        This code is nowhere near as awesome as the new hotness.  Let's remove
+        it so it doesn't weigh us down.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
+
 2011-08-30  Takashi Toyoshima  <[email protected]>
 
         [WebSocket] update pywebsocket to 0.6b5.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to