Title: [94200] trunk/Tools
- Revision
- 94200
- Author
- [email protected]
- Date
- 2011-08-31 10:30:46 -0700 (Wed, 31 Aug 2011)
Log Message
garden-o-matic results view shouldn't be horrifically ugly
https://bugs.webkit.org/show_bug.cgi?id=67264
Reviewed by Dimitri Glazkov.
Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js (94199 => 94200)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2011-08-31 17:20:58 UTC (rev 94199)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2011-08-31 17:30:46 UTC (rev 94200)
@@ -38,12 +38,10 @@
this._view.addAction(new ui.actions.Rebaseline().makeDefault());
this._view.addAction(new ui.actions.Previous());
this._view.addAction(new ui.actions.Next());
- this._view.addAction(new ui.actions.Close());
$(this._view).bind('testselected', this.onTestSelected.bind(this));
$(this._view).bind('builderselected', this.onBuilderSelected.bind(this));
$(this._view).bind('rebaseline', this.onRebaseline.bind(this));
- $(this._view).bind('close', this.onClose.bind(this));
},
_failureInfoForTestAndBuilder: function(testName, builderName)
{
@@ -53,10 +51,6 @@
'failureTypeList': results.failureTypeList(this._resultsByTest[testName][builderName].actual)
}
},
- dismiss: function()
- {
- $(this._view).detach();
- },
showTest: function(testName)
{
var builderNameList = Object.keys(this._resultsByTest[testName]);
@@ -79,9 +73,6 @@
'builderName': builderName
});
},
- onClose: function() {
- this.dismiss();
- }
});
controllers.UnexpectedFailures = base.extends(Object, {
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js (94199 => 94200)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2011-08-31 17:20:58 UTC (rev 94199)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2011-08-31 17:30:46 UTC (rev 94200)
@@ -227,15 +227,14 @@
init: function(delegate)
{
this.className = 'results-view';
- this.innerHTML = '<div class="toolbar"><div class="selector"></div></div><div class="content"></div>';
+ this.innerHTML = '<div class="toolbar"></div><div class="content"></div>';
this._testSelector = new ui.results.TestSelector();
this._builderSelector = new ui.results.BuilderSelector();
this._resultsDetails = new ui.results.ResultsDetails(delegate);
this._actionList = new ui.actions.List();
- $('.toolbar', this).prepend(this._actionList);
- $('.selector', this).append(this._testSelector).append(this._builderSelector);
+ $('.toolbar', this).append(this._testSelector).append(this._builderSelector).append(this._actionList);
$('.content', this).append(this._resultsDetails);
},
addAction: function(action)
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css (94199 => 94200)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css 2011-08-31 17:20:58 UTC (rev 94199)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css 2011-08-31 17:30:46 UTC (rev 94200)
@@ -34,30 +34,21 @@
vertical-align: top;
}
-.results-view {
- background-color: #f5f5f5;
+.results-view table th {
+ padding: 3px;
+ border-bottom: 1px solid #AAA;
}
.results-view .toolbar {
- border-top: 1px solid #c6c6c6;
- border-bottom: 1px solid #c6c6c6;
+ padding-bottom: 15px;
}
-.results-view .toolbar .selector {
- font-size: 11px;
- font-weight: bold;
- height: 29px;
- line-height: 27px;
- margin: 11px 6px;
- padding: 0 8px;
-}
-
.results-view .test-selector {
width: 400px;
margin-right: 6px;
}
-.results-view .toolbar .actions {
+.results-view .actions {
float: right;
}
@@ -72,10 +63,6 @@
display: inline-block;
}
-.results-view td {
- background-color: white;
-}
-
.results-view .text-result {
border: none;
width: 100%;
Modified: trunk/Tools/ChangeLog (94199 => 94200)
--- trunk/Tools/ChangeLog 2011-08-31 17:20:58 UTC (rev 94199)
+++ trunk/Tools/ChangeLog 2011-08-31 17:30:46 UTC (rev 94200)
@@ -1,5 +1,18 @@
2011-08-31 Adam Barth <[email protected]>
+ garden-o-matic results view shouldn't be horrifically ugly
+ https://bugs.webkit.org/show_bug.cgi?id=67264
+
+ Reviewed by Dimitri Glazkov.
+
+ Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
+
+2011-08-31 Adam Barth <[email protected]>
+
garden-o-matic needs a tabstrip
https://bugs.webkit.org/show_bug.cgi?id=67263
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
