Title: [94232] trunk/Source/WebCore
- Revision
- 94232
- Author
- t...@chromium.org
- Date
- 2011-08-31 14:12:47 -0700 (Wed, 31 Aug 2011)
Log Message
Remove webcore_bindings (including DerivedSources##.cpp) from the critical path
https://bugs.webkit.org/show_bug.cgi?id=67168
Reviewed by Adam Barth.
webcore_bindings_sources, debugger_script_source, injected_script_source, and
inspector_protocol_sources generates various files (e.g., CSSPropertyNames,
DerivedSources, HTMLNames, etc). webcore_bindings depends on *_sources and compiles
these files. Previously, the other webcore libs (webcore_svg, webcore_html,
webcore_remaining, etc) depended on webcore_bindings. This moves the *_sources
dependencies from webcore_bindings to the other webcore libs so the build can
parallelize the compile of webcore_bindings and the other webcore_* libs.
Also copy over the include dirs that we used to get from webcore_bindings'
direct_dependent_settings.
No new tests, just changing the build dependencies.
* WebCore.gyp/WebCore.gyp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (94231 => 94232)
--- trunk/Source/WebCore/ChangeLog 2011-08-31 21:10:36 UTC (rev 94231)
+++ trunk/Source/WebCore/ChangeLog 2011-08-31 21:12:47 UTC (rev 94232)
@@ -1,3 +1,25 @@
+2011-08-31 Tony Chang <t...@chromium.org>
+
+ Remove webcore_bindings (including DerivedSources##.cpp) from the critical path
+ https://bugs.webkit.org/show_bug.cgi?id=67168
+
+ Reviewed by Adam Barth.
+
+ webcore_bindings_sources, debugger_script_source, injected_script_source, and
+ inspector_protocol_sources generates various files (e.g., CSSPropertyNames,
+ DerivedSources, HTMLNames, etc). webcore_bindings depends on *_sources and compiles
+ these files. Previously, the other webcore libs (webcore_svg, webcore_html,
+ webcore_remaining, etc) depended on webcore_bindings. This moves the *_sources
+ dependencies from webcore_bindings to the other webcore libs so the build can
+ parallelize the compile of webcore_bindings and the other webcore_* libs.
+
+ Also copy over the include dirs that we used to get from webcore_bindings'
+ direct_dependent_settings.
+
+ No new tests, just changing the build dependencies.
+
+ * WebCore.gyp/WebCore.gyp:
+
2011-08-31 Tony Gentilcore <to...@chromium.org>
Minor cleanup: remove inScriptExecution()
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (94231 => 94232)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-08-31 21:10:36 UTC (rev 94231)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-08-31 21:12:47 UTC (rev 94232)
@@ -1045,7 +1045,10 @@
'target_name': 'webcore_prerequisites',
'type': 'none',
'dependencies': [
- 'webcore_bindings',
+ 'debugger_script_source',
+ 'injected_script_source',
+ 'inspector_protocol_sources',
+ 'webcore_bindings_sources',
'../../ThirdParty/glu/glu.gyp:libtess',
'../../_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp:yarr',
'../../_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp:wtf',
@@ -1063,7 +1066,6 @@
'<(libjpeg_gyp_path):libjpeg',
],
'export_dependent_settings': [
- 'webcore_bindings',
'../../_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp:yarr',
'../../_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp:wtf',
'<(chromium_src_dir)/build/temp_gyp/googleurl.gyp:googleurl',
@@ -1091,6 +1093,8 @@
'<@(webcore_include_dirs)',
'<(chromium_src_dir)/gpu',
'<(chromium_src_dir)/third_party/angle/include/GLSLANG',
+ '<(SHARED_INTERMEDIATE_DIR)/webkit',
+ '<(SHARED_INTERMEDIATE_DIR)/webkit/bindings',
],
'mac_framework_dirs': [
'$(SDKROOT)/System/Library/Frameworks/ApplicationServices.framework/Frameworks',
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
