Title: [94251] trunk/Source
- Revision
- 94251
- Author
- [email protected]
- Date
- 2011-08-31 16:55:01 -0700 (Wed, 31 Aug 2011)
Log Message
Source/_javascript_Core: REGRESSION(92210): AVFoundation media engine is disabled on OS X
https://bugs.webkit.org/show_bug.cgi?id=67316
Move the definition of WTF_USE_AVFOUNDATION on the Mac back to _javascript_Core/wtf/Platform.h,
since WebKit2 doesn't have access to WebCore/config.h on this platform. This reverts the
changes that were made in r92210.
Reviewed by Darin Adler.
* wtf/Platform.h: Added definition of WTF_USE_AVFOUNDATION on the Mac.
Source/WebCore: REGRESSION(92210): AVFoundation media engine is disabled on OS X
https://bugs.webkit.org/show_bug.cgi?id=67316
Move the definition of WTF_USE_AVFOUNDATION on the Mac back to _javascript_Core/wtf/Platform.h,
since WebKit2 doesn't have access to WebCore/config.h on this platform. This reverts the
changes that were made in r92210.
Reviewed by Darin Adler.
No new tests, covered by existing media tests.
* config.h: Removed definition of WTF_USE_AVFOUNDATION on the Mac, add a comment about fixing this on Windows in the future.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (94250 => 94251)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-31 23:54:35 UTC (rev 94250)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-31 23:55:01 UTC (rev 94251)
@@ -1,3 +1,16 @@
+2011-08-31 Jeff Miller <[email protected]>
+
+ REGRESSION(92210): AVFoundation media engine is disabled on OS X
+ https://bugs.webkit.org/show_bug.cgi?id=67316
+
+ Move the definition of WTF_USE_AVFOUNDATION on the Mac back to _javascript_Core/wtf/Platform.h,
+ since WebKit2 doesn't have access to WebCore/config.h on this platform. This reverts the
+ changes that were made in r92210.
+
+ Reviewed by Darin Adler.
+
+ * wtf/Platform.h: Added definition of WTF_USE_AVFOUNDATION on the Mac.
+
2011-08-31 Peter Beverloo <[email protected]>
Add Android's platform specification and the right atomic functions.
Modified: trunk/Source/_javascript_Core/wtf/Platform.h (94250 => 94251)
--- trunk/Source/_javascript_Core/wtf/Platform.h 2011-08-31 23:54:35 UTC (rev 94250)
+++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-08-31 23:55:01 UTC (rev 94251)
@@ -1158,4 +1158,8 @@
#endif
#endif
+#if PLATFORM(MAC) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
+#define WTF_USE_AVFOUNDATION 1
+#endif
+
#endif /* WTF_Platform_h */
Modified: trunk/Source/WebCore/ChangeLog (94250 => 94251)
--- trunk/Source/WebCore/ChangeLog 2011-08-31 23:54:35 UTC (rev 94250)
+++ trunk/Source/WebCore/ChangeLog 2011-08-31 23:55:01 UTC (rev 94251)
@@ -1,3 +1,18 @@
+2011-08-31 Jeff Miller <[email protected]>
+
+ REGRESSION(92210): AVFoundation media engine is disabled on OS X
+ https://bugs.webkit.org/show_bug.cgi?id=67316
+
+ Move the definition of WTF_USE_AVFOUNDATION on the Mac back to _javascript_Core/wtf/Platform.h,
+ since WebKit2 doesn't have access to WebCore/config.h on this platform. This reverts the
+ changes that were made in r92210.
+
+ Reviewed by Darin Adler.
+
+ No new tests, covered by existing media tests.
+
+ * config.h: Removed definition of WTF_USE_AVFOUNDATION on the Mac, add a comment about fixing this on Windows in the future.
+
2011-08-31 Sailesh Agrawal <[email protected]>
[Chromium] Switching between overlay and opaque scrollbars causes glitches
Modified: trunk/Source/WebCore/config.h (94250 => 94251)
--- trunk/Source/WebCore/config.h 2011-08-31 23:54:35 UTC (rev 94250)
+++ trunk/Source/WebCore/config.h 2011-08-31 23:55:01 UTC (rev 94251)
@@ -222,10 +222,8 @@
#include <bridge/npruntime_internal.h>
#endif
-#if PLATFORM(MAC) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
-#define WTF_USE_AVFOUNDATION 1
-#endif
-
+// FIXME: Move this to _javascript_Core/wtf/Platform.h, which is where we define WTF_USE_AVFOUNDATION on the Mac.
+// https://bugs.webkit.org/show_bug.cgi?id=67334
#if PLATFORM(WIN) && HAVE(AVCF)
#define WTF_USE_AVFOUNDATION 1
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
