Title: [94308] trunk/Tools
- Revision
- 94308
- Author
- [email protected]
- Date
- 2011-09-01 10:47:00 -0700 (Thu, 01 Sep 2011)
Log Message
Lower the visual noise from the failing builders display
https://bugs.webkit.org/show_bug.cgi?id=67369
Reviewed by Dimitri Glazkov.
This patch ensures that the "Building" row in the failing builders
display is always last and dims it by 50% to reduce visual noise. This
lets the gardener focus on the actual failures.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html (94307 => 94308)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html 2011-09-01 17:39:17 UTC (rev 94307)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html 2011-09-01 17:47:00 UTC (rev 94308)
@@ -28,11 +28,12 @@
-->
<html>
<head>
-<title>Garden-O-Matic Summary View</title>
+<title>Garden-O-Matic</title>
<link rel="stylesheet" href=""
<link rel="stylesheet" href=""
<link rel="stylesheet" href=""
<link rel="stylesheet" href=""
+<link rel="stylesheet" href=""
<link rel="stylesheet" href=""
<link rel="stylesheet" href=""
</head>
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js (94307 => 94308)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js 2011-09-01 17:39:17 UTC (rev 94307)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js 2011-09-01 17:47:00 UTC (rev 94308)
@@ -28,6 +28,8 @@
(function(){
+var kBuildingResult = 'BUILDING';
+
ui.failures.Configuration = base.extends('div', {
init: function(configuration)
{
@@ -71,14 +73,19 @@
titles.insertCell().textContent = 'type';
this._body = this.appendChild(document.createElement('tbody'));
this._resultRows = {};
+ // Add the BUILDING row eagerly so that it appears last.
+ this._rowByResult(kBuildingResult);
+ $(this._resultRows[kBuildingResult]).hide();
},
_rowByResult: function(result)
{
var row = this._resultRows[result];
+ $(row).show();
if (row)
return row;
- row = this._resultRows[result] = this._body.insertRow(-1);
+ row = this._resultRows[result] = this._body.insertRow(0);
+ row.className = result;
row.insertCell();
row.insertCell();
row.insertCell().textContent = result;
Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css (0 => 94308)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css (rev 0)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css 2011-09-01 17:47:00 UTC (rev 94308)
@@ -0,0 +1,28 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+.failures .BUILDING {
+ opacity: 0.5;
+}
Modified: trunk/Tools/ChangeLog (94307 => 94308)
--- trunk/Tools/ChangeLog 2011-09-01 17:39:17 UTC (rev 94307)
+++ trunk/Tools/ChangeLog 2011-09-01 17:47:00 UTC (rev 94308)
@@ -1,3 +1,18 @@
+2011-09-01 Adam Barth <[email protected]>
+
+ Lower the visual noise from the failing builders display
+ https://bugs.webkit.org/show_bug.cgi?id=67369
+
+ Reviewed by Dimitri Glazkov.
+
+ This patch ensures that the "Building" row in the failing builders
+ display is always last and dims it by 50% to reduce visual noise. This
+ lets the gardener focus on the actual failures.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
+
2011-09-01 Kristóf Kosztyó <[email protected]>
[Qt] Build dependency problems
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
