Title: [94324] trunk/Source/WebCore
Revision
94324
Author
[email protected]
Date
2011-09-01 11:44:26 -0700 (Thu, 01 Sep 2011)

Log Message

REGRESSION (r94259): Two tests doing hit testing were broken by this change.
https://bugs.webkit.org/show_bug.cgi?id=67353

Reviewed by Chris Marrin.

Fix a regression from r94259; that change missed a fix in RenderView,
which affects coordinate transforms in position:fixed elements.

This fixes these tests:
    fast/events/document-elementFromPoint.html
    fast/events/offsetX-offsetY.html
    plugins/mouse-events-fixedpos.html

* rendering/RenderView.cpp:
(WebCore::RenderView::mapAbsoluteToLocalPoint):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (94323 => 94324)


--- trunk/Source/WebCore/ChangeLog	2011-09-01 18:41:37 UTC (rev 94323)
+++ trunk/Source/WebCore/ChangeLog	2011-09-01 18:44:26 UTC (rev 94324)
@@ -1,3 +1,21 @@
+2011-09-01  Simon Fraser  <[email protected]>
+
+        REGRESSION (r94259): Two tests doing hit testing were broken by this change.
+        https://bugs.webkit.org/show_bug.cgi?id=67353
+
+        Reviewed by Chris Marrin.
+
+        Fix a regression from r94259; that change missed a fix in RenderView,
+        which affects coordinate transforms in position:fixed elements.
+        
+        This fixes these tests:
+            fast/events/document-elementFromPoint.html
+            fast/events/offsetX-offsetY.html
+            plugins/mouse-events-fixedpos.html
+
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::mapAbsoluteToLocalPoint):
+
 2011-09-01  Tony Gentilcore  <[email protected]>
 
         [chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released

Modified: trunk/Source/WebCore/rendering/RenderView.cpp (94323 => 94324)


--- trunk/Source/WebCore/rendering/RenderView.cpp	2011-09-01 18:41:37 UTC (rev 94323)
+++ trunk/Source/WebCore/rendering/RenderView.cpp	2011-09-01 18:44:26 UTC (rev 94324)
@@ -162,7 +162,7 @@
 void RenderView::mapAbsoluteToLocalPoint(bool fixed, bool useTransforms, TransformState& transformState) const
 {
     if (fixed && m_frameView)
-        transformState.move(-m_frameView->scrollOffsetForFixedPosition());
+        transformState.move(m_frameView->scrollOffsetForFixedPosition());
 
     if (useTransforms && shouldUseTransformFromContainer(0)) {
         TransformationMatrix t;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to