Title: [94333] trunk/Source/WebCore
- Revision
- 94333
- Author
- [email protected]
- Date
- 2011-09-01 12:50:22 -0700 (Thu, 01 Sep 2011)
Log Message
REGRESSION (r93247): 2 http/tests/misc tests failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=67374
Reviewed by Simon Fraser.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::applyBasicAuthorizationHeader):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::applyBasicAuthorizationHeader):
Some versions of CFNetwork carry along an Authorization header, some don't. We shouldn't
repeat its value twice, this is not one of those headers that allow comma separated lists
of values.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (94332 => 94333)
--- trunk/Source/WebCore/ChangeLog 2011-09-01 19:40:17 UTC (rev 94332)
+++ trunk/Source/WebCore/ChangeLog 2011-09-01 19:50:22 UTC (rev 94333)
@@ -1,3 +1,18 @@
+2011-09-01 Alexey Proskuryakov <[email protected]>
+
+ REGRESSION (r93247): 2 http/tests/misc tests failing on SnowLeopard Intel Release (Tests)
+ https://bugs.webkit.org/show_bug.cgi?id=67374
+
+ Reviewed by Simon Fraser.
+
+ * platform/network/cf/ResourceHandleCFNet.cpp:
+ (WebCore::applyBasicAuthorizationHeader):
+ * platform/network/mac/ResourceHandleMac.mm:
+ (WebCore::applyBasicAuthorizationHeader):
+ Some versions of CFNetwork carry along an Authorization header, some don't. We shouldn't
+ repeat its value twice, this is not one of those headers that allow comma separated lists
+ of values.
+
2011-09-01 Noel Gordon <[email protected]>
[chromium] Move ImageBuffer::platformLayer()
Modified: trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp (94332 => 94333)
--- trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp 2011-09-01 19:40:17 UTC (rev 94332)
+++ trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp 2011-09-01 19:50:22 UTC (rev 94333)
@@ -139,6 +139,7 @@
static void applyBasicAuthorizationHeader(ResourceRequest& request, const Credential& credential)
{
String authenticationHeader = "Basic " + base64Encode(String(credential.user() + ":" + credential.password()).utf8());
+ request.clearHTTPAuthorization(); // FIXME: Should addHTTPHeaderField be smart enough to not build comma-separated lists in headers like Authorization?
request.addHTTPHeaderField("Authorization", authenticationHeader);
}
Modified: trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm (94332 => 94333)
--- trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2011-09-01 19:40:17 UTC (rev 94332)
+++ trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2011-09-01 19:50:22 UTC (rev 94333)
@@ -135,6 +135,7 @@
static void applyBasicAuthorizationHeader(ResourceRequest& request, const Credential& credential)
{
String authenticationHeader = "Basic " + base64Encode(String(credential.user() + ":" + credential.password()).utf8());
+ request.clearHTTPAuthorization(); // FIXME: Should addHTTPHeaderField be smart enough to not build comma-separated lists in headers like Authorization?
request.addHTTPHeaderField("Authorization", authenticationHeader);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
