- Revision
- 94378
- Author
- [email protected]
- Date
- 2011-09-01 18:25:03 -0700 (Thu, 01 Sep 2011)
Log Message
[EFL] Remove unused code related with priv->render.process_entire_queue in ewk_tiled_backing_store.
https://bugs.webkit.org/show_bug.cgi?id=63377
priv->render.process_entire_queue affects no logical flow of ewk_tiled_backing_store,
But, ewk_view_tiled_process_entire_queue_set is now provided as setter api for it.
So removal of this api and some codes related with it is required.
Patch by KwangHyuk Kim <[email protected]> on 2011-09-01
Reviewed by Antonio Gomes.
* ewk/ewk_tiled_backing_store.c:
(_ewk_tiled_backing_store_smart_add):
(ewk_tiled_backing_store_enable_render):
* ewk/ewk_tiled_backing_store.h:
* ewk/ewk_view.h:
* ewk/ewk_view_tiled.c:
(ewk_view_tiled_unused_cache_set):
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (94377 => 94378)
--- trunk/Source/WebKit/efl/ChangeLog 2011-09-02 01:00:23 UTC (rev 94377)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-09-02 01:25:03 UTC (rev 94378)
@@ -1,3 +1,22 @@
+2011-09-01 KwangHyuk Kim <[email protected]>
+
+ [EFL] Remove unused code related with priv->render.process_entire_queue in ewk_tiled_backing_store.
+ https://bugs.webkit.org/show_bug.cgi?id=63377
+
+ priv->render.process_entire_queue affects no logical flow of ewk_tiled_backing_store,
+ But, ewk_view_tiled_process_entire_queue_set is now provided as setter api for it.
+ So removal of this api and some codes related with it is required.
+
+ Reviewed by Antonio Gomes.
+
+ * ewk/ewk_tiled_backing_store.c:
+ (_ewk_tiled_backing_store_smart_add):
+ (ewk_tiled_backing_store_enable_render):
+ * ewk/ewk_tiled_backing_store.h:
+ * ewk/ewk_view.h:
+ * ewk/ewk_view_tiled.c:
+ (ewk_view_tiled_unused_cache_set):
+
2011-08-31 Grzegorz Czajkowski <[email protected]>
[EFL] Fonts API refactoring.
Modified: trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.c (94377 => 94378)
--- trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.c 2011-09-02 01:00:23 UTC (rev 94377)
+++ trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.c 2011-09-02 01:25:03 UTC (rev 94378)
@@ -99,7 +99,6 @@
struct {
Eina_Bool (*cb)(void *data, Ewk_Tile *t, const Eina_Rectangle *area);
void *data;
- Eina_Bool process_entire_queue;
Eina_Inlist *pre_render_requests;
Ecore_Idler *idler;
Eina_Bool disabled;
@@ -718,7 +717,6 @@
priv->model.old.rows = 0;
priv->model.width = 0;
priv->model.height = 0;
- priv->render.process_entire_queue = EINA_TRUE;
priv->render.suspend = EINA_FALSE;
priv->cspace = EVAS_COLORSPACE_ARGB8888; // TODO: detect it.
@@ -1918,17 +1916,3 @@
_ewk_tiled_backing_store_changed(priv);
return _ewk_tiled_backing_store_enable_render(priv);
}
-
-/**
- * Set the process_entire_queue flag of the renderer idler.
- *
- *
- * @param o the tiled backing store object
- * @param value EINA_TRUE if we want to process all the request of our queue. EINA_FALSE otherwise.
- */
-void ewk_tiled_backing_store_process_entire_queue_set(Evas_Object *o, Eina_Bool value)
-{
- PRIV_DATA_GET_OR_RETURN(o, priv);
- if (priv->render.process_entire_queue != value)
- priv->render.process_entire_queue = value;
-}
Modified: trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h (94377 => 94378)
--- trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h 2011-09-02 01:00:23 UTC (rev 94377)
+++ trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h 2011-09-02 01:25:03 UTC (rev 94378)
@@ -107,7 +107,6 @@
Eina_Bool ewk_tiled_backing_store_update(Evas_Object *o, const Eina_Rectangle *update);
void ewk_tiled_backing_store_updates_process_pre_set(Evas_Object *o, void *(*cb)(void *data, Evas_Object *o), const void *data);
void ewk_tiled_backing_store_updates_process_post_set(Evas_Object *o, void *(*cb)(void *data, void *pre_data, Evas_Object *o), const void *data);
-void ewk_tiled_backing_store_process_entire_queue_set(Evas_Object *o, Eina_Bool value);
void ewk_tiled_backing_store_updates_process(Evas_Object *o);
void ewk_tiled_backing_store_updates_clear(Evas_Object *o);
void ewk_tiled_backing_store_contents_resize(Evas_Object *o, Evas_Coord width, Evas_Coord height);
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.h (94377 => 94378)
--- trunk/Source/WebKit/efl/ewk/ewk_view.h 2011-09-02 01:00:23 UTC (rev 94377)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.h 2011-09-02 01:25:03 UTC (rev 94378)
@@ -522,16 +522,7 @@
*/
EAPI void ewk_view_tiled_unused_cache_set(Evas_Object *o, Ewk_Tile_Unused_Cache *cache);
-// FIXME: this function should be removed later, when we find the best flag to use.
/**
- * Sets if all the requests of the queue should be processed.
- *
- * @param o the view object
- * @param flag @c EINA_TRUE if all the request of queue should be processed, @c EINA_FALSE if not
- */
-EAPI void ewk_view_tiled_process_entire_queue_set(Evas_Object *o, Eina_Bool flag);
-
-/**
* Sets a fixed layout size to be used, dissociating it from viewport size.
*
* Setting a width different than zero enables fixed layout on that
Modified: trunk/Source/WebKit/efl/ewk/ewk_view_tiled.c (94377 => 94378)
--- trunk/Source/WebKit/efl/ewk/ewk_view_tiled.c 2011-09-02 01:00:23 UTC (rev 94377)
+++ trunk/Source/WebKit/efl/ewk/ewk_view_tiled.c 2011-09-02 01:25:03 UTC (rev 94378)
@@ -285,10 +285,3 @@
EINA_SAFETY_ON_NULL_RETURN(sd);
ewk_tiled_backing_store_tile_unused_cache_set(sd->backing_store, cache);
}
-
-void ewk_view_tiled_process_entire_queue_set(Evas_Object *o, Eina_Bool flag)
-{
- Ewk_View_Smart_Data *sd = ewk_view_smart_data_get(o);
- EINA_SAFETY_ON_NULL_RETURN(sd);
- ewk_tiled_backing_store_process_entire_queue_set(sd->backing_store, flag);
-}
