Title: [94388] trunk/Tools
- Revision
- 94388
- Author
- [email protected]
- Date
- 2011-09-02 00:32:26 -0700 (Fri, 02 Sep 2011)
Log Message
[GTK] run-gtk-tests leaves a zombie Xvfb process
https://bugs.webkit.org/show_bug.cgi?id=67389
Reviewed by Martin Robinson.
* Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
child process instead of doing shell redirection.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (94387 => 94388)
--- trunk/Tools/ChangeLog 2011-09-02 06:33:52 UTC (rev 94387)
+++ trunk/Tools/ChangeLog 2011-09-02 07:32:26 UTC (rev 94388)
@@ -1,3 +1,13 @@
+2011-09-02 Philippe Normand <[email protected]>
+
+ [GTK] run-gtk-tests leaves a zombie Xvfb process
+ https://bugs.webkit.org/show_bug.cgi?id=67389
+
+ Reviewed by Martin Robinson.
+
+ * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
+ child process instead of doing shell redirection.
+
2011-09-01 Mark Rowe <[email protected]>
Fix the build by adding some more missing return types.
Modified: trunk/Tools/Scripts/run-gtk-tests (94387 => 94388)
--- trunk/Tools/Scripts/run-gtk-tests 2011-09-02 06:33:52 UTC (rev 94387)
+++ trunk/Tools/Scripts/run-gtk-tests 2011-09-02 07:32:26 UTC (rev 94388)
@@ -35,7 +35,9 @@
my $pid = fork();
if ($pid == 0) {
- exec("Xvfb :31 -screen 0 800x600x24 -nolisten tcp > /dev/null 2>&1");
+ close(STDOUT) or die "Can't close STDOUT: $!\n";
+ close(STDERR) or die "Can't close STDERR: $!\n";
+ exec("Xvfb :31 -screen 0 800x600x24 -nolisten tcp");
exit 1;
} elsif ($pid == -1) {
print "Failed to fork Xvfb.";
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
