Diff
Modified: trunk/Source/WebCore/ChangeLog (94389 => 94390)
--- trunk/Source/WebCore/ChangeLog 2011-09-02 07:35:13 UTC (rev 94389)
+++ trunk/Source/WebCore/ChangeLog 2011-09-02 07:41:41 UTC (rev 94390)
@@ -1,3 +1,18 @@
+2011-09-02 Kentaro Hara <[email protected]>
+
+ Generate an EventSource constructor of V8 using the IDL 'Constructor' extended attribute
+ https://bugs.webkit.org/show_bug.cgi?id=67459
+
+ Reviewed by Adam Barth.
+
+ Tests: fast/eventsource/eventsource-constructor.html
+ fast/eventsource/eventsource-attribute-listeners.html
+
+ * WebCore.gypi: Removed V8EventSourceConstructor.cpp.
+ * WebCore.pro: Removed V8EventSourceConstructor.cpp.
+ * bindings/v8/custom/V8EventSourceConstructor.cpp: Removed.
+ * page/EventSource.idl: Added the 'Constructor' extended attribute.
+
2011-09-02 Philippe Normand <[email protected]>
[WebAudio] Undeclared dependency to VIDEO
Modified: trunk/Source/WebCore/WebCore.gypi (94389 => 94390)
--- trunk/Source/WebCore/WebCore.gypi 2011-09-02 07:35:13 UTC (rev 94389)
+++ trunk/Source/WebCore/WebCore.gypi 2011-09-02 07:41:41 UTC (rev 94390)
@@ -2148,7 +2148,6 @@
'bindings/v8/custom/V8EntryCustom.cpp',
'bindings/v8/custom/V8EntrySyncCustom.cpp',
'bindings/v8/custom/V8EventCustom.cpp',
- 'bindings/v8/custom/V8EventSourceConstructor.cpp',
'bindings/v8/custom/V8FileReaderCustom.cpp',
'bindings/v8/custom/V8Float32ArrayCustom.cpp',
'bindings/v8/custom/V8Float64ArrayCustom.cpp',
Modified: trunk/Source/WebCore/WebCore.pro (94389 => 94390)
--- trunk/Source/WebCore/WebCore.pro 2011-09-02 07:35:13 UTC (rev 94389)
+++ trunk/Source/WebCore/WebCore.pro 2011-09-02 07:41:41 UTC (rev 94390)
@@ -165,7 +165,6 @@
bindings/v8/custom/V8DocumentLocationCustom.cpp \
bindings/v8/custom/V8ElementCustom.cpp \
bindings/v8/custom/V8EventCustom.cpp \
- bindings/v8/custom/V8EventSourceConstructor.cpp \
bindings/v8/custom/V8FileReaderCustom.cpp \
bindings/v8/custom/V8HTMLAllCollectionCustom.cpp
Deleted: trunk/Source/WebCore/bindings/v8/custom/V8EventSourceConstructor.cpp (94389 => 94390)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventSourceConstructor.cpp 2011-09-02 07:35:13 UTC (rev 94389)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventSourceConstructor.cpp 2011-09-02 07:41:41 UTC (rev 94390)
@@ -1,79 +0,0 @@
-/*
- * Copyright (C) 2010 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-
-#if ENABLE(EVENTSOURCE)
-#include "V8EventSource.h"
-
-#include "EventSource.h"
-#include "Frame.h"
-#include "V8Binding.h"
-#include "V8Proxy.h"
-#include "V8Utilities.h"
-#include "WorkerContext.h"
-#include "WorkerContextExecutionProxy.h"
-
-namespace WebCore {
-
-v8::Handle<v8::Value> V8EventSource::constructorCallback(const v8::Arguments& args)
-{
- INC_STATS("DOM.EventSource.Constructor");
-
- if (!args.IsConstructCall())
- return throwError("DOM object constructor cannot be called as a function.", V8Proxy::TypeError);
-
- // Expect one parameter.
- // Allocate an EventSource object as its internal field.
- ScriptExecutionContext* context = getScriptExecutionContext();
- if (!context)
- return throwError("EventSource constructor's associated context is not available", V8Proxy::ReferenceError);
- if (args.Length() != 1)
- return throwError("Not enough arguments", V8Proxy::TypeError);
-
- ExceptionCode ec = 0;
- String url = ""
-
- RefPtr<EventSource> eventSource = EventSource::create(url, context, ec);
-
- if (ec)
- return throwError(ec);
-
- V8DOMWrapper::setDOMWrapper(args.Holder(), &info, eventSource.get());
-
- // Add object to the wrapper map.
- eventSource->ref();
- V8DOMWrapper::setJSWrapperForActiveDOMObject(eventSource.get(), v8::Persistent<v8::Object>::New(args.Holder()));
- return args.Holder();
-}
-
-} // namespace WebCore
-
-#endif // ENABLE(EVENTSOURCE)
Modified: trunk/Source/WebCore/page/EventSource.idl (94389 => 94390)
--- trunk/Source/WebCore/page/EventSource.idl 2011-09-02 07:35:13 UTC (rev 94389)
+++ trunk/Source/WebCore/page/EventSource.idl 2011-09-02 07:41:41 UTC (rev 94390)
@@ -37,7 +37,10 @@
CanBeConstructed,
CustomConstructFunction,
ConstructorParameters=1,
- V8CustomConstructor,
+ Constructor(in DOMString scriptUrl),
+ ConstructorWith=ScriptExecutionContext,
+ ConstructorRaisesException,
+ V8ConstructorSetsActiveDOMWrapper,
EventTarget,
NoStaticTables
] EventSource {
