Title: [94435] trunk
- Revision
- 94435
- Author
- [email protected]
- Date
- 2011-09-02 11:17:26 -0700 (Fri, 02 Sep 2011)
Log Message
The private browsing state isn't saved when it changes
https://bugs.webkit.org/show_bug.cgi?id=67508
Reviewed by Sam Weinig.
Source/WebKit2:
Store the new private browsing state so subsequent queries for it
will return the right value.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::privateBrowsingStateChanged):
LayoutTests:
Unskip private browsing plug-in tests, since WebKitTestRunner
now has layoutTestController.setPopupBlockingEnabled.
* platform/wk2/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (94434 => 94435)
--- trunk/LayoutTests/ChangeLog 2011-09-02 18:02:44 UTC (rev 94434)
+++ trunk/LayoutTests/ChangeLog 2011-09-02 18:17:26 UTC (rev 94435)
@@ -1,3 +1,15 @@
+2011-09-02 Anders Carlsson <[email protected]>
+
+ The private browsing state isn't saved when it changes
+ https://bugs.webkit.org/show_bug.cgi?id=67508
+
+ Reviewed by Sam Weinig.
+
+ Unskip private browsing plug-in tests, since WebKitTestRunner
+ now has layoutTestController.setPopupBlockingEnabled.
+
+ * platform/wk2/Skipped:
+
2011-09-01 Cary Clark <[email protected]>
Unreviewed; new baselines (Skia on Mac, next chunk of files)
Modified: trunk/LayoutTests/platform/wk2/Skipped (94434 => 94435)
--- trunk/LayoutTests/platform/wk2/Skipped 2011-09-02 18:02:44 UTC (rev 94434)
+++ trunk/LayoutTests/platform/wk2/Skipped 2011-09-02 18:17:26 UTC (rev 94435)
@@ -1568,11 +1568,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=59192
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html
-# WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
-# http://webkit.org/b/59857
-plugins/private-browsing-mode.html
-plugins/private-browsing-mode-2.html
-
# WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
# https://bugs.webkit.org/show_bug.cgi?id=63458
fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html
@@ -1591,7 +1586,7 @@
fast/events/popup-blocking-timers.html
plugins/plugin-initiate-popup-window.html
-# WebKitTestRunner needs an implemenation of allowRoundingHacks
+# WebKitTestRunner needs an implementation of allowRoundingHacks
# http://webkit.org/b/63477
platform/mac/fast/text/rounding-hacks.html
platform/mac/fast/text/rounding-hacks-expansion.html
Modified: trunk/Source/WebKit2/ChangeLog (94434 => 94435)
--- trunk/Source/WebKit2/ChangeLog 2011-09-02 18:02:44 UTC (rev 94434)
+++ trunk/Source/WebKit2/ChangeLog 2011-09-02 18:17:26 UTC (rev 94435)
@@ -1,3 +1,16 @@
+2011-09-02 Anders Carlsson <[email protected]>
+
+ The private browsing state isn't saved when it changes
+ https://bugs.webkit.org/show_bug.cgi?id=67508
+
+ Reviewed by Sam Weinig.
+
+ Store the new private browsing state so subsequent queries for it
+ will return the right value.
+
+ * PluginProcess/PluginControllerProxy.cpp:
+ (WebKit::PluginControllerProxy::privateBrowsingStateChanged):
+
2011-09-02 Ravi Phaneendra Kasibhatla <[email protected]>
[WK2] Anchor elements doesn't get focus on TAB key press.
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (94434 => 94435)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-09-02 18:02:44 UTC (rev 94434)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-09-02 18:17:26 UTC (rev 94435)
@@ -573,6 +573,8 @@
void PluginControllerProxy::privateBrowsingStateChanged(bool isPrivateBrowsingEnabled)
{
+ m_isPrivateBrowsingEnabled = isPrivateBrowsingEnabled;
+
m_plugin->privateBrowsingStateChanged(isPrivateBrowsingEnabled);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
