Title: [94438] trunk/Source/WebKit2
- Revision
- 94438
- Author
- [email protected]
- Date
- 2011-09-02 12:19:41 -0700 (Fri, 02 Sep 2011)
Log Message
Assertion/crash when running netscape-plugin-property-access-exception.html test
https://bugs.webkit.org/show_bug.cgi?id=67517
Reviewed by Adam Roben.
Make sure to initialize the NPVariant in case the plug-in returns true from NP_GetProperty,
but doesn't set the result NPVariant to anything.
* Shared/Plugins/NPObjectMessageReceiver.cpp:
(WebKit::NPObjectMessageReceiver::getProperty):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (94437 => 94438)
--- trunk/Source/WebKit2/ChangeLog 2011-09-02 18:55:16 UTC (rev 94437)
+++ trunk/Source/WebKit2/ChangeLog 2011-09-02 19:19:41 UTC (rev 94438)
@@ -1,5 +1,18 @@
2011-09-02 Anders Carlsson <[email protected]>
+ Assertion/crash when running netscape-plugin-property-access-exception.html test
+ https://bugs.webkit.org/show_bug.cgi?id=67517
+
+ Reviewed by Adam Roben.
+
+ Make sure to initialize the NPVariant in case the plug-in returns true from NP_GetProperty,
+ but doesn't set the result NPVariant to anything.
+
+ * Shared/Plugins/NPObjectMessageReceiver.cpp:
+ (WebKit::NPObjectMessageReceiver::getProperty):
+
+2011-09-02 Anders Carlsson <[email protected]>
+
The private browsing state isn't saved when it changes
https://bugs.webkit.org/show_bug.cgi?id=67508
Modified: trunk/Source/WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp (94437 => 94438)
--- trunk/Source/WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp 2011-09-02 18:55:16 UTC (rev 94437)
+++ trunk/Source/WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp 2011-09-02 19:19:41 UTC (rev 94438)
@@ -145,6 +145,8 @@
}
NPVariant result;
+ VOID_TO_NPVARIANT(result);
+
returnValue = m_npObject->_class->getProperty(m_npObject, propertyNameData.createNPIdentifier(), &result);
if (!returnValue)
return;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
