Title: [94446] trunk/LayoutTests
- Revision
- 94446
- Author
- [email protected]
- Date
- 2011-09-02 13:48:32 -0700 (Fri, 02 Sep 2011)
Log Message
Some media layout tests fail because of ambiguous ordering of canplaythough event.
https://bugs.webkit.org/show_bug.cgi?id=67520
Reviewed by Eric Carlson.
The "canplaythrough" event can occur either before or after the "playing" event, causing layout tests
to fail for certain media engines (AVFoundation). The "canplaythrough" event check isn't adding anything
of value which isn't covered in other layout tests, so remove this event check.
* media/audio-play-event-expected.txt:
* media/audio-play-event.html:
* media/video-play-empty-events-expected.txt:
* media/video-play-empty-events.html:
* media/video-timeupdate-during-playback-expected.txt:
* media/video-timeupdate-during-playback.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (94445 => 94446)
--- trunk/LayoutTests/ChangeLog 2011-09-02 20:41:59 UTC (rev 94445)
+++ trunk/LayoutTests/ChangeLog 2011-09-02 20:48:32 UTC (rev 94446)
@@ -1,3 +1,21 @@
+2011-09-02 Jer Noble <[email protected]>
+
+ Some media layout tests fail because of ambiguous ordering of canplaythough event.
+ https://bugs.webkit.org/show_bug.cgi?id=67520
+
+ Reviewed by Eric Carlson.
+
+ The "canplaythrough" event can occur either before or after the "playing" event, causing layout tests
+ to fail for certain media engines (AVFoundation). The "canplaythrough" event check isn't adding anything
+ of value which isn't covered in other layout tests, so remove this event check.
+
+ * media/audio-play-event-expected.txt:
+ * media/audio-play-event.html:
+ * media/video-play-empty-events-expected.txt:
+ * media/video-play-empty-events.html:
+ * media/video-timeupdate-during-playback-expected.txt:
+ * media/video-timeupdate-during-playback.html:
+
2011-09-02 James Robinson <[email protected]>
[chromium] Update expectations for tests with animations and reflections
Modified: trunk/LayoutTests/media/audio-play-event-expected.txt (94445 => 94446)
--- trunk/LayoutTests/media/audio-play-event-expected.txt 2011-09-02 20:41:59 UTC (rev 94445)
+++ trunk/LayoutTests/media/audio-play-event-expected.txt 2011-09-02 20:48:32 UTC (rev 94446)
@@ -6,7 +6,6 @@
EVENT(play)
EVENT(loadedmetadata)
EVENT(canplay)
-EVENT(canplaythrough)
EVENT(playing)
END OF TEST
Modified: trunk/LayoutTests/media/audio-play-event.html (94445 => 94446)
--- trunk/LayoutTests/media/audio-play-event.html 2011-09-02 20:41:59 UTC (rev 94445)
+++ trunk/LayoutTests/media/audio-play-event.html 2011-09-02 20:48:32 UTC (rev 94446)
@@ -11,7 +11,6 @@
waitForEvent('error');
waitForEvent('loadedmetadata');
waitForEvent('canplay');
- waitForEvent('canplaythrough');
waitForEvent('play');
waitForEvent('playing', function() { endTest(); });
run("mediaElement.src = "" 'content/test')");
Modified: trunk/LayoutTests/media/video-play-empty-events-expected.txt (94445 => 94446)
--- trunk/LayoutTests/media/video-play-empty-events-expected.txt 2011-09-02 20:41:59 UTC (rev 94445)
+++ trunk/LayoutTests/media/video-play-empty-events-expected.txt 2011-09-02 20:48:32 UTC (rev 94446)
@@ -10,7 +10,6 @@
EVENT(loadedmetadata)
EVENT(loadeddata)
EVENT(canplay)
-EVENT(canplaythrough)
EVENT(playing)
EXPECTED (video.paused == 'false') OK
END OF TEST
Modified: trunk/LayoutTests/media/video-play-empty-events.html (94445 => 94446)
--- trunk/LayoutTests/media/video-play-empty-events.html 2011-09-02 20:41:59 UTC (rev 94445)
+++ trunk/LayoutTests/media/video-play-empty-events.html 2011-09-02 20:48:32 UTC (rev 94446)
@@ -16,7 +16,6 @@
waitForEvent("loadedmetadata");
waitForEvent("loadeddata");
waitForEvent("canplay");
- waitForEvent("canplaythrough");
waitForEvent("play");
waitForEvent('playing', function () { testExpected("video.paused", false); endTest(); } );
Modified: trunk/LayoutTests/media/video-timeupdate-during-playback-expected.txt (94445 => 94446)
--- trunk/LayoutTests/media/video-timeupdate-during-playback-expected.txt 2011-09-02 20:41:59 UTC (rev 94445)
+++ trunk/LayoutTests/media/video-timeupdate-during-playback-expected.txt 2011-09-02 20:48:32 UTC (rev 94446)
@@ -9,7 +9,6 @@
EVENT(loadedmetadata)
EVENT(loadeddata)
EVENT(canplay)
-EVENT(canplaythrough)
EVENT(playing)
RUN(video.pause())
Modified: trunk/LayoutTests/media/video-timeupdate-during-playback.html (94445 => 94446)
--- trunk/LayoutTests/media/video-timeupdate-during-playback.html 2011-09-02 20:41:59 UTC (rev 94445)
+++ trunk/LayoutTests/media/video-timeupdate-during-playback.html 2011-09-02 20:48:32 UTC (rev 94446)
@@ -44,7 +44,6 @@
waitForEvent("loadedmetadata");
waitForEvent("loadeddata");
waitForEvent("canplay");
- waitForEvent("canplaythrough");
waitForEvent("pause", pause);
waitForEvent("play");
waitForEvent("playing", playing);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
