Title: [94485] trunk/Tools
- Revision
- 94485
- Author
- [email protected]
- Date
- 2011-09-03 01:25:33 -0700 (Sat, 03 Sep 2011)
Log Message
garden-o-matic shows "ghost" failures that are already fixed
https://bugs.webkit.org/show_bug.cgi?id=67535
Reviewed by Eric Seidel.
About 10% of writes fail to stick on test-results.appspot.com. This
patch causes us to fetch the full_results.json blob directly from
build.chromium.org rather than relying upon AppEngine.
Unforuntately, we still need to get historical information from
AppEngine. That will take several patches to fix becuase I need to
change the bots to write the full_results.json file to the
build-specific directory in addition to the zip file.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js (94484 => 94485)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js 2011-09-03 07:49:15 UTC (rev 94484)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js 2011-09-03 08:25:33 UTC (rev 94485)
@@ -124,6 +124,13 @@
return filteredTree;
};
+base.parseJSONP = function(jsonp)
+{
+ var startIndex = jsonp.indexOf('(') + 1;
+ var endIndex = jsonp.lastIndexOf(')');
+ return JSON.parse(jsonp.substr(startIndex, endIndex - startIndex));
+}
+
base.RequestTracker = function(requestsInFlight, callback, args)
{
this._requestsInFlight = requestsInFlight;
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js (94484 => 94485)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js 2011-09-03 07:49:15 UTC (rev 94484)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js 2011-09-03 08:25:33 UTC (rev 94485)
@@ -115,9 +115,6 @@
});
}
-/*
- Assumes SVN-style, consecutive revision scheme.
-*/
model.commitDataListForRevisionRange = function(fromRevision, toRevision)
{
var result = [];
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js (94484 => 94485)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js 2011-09-03 07:49:15 UTC (rev 94484)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js 2011-09-03 08:25:33 UTC (rev 94485)
@@ -30,11 +30,11 @@
var kTestResultsServer = 'http://test-results.appspot.com/';
var kTestResultsQuery = kTestResultsServer + 'testfile?'
var kTestType = 'layout-tests';
-var kResultsName = 'full_results.json';
var kMasterName = 'ChromiumWebkit';
var kLayoutTestResultsServer = 'http://build.chromium.org/f/chromium/layout_test_results/';
var kLayoutTestResultsPath = '/results/layout-test-results/';
+var kResultsName = 'full_results.json';
var PASS = 'PASS';
var TIMEOUT = 'TIMEOUT';
@@ -175,9 +175,9 @@
});
};
-function resultsSummaryURL(builderName, testName)
+function resultsSummaryURL(builderName, resultsName)
{
- return kTestResultsQuery + $.param(resultsParameters(builderName, testName));
+ return resultsDirectoryURL(builderName) + resultsName;
}
function directoryOfResultsSummaryURL(builderName, testName)
@@ -536,8 +536,8 @@
results.fetchResultsForBuilder = function(builderName, callback)
{
- net.jsonp(resultsSummaryURL(builderName, kResultsName), function(resultsTree) {
- callback(resultsTree);
+ net.get(resultsSummaryURL(builderName, kResultsName), function(jsonp) {
+ callback(base.parseJSONP(jsonp));
});
};
Modified: trunk/Tools/ChangeLog (94484 => 94485)
--- trunk/Tools/ChangeLog 2011-09-03 07:49:15 UTC (rev 94484)
+++ trunk/Tools/ChangeLog 2011-09-03 08:25:33 UTC (rev 94485)
@@ -1,3 +1,23 @@
+2011-09-03 Adam Barth <[email protected]>
+
+ garden-o-matic shows "ghost" failures that are already fixed
+ https://bugs.webkit.org/show_bug.cgi?id=67535
+
+ Reviewed by Eric Seidel.
+
+ About 10% of writes fail to stick on test-results.appspot.com. This
+ patch causes us to fetch the full_results.json blob directly from
+ build.chromium.org rather than relying upon AppEngine.
+
+ Unforuntately, we still need to get historical information from
+ AppEngine. That will take several patches to fix becuase I need to
+ change the bots to write the full_results.json file to the
+ build-specific directory in addition to the zip file.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
+
2011-09-03 Sheriff Bot <[email protected]>
Unreviewed, rolling out r94458.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
