Title: [94491] trunk/Source/WebCore
- Revision
- 94491
- Author
- [email protected]
- Date
- 2011-09-03 11:18:04 -0700 (Sat, 03 Sep 2011)
Log Message
Remove two unused functions from Element.
https://bugs.webkit.org/show_bug.cgi?id=67492
Reviewed by Benjamin Poulain.
Removed openTagStartToString() and setCStringAttribute() as they are
not called from anywhere.
* dom/Element.cpp:
* dom/Element.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (94490 => 94491)
--- trunk/Source/WebCore/ChangeLog 2011-09-03 17:13:58 UTC (rev 94490)
+++ trunk/Source/WebCore/ChangeLog 2011-09-03 18:18:04 UTC (rev 94491)
@@ -1,3 +1,16 @@
+2011-09-03 Andreas Kling <[email protected]>
+
+ Remove two unused functions from Element.
+ https://bugs.webkit.org/show_bug.cgi?id=67492
+
+ Reviewed by Benjamin Poulain.
+
+ Removed openTagStartToString() and setCStringAttribute() as they are
+ not called from anywhere.
+
+ * dom/Element.cpp:
+ * dom/Element.h:
+
2011-09-03 Andrew Wason <[email protected]>
[Qt] Enable support for WebGL OES_standard_derivatives for Qt
Modified: trunk/Source/WebCore/dom/Element.cpp (94490 => 94491)
--- trunk/Source/WebCore/dom/Element.cpp 2011-09-03 17:13:58 UTC (rev 94490)
+++ trunk/Source/WebCore/dom/Element.cpp 2011-09-03 18:18:04 UTC (rev 94491)
@@ -235,12 +235,6 @@
ExceptionCode ec;
setAttribute(name, value, ec);
}
-
-void Element::setCStringAttribute(const QualifiedName& name, const char* cStringValue)
-{
- ExceptionCode ec;
- setAttribute(name, AtomicString(cStringValue), ec);
-}
void Element::setBooleanAttribute(const QualifiedName& name, bool b)
{
@@ -1460,31 +1454,6 @@
#endif
}
-String Element::openTagStartToString() const
-{
- String result = "<" + nodeName();
-
- NamedNodeMap* attrMap = attributes(true);
-
- if (attrMap) {
- unsigned numAttrs = attrMap->length();
- for (unsigned i = 0; i < numAttrs; i++) {
- result += " ";
-
- Attribute *attribute = attrMap->attributeItem(i);
- result += attribute->name().toString();
- if (!attribute->value().isNull()) {
- result += "=\"";
- // FIXME: substitute entities for any instances of " or '
- result += attribute->value();
- result += "\"";
- }
- }
- }
-
- return result;
-}
-
#ifndef NDEBUG
void Element::formatForDebugger(char* buffer, unsigned length) const
{
Modified: trunk/Source/WebCore/dom/Element.h (94490 => 94491)
--- trunk/Source/WebCore/dom/Element.h 2011-09-03 17:13:58 UTC (rev 94490)
+++ trunk/Source/WebCore/dom/Element.h 2011-09-03 18:18:04 UTC (rev 94491)
@@ -212,9 +212,6 @@
// convenience methods which ignore exceptions
void setAttribute(const QualifiedName&, const AtomicString& value);
void setBooleanAttribute(const QualifiedName& name, bool);
- // Please don't use setCStringAttribute in performance-sensitive code;
- // use a static AtomicString value instead to avoid the conversion overhead.
- void setCStringAttribute(const QualifiedName&, const char* cStringValue);
NamedNodeMap* attributes(bool readonly = false) const;
@@ -268,8 +265,6 @@
virtual String title() const;
- String openTagStartToString() const;
-
void updateId(const AtomicString& oldId, const AtomicString& newId);
LayoutSize minimumSizeForResizing() const;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
