Title: [94514] trunk/Source/_javascript_Core
- Revision
- 94514
- Author
- [email protected]
- Date
- 2011-09-04 23:48:18 -0700 (Sun, 04 Sep 2011)
Log Message
REGRESSION (r94452): 20 http/tests tests failing on Qt Linux Release
https://bugs.webkit.org/show_bug.cgi?id=67562
Patch by Mark Hahnenberg <[email protected]> on 2011-09-04
Reviewed by Darin Adler.
Fixing the build (again which was broken by the dtoa patch. Needed
to make sure WTF::double_conversion::initialize() is called for Qt
as well as adding a check for WinCE in dtoa/utils.h
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* wtf/dtoa/cached-powers.cc:
* wtf/dtoa/utils.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (94513 => 94514)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-05 06:43:32 UTC (rev 94513)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-05 06:48:18 UTC (rev 94514)
@@ -1,3 +1,19 @@
+2011-09-04 Mark Hahnenberg <[email protected]>
+
+ REGRESSION (r94452): 20 http/tests tests failing on Qt Linux Release
+ https://bugs.webkit.org/show_bug.cgi?id=67562
+
+ Reviewed by Darin Adler.
+
+ Fixing the build (again which was broken by the dtoa patch. Needed
+ to make sure WTF::double_conversion::initialize() is called for Qt
+ as well as adding a check for WinCE in dtoa/utils.h
+
+ * runtime/InitializeThreading.cpp:
+ (JSC::initializeThreadingOnce):
+ * wtf/dtoa/cached-powers.cc:
+ * wtf/dtoa/utils.h:
+
2011-09-03 Filip Pizlo <[email protected]>
ThunkGenerators does not convert positive double zero into integer zero
Modified: trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp (94513 => 94514)
--- trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp 2011-09-05 06:43:32 UTC (rev 94513)
+++ trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp 2011-09-05 06:48:18 UTC (rev 94514)
@@ -36,6 +36,7 @@
#include "WriteBarrier.h"
#include <wtf/DateMath.h>
#include <wtf/Threading.h>
+#include <wtf/dtoa/cached-powers.h>
using namespace WTF;
@@ -47,6 +48,7 @@
static void initializeThreadingOnce()
{
+ WTF::double_conversion::initialize();
WTF::initializeThreading();
#if ENABLE(WRITE_BARRIER_PROFILING)
WriteBarrierCounters::initialize();
Modified: trunk/Source/_javascript_Core/wtf/dtoa/cached-powers.cc (94513 => 94514)
--- trunk/Source/_javascript_Core/wtf/dtoa/cached-powers.cc 2011-09-05 06:43:32 UTC (rev 94513)
+++ trunk/Source/_javascript_Core/wtf/dtoa/cached-powers.cc 2011-09-05 06:48:18 UTC (rev 94514)
@@ -53,6 +53,8 @@
int PowersOfTenCache::kMaxDecimalExponent = 1;
void initialize() {
+ if (kCachedPowers)
+ return;
static CachedPower cachedPowers[] = {
{UINT64_2PART_C(0xfa8fd5a0, 081c0288), -1220, -348},
{UINT64_2PART_C(0xbaaee17f, a23ebf76), -1193, -340},
Modified: trunk/Source/_javascript_Core/wtf/dtoa/utils.h (94513 => 94514)
--- trunk/Source/_javascript_Core/wtf/dtoa/utils.h 2011-09-05 06:43:32 UTC (rev 94513)
+++ trunk/Source/_javascript_Core/wtf/dtoa/utils.h 2011-09-05 06:48:18 UTC (rev 94514)
@@ -53,7 +53,7 @@
defined(__ARMEL__) || \
defined(_MIPS_ARCH_MIPS32R2)
#define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1
-#elif CPU(MIPS)
+#elif CPU(MIPS) || OS(WINCE)
#define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1
#elif defined(_M_IX86) || defined(__i386__)
#if defined(_WIN32)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes