Title: [94539] trunk/Tools
- Revision
- 94539
- Author
- [email protected]
- Date
- 2011-09-05 15:58:10 -0700 (Mon, 05 Sep 2011)
Log Message
Fix global variable leak in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=67617
Reviewed by Dimitri Glazkov.
Caught by running the unit tests with noglobals turned on.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js (94538 => 94539)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2011-09-05 21:07:50 UTC (rev 94538)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2011-09-05 22:58:10 UTC (rev 94539)
@@ -246,7 +246,7 @@
this._body = this.appendChild(document.createElement('tbody'));
testNameList.forEach(function(testName) {
- row = this._body.insertRow();
+ var row = this._body.insertRow();
for (var i = builderNameList.length - 1; i >= 0; --i) {
var cell = row.insertCell();
var builderName = builderNameList[i];
Modified: trunk/Tools/ChangeLog (94538 => 94539)
--- trunk/Tools/ChangeLog 2011-09-05 21:07:50 UTC (rev 94538)
+++ trunk/Tools/ChangeLog 2011-09-05 22:58:10 UTC (rev 94539)
@@ -1,3 +1,14 @@
+2011-09-05 Adam Barth <[email protected]>
+
+ Fix global variable leak in garden-o-matic
+ https://bugs.webkit.org/show_bug.cgi?id=67617
+
+ Reviewed by Dimitri Glazkov.
+
+ Caught by running the unit tests with noglobals turned on.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
+
2011-09-05 Balazs Kelemen <[email protected]>
[Qt][WK2] Add pixel test support
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes