Title: [94579] trunk/Tools
- Revision
- 94579
- Author
- [email protected]
- Date
- 2011-09-06 11:00:25 -0700 (Tue, 06 Sep 2011)
Log Message
garden-o-matic's base.probe generates spam in the _javascript_ console
https://bugs.webkit.org/show_bug.cgi?id=67622
Reviewed by Dimitri Glazkov.
Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
instead of HTMLScriptElement to test whether results exist. This
reduces the console.log spam and saves bandwidth because we can use a
HEAD request instead of a GET request.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js (94578 => 94579)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js 2011-09-06 17:49:41 UTC (rev 94578)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js 2011-09-06 18:00:25 UTC (rev 94579)
@@ -33,19 +33,18 @@
net.probe = function(url, options)
{
- var scriptElement = document.createElement('script');
- scriptElement.addEventListener('load', function() {
- $(scriptElement).detach();
- if (options.success)
- options.success.call();
- }, false);
- scriptElement.addEventListener('error', function() {
- $(scriptElement).detach();
- if (options.error)
- options.error.call();
- }, false);
- scriptElement.src = ""
- document.head.appendChild(scriptElement);
+ $.ajax({
+ url: url,
+ type: 'HEAD',
+ success: function() {
+ if (options.success)
+ options.success.call();
+ },
+ error: function() {
+ if (options.error)
+ options.error.call();
+ },
+ });
};
// jQuery makes jsonp requests somewhat ugly (which is fair given that they're
Modified: trunk/Tools/ChangeLog (94578 => 94579)
--- trunk/Tools/ChangeLog 2011-09-06 17:49:41 UTC (rev 94578)
+++ trunk/Tools/ChangeLog 2011-09-06 18:00:25 UTC (rev 94579)
@@ -1,3 +1,17 @@
+2011-09-06 Adam Barth <[email protected]>
+
+ garden-o-matic's base.probe generates spam in the _javascript_ console
+ https://bugs.webkit.org/show_bug.cgi?id=67622
+
+ Reviewed by Dimitri Glazkov.
+
+ Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
+ instead of HTMLScriptElement to test whether results exist. This
+ reduces the console.log spam and saves bandwidth because we can use a
+ HEAD request instead of a GET request.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
+
2011-09-05 Adam Barth <[email protected]>
Add a tab to garden-o-matic for viewing expected failures
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
