Title: [94724] trunk/LayoutTests
Revision
94724
Author
[email protected]
Date
2011-09-07 16:16:08 -0700 (Wed, 07 Sep 2011)

Log Message

css2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
https://bugs.webkit.org/show_bug.cgi?id=67725

Reviewed by Dan Bernstein.

Revert the script fix in t090204-display-change-01-b-ao.html and css2.1 test suite and
replace line-after-floating-div.html by the fixed version.
        
Also move the expected result for line-after-floating-div.html from fast/css as it is platform dependent.

* css2.1/t090204-display-change-01-b-ao.html:
* fast/css/line-after-floating-div-expected.png: Removed.
* fast/css/line-after-floating-div-expected.txt: Removed.
* fast/css/line-after-floating-div.html:
* platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png:
* platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt:
* platform/mac/fast/css/line-after-floating-div-expected.png: Copied from
LayoutTests/fast/css/line-after-floating-div-expected.png.
* platform/mac/fast/css/line-after-floating-div-expected.txt: Copied from
LayoutTests/fast/css/line-after-floating-div-expected.txt.

Modified Paths

Added Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (94723 => 94724)


--- trunk/LayoutTests/ChangeLog	2011-09-07 23:10:21 UTC (rev 94723)
+++ trunk/LayoutTests/ChangeLog	2011-09-07 23:16:08 UTC (rev 94724)
@@ -1,3 +1,26 @@
+2011-09-07  Ryosuke Niwa  <[email protected]>
+
+        css2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
+        https://bugs.webkit.org/show_bug.cgi?id=67725
+
+        Reviewed by Dan Bernstein.
+
+        Revert the script fix in t090204-display-change-01-b-ao.html and css2.1 test suite and
+        replace line-after-floating-div.html by the fixed version.
+        
+        Also move the expected result for line-after-floating-div.html from fast/css as it is platform dependent.
+
+        * css2.1/t090204-display-change-01-b-ao.html:
+        * fast/css/line-after-floating-div-expected.png: Removed.
+        * fast/css/line-after-floating-div-expected.txt: Removed.
+        * fast/css/line-after-floating-div.html:
+        * platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png:
+        * platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt:
+        * platform/mac/fast/css/line-after-floating-div-expected.png: Copied from
+        LayoutTests/fast/css/line-after-floating-div-expected.png.
+        * platform/mac/fast/css/line-after-floating-div-expected.txt: Copied from
+        LayoutTests/fast/css/line-after-floating-div-expected.txt.
+
 2011-09-07  Tim Horton  <[email protected]>
 
         Unreviewed, Chromium baselines for svg/custom/simple-text-double-shadow

Modified: trunk/LayoutTests/css2.1/t090204-display-change-01-b-ao.html (94723 => 94724)


--- trunk/LayoutTests/css2.1/t090204-display-change-01-b-ao.html	2011-09-07 23:10:21 UTC (rev 94723)
+++ trunk/LayoutTests/css2.1/t090204-display-change-01-b-ao.html	2011-09-07 23:16:08 UTC (rev 94724)
@@ -7,7 +7,7 @@
       function test() {
         document.getElementById('float').style.display = 'none';
       }
-      window.addEventListener("load", test, false);
+      document.addEventListener("load", test, false);
     </script>
     <style>
       #float { width: 100%; float:left; }

Deleted: trunk/LayoutTests/fast/css/line-after-floating-div-expected.png


(Binary files differ)

Deleted: trunk/LayoutTests/fast/css/line-after-floating-div-expected.txt (94723 => 94724)


--- trunk/LayoutTests/fast/css/line-after-floating-div-expected.txt	2011-09-07 23:10:21 UTC (rev 94723)
+++ trunk/LayoutTests/fast/css/line-after-floating-div-expected.txt	2011-09-07 23:16:08 UTC (rev 94724)
@@ -1,14 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x106
-  RenderBlock {HTML} at (0,0) size 800x106
-    RenderBody {BODY} at (8,16) size 784x82
-      RenderBlock {P} at (0,0) size 784x18
-        RenderText {#text} at (0,0) size 268x18
-          text run at (0,0) width 268: "There should be no red below, only green."
-      RenderBlock (floating) {DIV} at (0,34) size 784x16 [color=#008000] [bgcolor=#FF0000]
-        RenderText {#text} at (0,0) size 16x16
-          text run at (0,0) width 16: "X"
-      RenderBlock {DIV} at (0,34) size 16x48 [color=#008000] [bgcolor=#FF0000]
-        RenderText {#text} at (0,16) size 16x16
-          text run at (0,16) width 16: "X"

Modified: trunk/LayoutTests/fast/css/line-after-floating-div.html (94723 => 94724)


--- trunk/LayoutTests/fast/css/line-after-floating-div.html	2011-09-07 23:10:21 UTC (rev 94723)
+++ trunk/LayoutTests/fast/css/line-after-floating-div.html	2011-09-07 23:16:08 UTC (rev 94724)
@@ -3,6 +3,12 @@
   <head>
     <title>CSS 2.1 Test Suite: Updating layout on display changes</title>
     <link rel="help" href=""
+    <script type="text/_javascript_">
+      function test() {
+        document.getElementById('float').style.display = 'none';
+      }
+      window.addEventListener("load", test, false);
+    </script>
     <style>
       #float { width: 100%; float:left; }
       div { background: red; color: green; width: 1em; font-family: Ahem; }

Modified: trunk/LayoutTests/platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt (94723 => 94724)


--- trunk/LayoutTests/platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt	2011-09-07 23:10:21 UTC (rev 94723)
+++ trunk/LayoutTests/platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt	2011-09-07 23:16:08 UTC (rev 94724)
@@ -1,11 +1,14 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x74
-  RenderBlock {HTML} at (0,0) size 800x74
-    RenderBody {BODY} at (8,16) size 784x50
+layer at (0,0) size 800x90
+  RenderBlock {HTML} at (0,0) size 800x90
+    RenderBody {BODY} at (8,16) size 784x66
       RenderBlock {P} at (0,0) size 784x18
         RenderText {#text} at (0,0) size 268x18
           text run at (0,0) width 268: "There should be no red below, only green."
-      RenderBlock {DIV} at (0,34) size 16x16 [color=#008000] [bgcolor=#FF0000]
+      RenderBlock (floating) {DIV} at (0,34) size 784x16 [color=#008000] [bgcolor=#FF0000]
         RenderText {#text} at (0,0) size 16x16
           text run at (0,0) width 16: "X"
+      RenderBlock {DIV} at (0,34) size 16x32 [color=#008000] [bgcolor=#FF0000]
+        RenderText {#text} at (0,16) size 16x16
+          text run at (0,16) width 16: "X"

Copied: trunk/LayoutTests/platform/mac/fast/css/line-after-floating-div-expected.png (from rev 94719, trunk/LayoutTests/fast/css/line-after-floating-div-expected.png)


(Binary files differ)

Copied: trunk/LayoutTests/platform/mac/fast/css/line-after-floating-div-expected.txt (from rev 94719, trunk/LayoutTests/fast/css/line-after-floating-div-expected.txt) (0 => 94724)


--- trunk/LayoutTests/platform/mac/fast/css/line-after-floating-div-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/css/line-after-floating-div-expected.txt	2011-09-07 23:16:08 UTC (rev 94724)
@@ -0,0 +1,11 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x74
+  RenderBlock {HTML} at (0,0) size 800x74
+    RenderBody {BODY} at (8,16) size 784x50
+      RenderBlock {P} at (0,0) size 784x18
+        RenderText {#text} at (0,0) size 268x18
+          text run at (0,0) width 268: "There should be no red below, only green."
+      RenderBlock {DIV} at (0,34) size 16x16 [color=#008000] [bgcolor=#FF0000]
+        RenderText {#text} at (0,0) size 16x16
+          text run at (0,0) width 16: "X"
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to