Title: [94765] trunk/LayoutTests
- Revision
- 94765
- Author
- a...@apple.com
- Date
- 2011-09-08 10:18:32 -0700 (Thu, 08 Sep 2011)
Log Message
Some cookie related tests fail on Lion
https://bugs.webkit.org/show_bug.cgi?id=67674
Reviewed by Mark Rowe.
Use private browsing mode to work around a CFNetwork issue where these tests can affect each
other's results. This should not affect their behavior in any other way.
* http/tests/security/cookies/third-party-cookie-blocking-main-frame.html:
* http/tests/security/cookies/third-party-cookie-blocking-user-action.html:
* http/tests/security/cookies/third-party-cookie-blocking.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (94764 => 94765)
--- trunk/LayoutTests/ChangeLog 2011-09-08 17:09:31 UTC (rev 94764)
+++ trunk/LayoutTests/ChangeLog 2011-09-08 17:18:32 UTC (rev 94765)
@@ -1,3 +1,17 @@
+2011-09-08 Alexey Proskuryakov <a...@apple.com>
+
+ Some cookie related tests fail on Lion
+ https://bugs.webkit.org/show_bug.cgi?id=67674
+
+ Reviewed by Mark Rowe.
+
+ Use private browsing mode to work around a CFNetwork issue where these tests can affect each
+ other's results. This should not affect their behavior in any other way.
+
+ * http/tests/security/cookies/third-party-cookie-blocking-main-frame.html:
+ * http/tests/security/cookies/third-party-cookie-blocking-user-action.html:
+ * http/tests/security/cookies/third-party-cookie-blocking.html:
+
2011-09-08 Ryosuke Niwa <rn...@webkit.org>
Rebaseline filters-image-05-f.svg expected output (text) for SnowLeopard.
Modified: trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-main-frame.html (94764 => 94765)
--- trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-main-frame.html 2011-09-08 17:09:31 UTC (rev 94764)
+++ trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-main-frame.html 2011-09-08 17:18:32 UTC (rev 94765)
@@ -6,6 +6,12 @@
layoutTestController.waitUntilDone();
layoutTestController.dumpAsText();
layoutTestController.dumpChildFramesAsText();
+
+ // Start with a clean state, as otherwise an expired cookie for this domain could affect behavior with CFNetwork.
+ // Can be removed once <rdar://problem/10080130> is fixed.
+ if (layoutTestController.setPrivateBrowsingEnabled)
+ layoutTestController.setPrivateBrowsingEnabled(true);
+
layoutTestController.setAlwaysAcceptCookies(false);
}
Modified: trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-user-action.html (94764 => 94765)
--- trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-user-action.html 2011-09-08 17:09:31 UTC (rev 94764)
+++ trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking-user-action.html 2011-09-08 17:18:32 UTC (rev 94765)
@@ -6,6 +6,12 @@
layoutTestController.waitUntilDone();
layoutTestController.dumpAsText();
layoutTestController.dumpChildFramesAsText();
+
+ // Start with a clean state, as otherwise an expired cookie for this domain could affect behavior with CFNetwork.
+ // Can be removed once <rdar://problem/10080130> is fixed.
+ if (layoutTestController.setPrivateBrowsingEnabled)
+ layoutTestController.setPrivateBrowsingEnabled(true);
+
layoutTestController.setAlwaysAcceptCookies(false);
}
Modified: trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking.html (94764 => 94765)
--- trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking.html 2011-09-08 17:09:31 UTC (rev 94764)
+++ trunk/LayoutTests/http/tests/security/cookies/third-party-cookie-blocking.html 2011-09-08 17:18:32 UTC (rev 94765)
@@ -6,6 +6,12 @@
layoutTestController.waitUntilDone();
layoutTestController.dumpAsText();
layoutTestController.dumpChildFramesAsText();
+
+ // Start with a clean state, as otherwise an expired cookie for this domain could affect behavior with CFNetwork.
+ // Can be removed once <rdar://problem/10080130> is fixed.
+ if (layoutTestController.setPrivateBrowsingEnabled)
+ layoutTestController.setPrivateBrowsingEnabled(true);
+
layoutTestController.setAlwaysAcceptCookies(false);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
